fish: 4.2.0 -> 4.2.1

[ddogfoodd]

Changelog: https://github.com/fish-shell/fish-shell/releases/tag/4.2.1
Diff: fish-shell/fish-shell@4.2.0...4.2.1

Things done

• Built on platform:
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• Tested, as applicable:
  • NixOS tests in nixos/tests.
  • Package tests at passthru.tests.
  • Tests in lib/tests or pkgs/test for functions and "core" functionality.
• Ran nixpkgs-review on this PR. See nixpkgs-review usage.
• Tested basic functionality of all binary files, usually in ./result/bin/.
• Nixpkgs Release Notes
  • Package update: when the change is major or breaking.
• NixOS Release Notes
  • Module addition: when adding a new NixOS module.
  • Module update: when the change is significant.
• Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

---

Add a 👍 reaction to pull requests you find important.

[DieracDelta]

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 461243
Commit: 543ab11a55b9d298a1021f8e8511ea8e4f1dc3f7

---

x86_64-linux

✅ 32 packages built:

• bat-extras.batdiff
• bat-extras.batgrep
• bat-extras.batman
• bat-extras.batpipe
• bat-extras.batwatch
• bat-extras.core
• bat-extras.prettybat
• direnv
• fish
• fish-lsp
• fish.doc
• fishMinimal
• fishMinimal.doc
• fishPlugins.bass
• fishPlugins.done
• fishPlugins.fishtape
• fishPlugins.fishtape_3
• fishPlugins.fzf-fish
• fishPlugins.humantime-fish
• fishPlugins.pure
• fzf-git-sh
• kitty
• kitty.kitten
• kitty.shell_integration
• kitty.terminfo
• mise
• nixpkgs-manual
• oh-my-fish
• swaynotificationcenter
• tests.writers.bin.fish
• tests.writers.simple.fish
• vimPlugins.direnv-vim

[adamcstephens]

The python tests on darwin are failing. It looks like this is happening now on master too. I'd built the 4.2.0 PR version on aarch64-darwin so maybe it's triggered by another change, but we need to fix this.

fish> Traceback (most recent call last):
fish>   File "/nix/var/nix/builds/nix-7396-2102772239/source/tests/pexpects/disable_mouse.py", line 2, in <module>
fish>     from pexpect_helper import SpawnedProc
fish>   File "/nix/var/nix/builds/nix-7396-2102772239/source/tests/pexpect_helper.py", line 24, in <module>
fish>     import pexpect
fish> ModuleNotFoundError: No module named 'pexpect'
fish> Tmpdir is /nix/var/nix/builds/nix-7396-2102772239/fishtest-root-0jwqqi_o/fishtest-kdpxxqqm

[ddogfoodd]

I don't see why pexpect would not be found anymore, any ideas?

[adamcstephens]

This is an issue introduced by the last staging-next merge. I'm currently bisecting to see if I can track down the offending change. For the purposes of this PR, we can move forward as fish on darwin is already broken in master.

[adamcstephens]

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 461243 --additional-package fish.tests
Commit: 543ab11a55b9d298a1021f8e8511ea8e4f1dc3f7

---

x86_64-linux

✅ 32 packages built:

• bat-extras.batdiff
• bat-extras.batgrep
• bat-extras.batman
• bat-extras.batpipe
• bat-extras.batwatch
• bat-extras.core
• bat-extras.prettybat
• direnv
• fish
• fish-lsp
• fish.doc
• fish.tests.fishConfig
• fish.tests.nixos
• fishMinimal
• fishMinimal.doc
• fishPlugins.bass
• fishPlugins.done
• fishPlugins.fishtape
• fishPlugins.fishtape_3
• fishPlugins.fzf-fish
• fishPlugins.humantime-fish
• fishPlugins.pure
• fzf-git-sh
• kitty
• kitty.kitten
• kitty.shell_integration
• kitty.terminfo
• mise
• oh-my-fish
• swaynotificationcenter
• tests.writers.bin.fish
• tests.writers.simple.fish

---

aarch64-linux

✅ 32 packages built:

• bat-extras.batdiff
• bat-extras.batgrep
• bat-extras.batman
• bat-extras.batpipe
• bat-extras.batwatch
• bat-extras.core
• bat-extras.prettybat
• direnv
• fish
• fish-lsp
• fish.doc
• fish.tests.fishConfig
• fish.tests.nixos
• fishMinimal
• fishMinimal.doc
• fishPlugins.bass
• fishPlugins.done
• fishPlugins.fishtape
• fishPlugins.fishtape_3
• fishPlugins.fzf-fish
• fishPlugins.humantime-fish
• fishPlugins.pure
• fzf-git-sh
• kitty
• kitty.kitten
• kitty.shell_integration
• kitty.terminfo
• mise
• oh-my-fish
• swaynotificationcenter
• tests.writers.bin.fish
• tests.writers.simple.fish

[ddogfoodd]

FYI: There is PR #461779 to fix that pexpect is not found on darwin.