Skip to content

androidenv: fix name overriding#458190

Merged
numinit merged 1 commit intoNixOS:masterfrom
ShamrockLee:androidenv-name-overriding
Nov 4, 2025
Merged

androidenv: fix name overriding#458190
numinit merged 1 commit intoNixOS:masterfrom
ShamrockLee:androidenv-name-overriding

Conversation

@ShamrockLee
Copy link
Contributor

@ShamrockLee ShamrockLee commented Nov 3, 2025 •
edited by numinit
Loading

Use overrideAttrs to specify the FOD name we want, instead of specifying pname and version and expect a broken overrideAttrs from fetchurl that won't update name.

Initial effort for:

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@ShamrockLee
androidenv: fix name overriding
e1f3d9e 
Use `overrideAttrs` to specify the FOD name we want,
instead of specifying `pname` and `version`
and expect a broken overrideAttrs that won't update `name`.
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Nov 3, 2025
@ShamrockLee
Copy link
Contributor Author

ShamrockLee commented Nov 3, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 458190
Commit: e1f3d9e0aecf1603e87592d7dddc988b1b9fce81

@ShamrockLee ShamrockLee marked this pull request as ready for review November 3, 2025 18:51
@ShamrockLee ShamrockLee mentioned this pull request Nov 3, 2025
Merged
13 tasks
numinit
numinit reviewed Nov 4, 2025
View reviewed changes
Copy link
Contributor

@numinit numinit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@numinit numinit added this pull request to the merge queue Nov 4, 2025
Merged via the queue into NixOS:master with commit 54ea1a1 Nov 4, 2025
37 of 39 checks passed
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Nov 4, 2025

Successfully created backport PR for release-25.05:

@github-actions github-actions bot added the 8.has: port to stable This PR already has a backport to the stable release. label Nov 4, 2025
@nixpkgs-ci nixpkgs-ci bot mentioned this pull request Nov 4, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@numinit numinit numinit approved these changes

@JohnRTitor JohnRTitor Awaiting requested review from JohnRTitor

@adrian-gierakowski adrian-gierakowski Awaiting requested review from adrian-gierakowski

@RossComputerGuy RossComputerGuy Awaiting requested review from RossComputerGuy

@hadilq hadilq Awaiting requested review from hadilq

Assignees

No one assigned

Labels

8.has: port to stable This PR already has a backport to the stable release. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ShamrockLee @numinit