fetchurl: make pname and version overridable via <pkg>.overrideAttrs#458183
Merged
philiptaron merged 1 commit intoNixOS:masterfrom Nov 5, 2025
Merged
Conversation
nixpkgs-ci
bot
added
10.rebuild-darwin: 0
This was referenced Nov 3, 2025
ShamrockLee
force-pushed
the
fetchurl-overriding-pname-version
branch
from
0ee0b05 to
7e212bf
Compare
philiptaron
approved these changes
Nov 5, 2025
Contributor
|
I'm not so sure about the backport. |
Contributor
Author
That's just a miskake. I only mean to backport the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make
namereferencesfinalAttrs.pnameandfinalAttrs.versioninstead ofargs.pnameandargs.version.This PR depends on:
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.