Skip to content

androidenv: fix name overriding #458190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
numinit merged 1 commit into from
Nov 4, 2025
Merged

androidenv: fix name overriding #458190

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions pkgs/development/mobile/androidenv/compose-android-packages.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,18 +190,21 @@ let
map (
archive:
(fetchurl {
pname = packageInfo.name;
version = packageInfo.revision;
inherit (archive) url sha1;
inherit meta;
passthru = {
info = packageInfo;
};
}).overrideAttrs
(prev: {
# fetchurl won't generate the correct filename if we specify pname and version,
# and we still want the version attribute to show up in search, so specify these in an override
pname = packageInfo.name;
version = packageInfo.revision;
})
(
finalAttrs: previousAttrs: {
# fetchurl prioritize `pname` and `version` over the specified `name`,
# so specify custom `name` in an override.
name = baseNameOf (lib.head (finalAttrs.urls));
}
)
) validArchives
)
)
Expand Down
Loading