dragonflydb: 0.1.0 -> 1.34.2 by typedrat · Pull Request #452792 · NixOS/nixpkgs

typedrat · 2025-10-17T02:23:58Z

It's been several years since this was touched. Honestly, I can't entirely blame anyone considering what a pain it was to update 😅.

Closes: #243300
Closes: #361454
Closes: #405217
Closes: #405608
Closes: #452741

maintainer: @Yureien

Things done

Add a 👍 reaction to pull requests you find important.

Sigmanificient · 2025-10-17T18:55:53Z

`nixpkgs-review` result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 452792
Commit: eb4545fe9104bc1065131e7958b0187e0f1c67b4 (subsequent changes)
Merge: ba8d85d0ab61309d6875ea58a509e016693cd10c

Logs: https://github.com/Sigmanificient/nixpkgs-review-gha/actions/runs/18600616252

`x86_64-linux`

❌ 2 packages failed to build:

croncpp
dragonflydb

✅ 14 packages built:

python312Packages.meta-memcache
python312Packages.meta-memcache-socket
python312Packages.meta-memcache-socket.dist
python312Packages.meta-memcache.dist
python312Packages.uhashring
python312Packages.uhashring.dist
python313Packages.meta-memcache
python313Packages.meta-memcache-socket
python313Packages.meta-memcache-socket.dist
python313Packages.meta-memcache.dist
python313Packages.uhashring
python313Packages.uhashring.dist
tests.pkgs-lib
uni-algo

`aarch64-linux`

❌ 2 packages failed to build:

croncpp
dragonflydb

✅ 14 packages built:

python312Packages.meta-memcache
python312Packages.meta-memcache-socket
python312Packages.meta-memcache-socket.dist
python312Packages.meta-memcache.dist
python312Packages.uhashring
python312Packages.uhashring.dist
python313Packages.meta-memcache
python313Packages.meta-memcache-socket
python313Packages.meta-memcache-socket.dist
python313Packages.meta-memcache.dist
python313Packages.uhashring
python313Packages.uhashring.dist
tests.pkgs-lib
uni-algo

`x86_64-darwin` (sandbox = true)

❌ 1 package failed to build:

croncpp

✅ 14 packages built:

python312Packages.meta-memcache
python312Packages.meta-memcache-socket
python312Packages.meta-memcache-socket.dist
python312Packages.meta-memcache.dist
python312Packages.uhashring
python312Packages.uhashring.dist
python313Packages.meta-memcache
python313Packages.meta-memcache-socket
python313Packages.meta-memcache-socket.dist
python313Packages.meta-memcache.dist
python313Packages.uhashring
python313Packages.uhashring.dist
tests.pkgs-lib
uni-algo

`aarch64-darwin` (sandbox = true)

❌ 1 package failed to build:

croncpp

✅ 14 packages built:

python312Packages.meta-memcache
python312Packages.meta-memcache-socket
python312Packages.meta-memcache-socket.dist
python312Packages.meta-memcache.dist
python312Packages.uhashring
python312Packages.uhashring.dist
python313Packages.meta-memcache
python313Packages.meta-memcache-socket
python313Packages.meta-memcache-socket.dist
python313Packages.meta-memcache.dist
python313Packages.uhashring
python313Packages.uhashring.dist
tests.pkgs-lib
uni-algo

mdaniels5757 · 2025-10-17T21:01:24Z

pkgs/by-name/dr/dragonflydb/package.nix

@@ -112,6 +278,9 @@ stdenv.mkDerivation {
    homepage = "https://dragonflydb.io/";
    license = licenses.bsl11;
    platforms = platforms.linux;
-    maintainers = with maintainers; [ yureien ];
+    maintainers = with maintainers; [
+      typedrat


You are a brave soul.

Seriously, I could NEVER.

We're standardizing on using Nix for our development environment at work, and well... That means we need all of our runtime dependencies to be up to date in nixpkgs.

Thankfully, I think that most updates in the future will be more or less mechanical tweaks to the patch files. (Famous last words?)

pkgs/by-name/dr/dragonflydb/package.nix

mdaniels5757

One other thing: the commit message for your last commit should be "dragonflydb: 0.1.0 -> 1.34.2". Same for the PR title.

typedrat · 2025-10-18T07:57:47Z

I don't have access to a Mac and their docs simultaneously claim that they're Linux only but then they have a bunch of Mac stuff in their CMake configs? It may end up being for the best to just follow upstream and say it's Linux-only.

mdaniels5757 · 2025-10-18T15:17:05Z

Sounds good to me.

typedrat · 2025-10-18T21:57:26Z

I have done so.

mdaniels5757 · 2025-10-19T01:29:54Z

`nixpkgs-review` result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 452792 --build-args='-L'
Commit: d433f80fa424f6e4a87b070f13689eef91ece169 (subsequent changes)
Merge: 03a04edeb34fbf1eeccc44f82f154de87990acd5

Logs: https://github.com/mdaniels5757/nixpkgs-review-gha/actions/runs/18623509990

`x86_64-linux`

✅ 3 packages built:

croncpp
dragonflydb
uni-algo

`aarch64-linux`

✅ 3 packages built:

croncpp
dragonflydb
uni-algo

`x86_64-darwin` (sandbox = true)

✅ 2 packages built:

croncpp
uni-algo

`aarch64-darwin` (sandbox = true)

✅ 2 packages built:

croncpp
uni-algo

mdaniels5757

Approved automatically following the successful run of nixpkgs-review.

pkgs/by-name/dr/dragonflydb/package.nix

leona-ya · 2025-10-31T17:27:09Z

We were asked about this change because of the NixOS release freeze. I would say, we can still update it, as having a more up-to-date package that receives security updates.

Tho, have you tested that the NixOS module still works and does the automatic migration of the data directory work? I see no comment that this was tested in this PR. Could you please also add a release note entry.

LeSuisse · 2025-10-31T19:27:43Z

Also setting a security flag on this. A quick look shows multiple issues (CVE-2025-26268, CVE-2025-26269, CVE-2025-52935…) and I'm guessing my 15 seconds search on a smartphone is incomplete

typedrat · 2025-11-01T04:16:53Z

Also setting a security flag on this. A quick look shows multiple issues (CVE-2025-26268, CVE-2025-26269, CVE-2025-52935…) and I'm guessing my 15 seconds search on a smartphone is incomplete

Those are all resolved, as is every other CVE I can find against dragonflydb.

typedrat · 2025-11-01T04:20:33Z

We were asked about this change because of the NixOS release freeze. I would say, we can still update it, as having a more up-to-date package that receives security updates.

Tho, have you tested that the NixOS module still works and does the automatic migration of the data directory work? I see no comment that this was tested in this PR. Could you please also add a release note entry.

Can confirm that the NixOS module still works at a fundamental level, but I haven't exercised every option. The options-to-flags mapping seems current from a quick glance over the docs.

Haven't tested data dir migration.

typedrat · 2025-11-01T04:24:08Z

This is my first time touching the release notes, so if you want me to squash it or change the line I added, please tell me.

LeSuisse · 2025-11-08T11:03:21Z

Rebuilded locally and played a bit with it. Everything seems to be OK. Can you rebase to resolve the conflict on the release notes so we can merge this?

typedrat · 2025-11-08T21:09:13Z

Rebuilded locally and played a bit with it. Everything seems to be OK. Can you rebase to resolve the conflict on the release notes so we can merge this?

Done.

LeSuisse

Let's merge

`nixpkgs-review` result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 452792
Commit: 5f938a94bcfa4151f24652359745504f4786a449

`x86_64-linux`

⏩ 1 package blacklisted:

tests.nixos-functions.nixos-test

✅ 4 packages built:

croncpp
dragonflydb
nixpkgs-manual
uni-algo

typedrat mentioned this pull request Oct 17, 2025

dragonflydb: 0.1.0 -> 1.34.2 #452741

Closed

13 tasks

typedrat force-pushed the update-dragonflydb-1.34.2 branch from 6266451 to 78f455f Compare October 17, 2025 02:30

nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 6.topic: python Python is a high-level, general-purpose programming language. labels Oct 17, 2025

nix-owners bot requested review from Yureien and natsukium October 17, 2025 02:35

typedrat force-pushed the update-dragonflydb-1.34.2 branch from 78f455f to eb4545f Compare October 17, 2025 02:51

mdaniels5757 reviewed Oct 17, 2025

View reviewed changes

pkgs/by-name/dr/dragonflydb/package.nix Outdated Show resolved Hide resolved

mdaniels5757 reviewed Oct 17, 2025

View reviewed changes

pkgs/by-name/dr/dragonflydb/package.nix Show resolved Hide resolved

mdaniels5757 reviewed Oct 17, 2025

View reviewed changes

pkgs/by-name/dr/dragonflydb/package.nix Outdated Show resolved Hide resolved

mdaniels5757 reviewed Oct 17, 2025

View reviewed changes

typedrat changed the title ~~dragonflydb: update 0.1.0 to 1.34.2~~ dragonflydb: 0.1.0 -> 1.34.2 Oct 17, 2025

typedrat force-pushed the update-dragonflydb-1.34.2 branch 2 times, most recently from ee43a7b to 11afb61 Compare October 18, 2025 00:51

This was referenced Oct 18, 2025

python3Packages.meta-memcache: init at 2.0.2 #453090

Open

python3Packages.uhashring: init at 2.4 #453091

Merged

typedrat force-pushed the update-dragonflydb-1.34.2 branch from 11afb61 to 35e95bd Compare October 18, 2025 00:57

nixpkgs-ci bot removed the 6.topic: python Python is a high-level, general-purpose programming language. label Oct 18, 2025

This comment was marked as outdated.

Sign in to view

typedrat force-pushed the update-dragonflydb-1.34.2 branch from 35e95bd to d433f80 Compare October 18, 2025 21:57

mdaniels5757 approved these changes Oct 19, 2025

View reviewed changes

mdaniels5757 reviewed Oct 19, 2025

View reviewed changes

pkgs/by-name/dr/dragonflydb/package.nix Show resolved Hide resolved

nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Oct 19, 2025

LeSuisse added the 1.severity: security Issues which raise a security issue, or PRs that fix one label Oct 31, 2025

typedrat force-pushed the update-dragonflydb-1.34.2 branch from 72b0527 to 03c505e Compare November 1, 2025 04:24

typedrat added 4 commits November 8, 2025 13:06

croncpp: init at 2023.03.30

3974c53

uni-algo: init at 1.2.0

b3605e2

dragonflydb: 0.1.0 -> 1.34.2

c3f511b

dragonflydb: add release notes mention

5f938a9

typedrat force-pushed the update-dragonflydb-1.34.2 branch from 03c505e to 5f938a9 Compare November 8, 2025 21:08

nixpkgs-ci bot added 8.has: changelog This PR adds or changes release notes 8.has: documentation This PR adds or changes documentation and removed 2.status: merge conflict This PR has merge conflicts with the target branch labels Nov 8, 2025

mdaniels5757 requested a review from LeSuisse November 8, 2025 22:43

LeSuisse approved these changes Nov 9, 2025

View reviewed changes

LeSuisse added this pull request to the merge queue Nov 9, 2025

nixpkgs-ci bot added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Nov 9, 2025

Merged via the queue into NixOS:master with commit c359008 Nov 9, 2025
31 of 33 checks passed

typedrat deleted the update-dragonflydb-1.34.2 branch November 9, 2025 20:55

Uh oh!

Conversation

typedrat commented Oct 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Things done

Uh oh!

Sigmanificient commented Oct 17, 2025

nixpkgs-review result

x86_64-linux

aarch64-linux

x86_64-darwin (sandbox = true)

aarch64-darwin (sandbox = true)

Uh oh!

mdaniels5757 Oct 17, 2025

Choose a reason for hiding this comment

Uh oh!

mdaniels5757 Oct 17, 2025

Choose a reason for hiding this comment

Uh oh!

typedrat Oct 17, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mdaniels5757 left a comment

Choose a reason for hiding this comment

Uh oh!

This comment was marked as outdated.

typedrat commented Oct 18, 2025

Uh oh!

mdaniels5757 commented Oct 18, 2025

Uh oh!

typedrat commented Oct 18, 2025

Uh oh!

mdaniels5757 commented Oct 19, 2025

nixpkgs-review result

x86_64-linux

aarch64-linux

x86_64-darwin (sandbox = true)

aarch64-darwin (sandbox = true)

Uh oh!

mdaniels5757 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

leona-ya commented Oct 31, 2025

Uh oh!

LeSuisse commented Oct 31, 2025

Uh oh!

typedrat commented Nov 1, 2025

Uh oh!

typedrat commented Nov 1, 2025

Uh oh!

typedrat commented Nov 1, 2025

Uh oh!

LeSuisse commented Nov 8, 2025

Uh oh!

typedrat commented Nov 8, 2025

Uh oh!

LeSuisse left a comment

Choose a reason for hiding this comment

nixpkgs-review result

x86_64-linux

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

typedrat commented Oct 17, 2025 •

edited

Loading

`nixpkgs-review` result

`x86_64-linux`

`aarch64-linux`

`x86_64-darwin` (sandbox = true)

`aarch64-darwin` (sandbox = true)

`nixpkgs-review` result

`x86_64-linux`

`aarch64-linux`

`x86_64-darwin` (sandbox = true)

`aarch64-darwin` (sandbox = true)

`nixpkgs-review` result

`x86_64-linux`