Skip to content

python3Packages.meta-memcache: init at 2.0.2#453090

Open
typedrat wants to merge 2 commits intoNixOS:masterfrom
typedrat:add-meta-memcache
Open

python3Packages.meta-memcache: init at 2.0.2#453090
typedrat wants to merge 2 commits intoNixOS:masterfrom
typedrat:add-meta-memcache

Conversation

@typedrat
Copy link
Contributor

This is a Python library used by the dragonflydb test suite. I'm moving this to a separate PR because I'm removing the attempt to get the test suite working from #452792, but I don't want to just let this hit the bitbucket.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@typedrat typedrat changed the title meta-memcache: init at 2.0.2 python3Packages.meta-memcache: init at 2.0.2 Oct 18, 2025
@typedrat
Copy link
Contributor Author

This is dependent on #453091.

@typedrat
Copy link
Contributor Author

I believe I've taken care of things.

@typedrat typedrat force-pushed the add-meta-memcache branch 2 times, most recently from 3d7f5ae to abe1f19 Compare October 18, 2025 23:14
@dotlambda dotlambda closed this Oct 19, 2025
@dotlambda dotlambda reopened this Oct 19, 2025
src = fetchFromGitHub {
owner = "RevenueCat";
repo = "meta-memcache-py";
tag = "v2.0.2";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
tag = "v2.0.2";
tag = "v${version}";

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 6.topic: python Python is a high-level, general-purpose programming language. labels Oct 19, 2025
@nix-owners nix-owners bot requested a review from natsukium October 19, 2025 03:18
@dotlambda
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 453090
Commit: abe1f193f2c04816559a32d2bf3bcdeae56c8ec2


x86_64-linux

❌ 4 packages failed to build:
  • python312Packages.meta-memcache
  • python312Packages.meta-memcache.dist
  • python313Packages.meta-memcache
  • python313Packages.meta-memcache.dist
✅ 4 packages built:
  • python312Packages.meta-memcache-socket
  • python312Packages.meta-memcache-socket.dist
  • python313Packages.meta-memcache-socket
  • python313Packages.meta-memcache-socket.dist

Error logs: `x86_64-linux`
python312Packages.meta-memcache
    from pytest_mock import MockerFixture
E   ModuleNotFoundError: No module named 'pytest_mock'
____________ ERROR collecting tests/probabilistic_hot_cache_test.py ____________
ImportError while importing test module '/build/source/tests/probabilistic_hot_cache_test.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
/nix/store/27fr7ynpilzb7rzmay73g905jbl8br4a-python3-3.12.11/lib/python3.12/importlib/__init__.py:90: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
tests/probabilistic_hot_cache_test.py:4: in <module>
    from prometheus_client import CollectorRegistry
E   ModuleNotFoundError: No module named 'prometheus_client'
=========================== short test summary info ============================
ERROR tests/cache_client_test.py
ERROR tests/commands_test.py
ERROR tests/ephemeral_cache_client_test.py
ERROR tests/memcache_socket_test.py
ERROR tests/probabilistic_hot_cache_test.py
!!!!!!!!!!!!!!!!!!! Interrupted: 5 errors during collection !!!!!!!!!!!!!!!!!!!!
============================== 5 errors in 0.65s ===============================
python313Packages.meta-memcache
    from pytest_mock import MockerFixture
E   ModuleNotFoundError: No module named 'pytest_mock'
____________ ERROR collecting tests/probabilistic_hot_cache_test.py ____________
ImportError while importing test module '/build/source/tests/probabilistic_hot_cache_test.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
/nix/store/62fdlzq1x1ak2lsxp4ij7ip5k9nia3hc-python3-3.13.7/lib/python3.13/importlib/__init__.py:88: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
tests/probabilistic_hot_cache_test.py:4: in <module>
    from prometheus_client import CollectorRegistry
E   ModuleNotFoundError: No module named 'prometheus_client'
=========================== short test summary info ============================
ERROR tests/cache_client_test.py
ERROR tests/commands_test.py
ERROR tests/ephemeral_cache_client_test.py
ERROR tests/memcache_socket_test.py
ERROR tests/probabilistic_hot_cache_test.py
!!!!!!!!!!!!!!!!!!! Interrupted: 5 errors during collection !!!!!!!!!!!!!!!!!!!!
============================== 5 errors in 0.62s ===============================

@dotlambda
Copy link
Member

dotlambda commented Oct 19, 2025

Please stop filing PRs with packages that don't even build. I'm not merging your crap anymore.
If you need help getting tests to work you could ask for that rather than claim everything builds:

  • x86_64-linux

@typedrat
Copy link
Contributor Author

typedrat commented Oct 19, 2025

I tested it on my machine... I said above that it depended on #453091 being merged first. It has been. Let me rebase and it'll work.

@typedrat
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 453090
Commit: 4e8718ce21d83460b49a7dd4baeb6741c60425ba


x86_64-linux

✅ 8 packages built:
  • python312Packages.meta-memcache
  • python312Packages.meta-memcache-socket
  • python312Packages.meta-memcache-socket.dist
  • python312Packages.meta-memcache.dist
  • python313Packages.meta-memcache
  • python313Packages.meta-memcache-socket
  • python313Packages.meta-memcache-socket.dist
  • python313Packages.meta-memcache.dist

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants