python3Packages.meta-memcache: init at 2.0.2#453090
Open
typedrat wants to merge 2 commits intoNixOS:masterfrom
Open
python3Packages.meta-memcache: init at 2.0.2#453090typedrat wants to merge 2 commits intoNixOS:masterfrom
typedrat wants to merge 2 commits intoNixOS:masterfrom
Conversation
Contributor
Author
|
This is dependent on #453091. |
dotlambda
requested changes
Oct 18, 2025
pkgs/development/python-modules/meta-memcache-socket/default.nix
Outdated
Show resolved
Hide resolved
pkgs/development/python-modules/meta-memcache-socket/default.nix
Outdated
Show resolved
Hide resolved
pkgs/development/python-modules/meta-memcache-socket/default.nix
Outdated
Show resolved
Hide resolved
aaeb3ef to
85728a5
Compare
Contributor
Author
|
I believe I've taken care of things. |
dotlambda
reviewed
Oct 18, 2025
3d7f5ae to
abe1f19
Compare
dotlambda
reviewed
Oct 19, 2025
| src = fetchFromGitHub { | ||
| owner = "RevenueCat"; | ||
| repo = "meta-memcache-py"; | ||
| tag = "v2.0.2"; |
Member
There was a problem hiding this comment.
Suggested change
| tag = "v2.0.2"; | |
| tag = "v${version}"; |
Member
|
Member
|
Please stop filing PRs with packages that don't even build. I'm not merging your crap anymore.
|
Contributor
Author
|
I tested it on my machine... I said above that it depended on #453091 being merged first. It has been. Let me rebase and it'll work. |
abe1f19 to
24f31a5
Compare
24f31a5 to
4e8718c
Compare
Contributor
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a Python library used by the dragonflydb test suite. I'm moving this to a separate PR because I'm removing the attempt to get the test suite working from #452792, but I don't want to just let this hit the bitbucket.
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.