Skip to content

dragonflydb: 0.1.0 -> 1.34.2#452741

Closed
mdaniels5757 wants to merge 1 commit intoNixOS:masterfrom
mdaniels5757:dragonflydb
Closed

dragonflydb: 0.1.0 -> 1.34.2#452741
mdaniels5757 wants to merge 1 commit intoNixOS:masterfrom
mdaniels5757:dragonflydb

Conversation

@mdaniels5757
Copy link
Member

@mdaniels5757 mdaniels5757 commented Oct 16, 2025

Well, this was a massive pain. At least it's over?

Closes: #243300
Closes: #361454
Closes: #405217
Closes: #405608

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@mdaniels5757 @nrhtr @dblsaiko
dragonflydb: 0.1.0 -> 1.34.2
f048f83 
Co-authored-by: Jeremy Parker <jeremy@jenga.xyz>
Co-authored-by: Katalin Rebhan <me@dblsaiko.net>
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. labels Oct 16, 2025
@nix-owners nix-owners bot requested a review from Yureien October 16, 2025 21:33
@mdaniels5757
Copy link
Member Author

mdaniels5757 commented Oct 16, 2025 •
edited
Loading

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 452741 --build-args='-L'
Commit: f048f83c25aeaa270c8af87d27c6fecc2a4261cf (subsequent changes)
Merge: 7b9098ee973e4cc7e766d450fa7df059334052cd

Logs: https://github.com/mdaniels5757/nixpkgs-review-gha/actions/runs/18575474831

x86_64-linux

✅ 2 packages built:

  • dragonflydb
  • tests.pkgs-lib

aarch64-linux

✅ 2 packages built:

  • dragonflydb
  • tests.pkgs-lib

x86_64-darwin (sandbox = true)

✅ 1 package built:

  • tests.pkgs-lib

aarch64-darwin (sandbox = true)

✅ 1 package built:

  • tests.pkgs-lib

@typedrat
Copy link
Contributor

typedrat commented Oct 17, 2025

Well, uh, this is a hell of a time to see this lmao

I just submitted #452792, which is my own approach to doing this.

@mdaniels5757 mdaniels5757 marked this pull request as draft October 17, 2025 21:08
@mdaniels5757
Copy link
Member Author

mdaniels5757 commented Oct 17, 2025

@typedrat Since you're volunteering to maintain this (!), I feel like your PR should be the one to get merged. Leaving this open so you can crib from it as needed; just add this PR to the "Closes:" list in your PR so it can be cleaned up automatically.

@typedrat typedrat mentioned this pull request Oct 17, 2025
Merged
13 tasks
@mdaniels5757 mdaniels5757 deleted the dragonflydb branch November 9, 2025 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Yureien Yureien Awaiting requested review from Yureien

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update Request: dragonflydb 0.1.0 → 1.29.0 Update request: dragonflydb 0.1.0 → 1.25.4

2 participants

@mdaniels5757 @typedrat