Skip to content

pattypan: unbreak#449257

Merged
tomodachi94 merged 1 commit intoNixOS:masterfrom
mdaniels5757:unbreak-pattypan
Oct 7, 2025
Merged

pattypan: unbreak#449257
tomodachi94 merged 1 commit intoNixOS:masterfrom
mdaniels5757:unbreak-pattypan

Conversation

@mdaniels5757
Copy link
Member

@mdaniels5757 mdaniels5757 commented Oct 6, 2025

This was broken by #443954.

Hydra failure: https://hydra.nixos.org/build/308417379

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

This was broken by NixOS#443954
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Oct 6, 2025
@nix-owners nix-owners bot requested a review from fee1-dead October 6, 2025 21:15
@mdaniels5757
Copy link
Member Author

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 449257
Commit: 65daf17219a9467b758c56a7c8516ea22935ba33 (subsequent changes)
Merge: ef3285150abaffdd43e438e2fa5f2ee9d26eb90e

Logs: https://github.com/mdaniels5757/nixpkgs-review-gha/actions/runs/18294528749


x86_64-linux

✅ 1 package built:
  • pattypan

aarch64-linux

✅ 1 package built:
  • pattypan

x86_64-darwin (sandbox = true)

✅ 1 package built:
  • pattypan

aarch64-darwin (sandbox = true)

✅ 1 package built:
  • pattypan

@fee1-dead
Copy link
Member

woah, didn't know people actually use this :o (im User:Dbeef btw)

will review once i get nixpkgs cloned

@mdaniels5757
Copy link
Member Author

Oddly enough, I just happened to notice it when trying to backport #443954. I don't bulk upload, so I don't use this myself.

Also: hi! Small world :).

@fee1-dead
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 449257
Commit: 65daf17219a9467b758c56a7c8516ea22935ba33


x86_64-linux

✅ 2 packages built:
  • nixpkgs-manual
  • pattypan

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Oct 6, 2025
Copy link
Member

@tomodachi94 tomodachi94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops! Good catch, that's embarassing. Thank you for investigating and backporting things!

(PS. if you're backporting #443954, please see #447873.)

@tomodachi94 tomodachi94 added this pull request to the merge queue Oct 7, 2025
@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Oct 7, 2025
Merged via the queue into NixOS:master with commit bbbd441 Oct 7, 2025
38 of 40 checks passed
@mdaniels5757 mdaniels5757 deleted the unbreak-pattypan branch October 7, 2025 11:48
@mdaniels5757
Copy link
Member Author

Thanks for the heads up. Tbh, especially given that there was another breakage, I don't see the need to backport it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants