treewide(java-users): clean callPackage overrides, by-name some#443954
Merged
jopejoe1 merged 1 commit intoNixOS:masterfrom Sep 27, 2025
Merged
Conversation
tomodachi94
force-pushed
the
enhance/treewide/java-overrides-cleanup
branch
3 times, most recently
from
f9e8483 to
69a84bc
Compare
tomodachi94
force-pushed
the
enhance/treewide/java-overrides-cleanup
branch
14 times, most recently
from
b1fb3fa to
3bd283a
Compare
tomodachi94
changed the title
tomodachi94
force-pushed
the
enhance/treewide/java-overrides-cleanup
branch
3 times, most recently
from
d4ca457 to
bf9792a
Compare
nixpkgs-ci
bot
added
10.rebuild-linux: 1-10
tomodachi94
force-pushed
the
enhance/treewide/java-overrides-cleanup
branch
from
bf9792a to
be9af41
Compare
tomodachi94
changed the title
nixpkgs-ci
bot
added
the
2.status: merge conflict
Member
Author
|
@wolfgangwalther should I drop the changes to |
Member
|
Yes, those changes were obsoleted by my serendipitous discovery that 1.18.5 does work with the default JRE, unlike previous versions. |
tomodachi94
force-pushed
the
enhance/treewide/java-overrides-cleanup
branch
from
1e9c2b6 to
4a02536
Compare
nixpkgs-ci
bot
added
12.approved-by: package-maintainer
Member
Author
|
Also attempting to backport this to make backports of version updates easier (less merge conflicts). |
tomodachi94
commented
Sep 21, 2025
tomodachi94
force-pushed
the
enhance/treewide/java-overrides-cleanup
branch
from
4a02536 to
dd1058b
Compare
tomodachi94
added
the
2.status: merge conflict
**This commit should cause no rebuilds.** # Moving Java overrides out of all-packages All usages of this pattern have been moved to 'let ... in' blocks. Patterns I searched for: * `jdk =` * `jdk_headless =` * `jre =` * `jfx =` The `jing` alias has been moved to aliases.nix, so update the usage of `jing` in `xmloscopy` to `jing-trang`. cassandra was ignored because that derivation involves code generation. I ignored grails, because jdk is set to null by default by an override in all-packages.nix. That package would need a slightly larger refactor to deal with. Packages with a *-native variant were ignored because those would need to be refactored. jetbrains was ignored because that might be a special case? I ignored virtualbox, because I did not want to touch the usages of the pattern for other dependencies.
tomodachi94
force-pushed
the
enhance/treewide/java-overrides-cleanup
branch
from
dd1058b to
a4dd7db
Compare
nixpkgs-ci
bot
removed
2.status: merge conflict
jopejoe1
approved these changes
Sep 25, 2025
Member
jopejoe1
left a comment
jopejoe1
left a comment
There was a problem hiding this comment.
Looks like an improvement to me!
nixpkgs-ci
bot
added
12.approvals: 2
Contributor
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release-25.05
git worktree add -d .worktree/backport-443954-to-release-25.05 origin/release-25.05
cd .worktree/backport-443954-to-release-25.05
git switch --create backport-443954-to-release-25.05
git cherry-pick -x a4dd7db0dc40f13289806c91c67a8bdd6f38ce96 |
mdaniels5757
added a commit
to mdaniels5757/nixpkgs
that referenced
this pull request
Oct 6, 2025
This was broken by NixOS#443954
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attn: please go to #444420 to discuss the usage of the pattern being removed here.
Most usages of the pattern of setting the specific
jdkversion viacallPackagehave been moved to'let ... in' blocks.
Patterns I searched for:
jdk =jdk_headless =jre =jfx =See commit message for more details about specific changes.
This commit should cause no rebuilds.
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.