clojure: restore jdk with override in all-packages#447873
Merged
tomodachi94 merged 1 commit intoNixOS:masterfrom Oct 2, 2025
Merged
clojure: restore jdk with override in all-packages#447873tomodachi94 merged 1 commit intoNixOS:masterfrom
jdk with override in all-packages#447873tomodachi94 merged 1 commit intoNixOS:masterfrom
Conversation
This broke some out-of-tree packages that expect to be able to override a `jdk` attribute. See the discussion at NixOS@a4dd7db#commitcomment-166836083
nixpkgs-ci
bot
added
10.rebuild-darwin: 0
tomodachi94
referenced
this pull request
Oct 2, 2025
**This commit should cause no rebuilds.** # Moving Java overrides out of all-packages All usages of this pattern have been moved to 'let ... in' blocks. Patterns I searched for: * `jdk =` * `jdk_headless =` * `jre =` * `jfx =` The `jing` alias has been moved to aliases.nix, so update the usage of `jing` in `xmloscopy` to `jing-trang`. cassandra was ignored because that derivation involves code generation. I ignored grails, because jdk is set to null by default by an override in all-packages.nix. That package would need a slightly larger refactor to deal with. Packages with a *-native variant were ignored because those would need to be refactored. jetbrains was ignored because that might be a special case? I ignored virtualbox, because I did not want to touch the usages of the pattern for other dependencies.
djds
approved these changes
Oct 2, 2025
djds
added a commit
to djds/nixpkgs
that referenced
this pull request
Oct 2, 2025
nixpkgs-ci
bot
added
the
12.approvals: 1
emerson-matos
approved these changes
Oct 2, 2025
nixpkgs-ci
bot
added
12.approvals: 2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This broke some out-of-tree packages that expect
to be able to override a
jdkattribute.See the discussion at
a4dd7db#commitcomment-166836083
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.