gridtracker2: 2.250914.1 -> 2.251106.7#459903
Merged
pyrox0 merged 1 commit intoNixOS:masterfrom Nov 9, 2025
Merged
Conversation
Member
|
we may need it in some versions, although not all the versions, otherwise build would fail, explained in #446675 (comment) |
Member
Author
|
The package-lock.json is not always necessarily updated when the package.json is modified. We would only have failing builds if the dependencies in package.json were updated but the package-lock.json was not, which from a brief glance through recent commits does not appear to be the case. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The package builds fine without the in-tree lockfile, so there is no reason to have it. Also, having it breaks the ability to auto-update the package with the added update script. Therefore, best to remove it and not bloat the nixpkgs tree with unneeded lockfiles.
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.