Skip to content

gridtracker2: 2.250914.1 -> 2.251106.7#459903

Merged
pyrox0 merged 1 commit intoNixOS:masterfrom
pyrox0:fix/gridtracker2-lockfile
Nov 9, 2025
Merged

gridtracker2: 2.250914.1 -> 2.251106.7#459903
pyrox0 merged 1 commit intoNixOS:masterfrom
pyrox0:fix/gridtracker2-lockfile

Conversation

@pyrox0
Copy link
Member

@pyrox0 pyrox0 commented Nov 8, 2025

The package builds fine without the in-tree lockfile, so there is no reason to have it. Also, having it breaks the ability to auto-update the package with the added update script. Therefore, best to remove it and not bloat the nixpkgs tree with unneeded lockfiles.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added the 2.status: merge-bot eligible This PR can be merged by commenting "@NixOS/nixpkgs-merge-bot merge". label Nov 8, 2025
@nixpkgs-ci nixpkgs-ci bot requested a review from Cryolitia November 8, 2025 23:29
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Nov 8, 2025
@Cryolitia
Copy link
Member

Cryolitia commented Nov 8, 2025

we may need it in some versions, although not all the versions, otherwise build would fail, explained in #446675 (comment)

@pyrox0
Copy link
Member Author

pyrox0 commented Nov 9, 2025

The package-lock.json is not always necessarily updated when the package.json is modified. We would only have failing builds if the dependencies in package.json were updated but the package-lock.json was not, which from a brief glance through recent commits does not appear to be the case.

Copy link
Member

@Cryolitia Cryolitia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Nov 9, 2025
@pyrox0 pyrox0 added this pull request to the merge queue Nov 9, 2025
Merged via the queue into NixOS:master with commit 16508be Nov 9, 2025
34 of 37 checks passed
@pyrox0 pyrox0 deleted the fix/gridtracker2-lockfile branch November 9, 2025 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2.status: merge-bot eligible This PR can be merged by commenting "@NixOS/nixpkgs-merge-bot merge". 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants