Skip to content

[Backport 25.05] teleport_18: init at 18.1.1; teleport_16: 16.5.13 -> 16.5.15; teleport_17: 17.5.4 -> 17.7.3; teleport_18: 18.1.1 -> 18.2.0#441311

Merged
philiptaron merged 9 commits intoNixOS:release-25.05from
JuliusFreudenberger:backport-teleport-18
Sep 11, 2025
Merged

[Backport 25.05] teleport_18: init at 18.1.1; teleport_16: 16.5.13 -> 16.5.15; teleport_17: 17.5.4 -> 17.7.3; teleport_18: 18.1.1 -> 18.2.0#441311
philiptaron merged 9 commits intoNixOS:release-25.05from
JuliusFreudenberger:backport-teleport-18

Conversation

@JuliusFreudenberger
Copy link
Contributor

Backport of #411095 and #429196

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

This facilitates using different Go and wasm-bindgen-cli versions more
easily, which will be needed for the new teleport_18 version.

(cherry picked from commit 2dee298)
This is needed for teleport_18

(cherry picked from commit c6d1d4d)
(cherry picked from commit f073e62)
The file was renamed upstream, so the patch and import have to be
updated respectively.

(cherry picked from commit b2570e4)
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 4.workflow: backport This targets a stable branch labels Sep 8, 2025
@JuliusFreudenberger
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 441311
Commit: 674734f59768276f827a084b3828140570a8c2cb


x86_64-linux

✅ 7 packages built:
  • teleport (teleport_17)
  • teleport.client (teleport_17.client)
  • teleport_16
  • teleport_16.client
  • teleport_18
  • teleport_18.client
  • wasm-bindgen-cli_0_2_99

@philiptaron philiptaron merged commit 10be3a5 into NixOS:release-25.05 Sep 11, 2025
34 of 36 checks passed
@JuliusFreudenberger JuliusFreudenberger deleted the backport-teleport-18 branch September 11, 2025 18:49
@simonzkl
Copy link
Contributor

This backport broke the ability to override withRdpClient through the teleport arg. Not sure what our policy is on breaking the callPackage override API in stable channels.

If anyone else runs into this, here's a workaround:

teleport_16.override { buildTeleport = args: buildTeleport (args // { withRdpClient = false; })

@JuliusFreudenberger
Copy link
Contributor Author

I'm really sorry this broke your workflow on stable. In my understanding (though no idea what the policy is), this should not have happened. Thank you for sharing the workaround.
I will work on a fix and make sure to also backport it to stable.

@philiptaron
Copy link
Contributor

philiptaron commented Sep 18, 2025

We definitely don't try to break it, but it's impossible to test all combinations. Here's the tracking issue for seeing if we can do better.

There are some cases where breaking it is good. See this comment on that issue.

In this case, we need something like @wolfgangwalther's PR to make lib.makeOverridable propagate .override to solve this case, or implement a specific fix for these by-name packages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4.workflow: backport This targets a stable branch 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants