Skip to content

teleport_18: init at 18.1.1#411095

Merged
tomberek merged 3 commits intoNixOS:masterfrom
JuliusFreudenberger:teleport_18
Aug 20, 2025
Merged

teleport_18: init at 18.1.1#411095
tomberek merged 3 commits intoNixOS:masterfrom
JuliusFreudenberger:teleport_18

Conversation

@JuliusFreudenberger
Copy link
Contributor

@JuliusFreudenberger JuliusFreudenberger commented May 26, 2025

This PR includes a migration to a build function buildTeleport, a new version of wasm-bindgen-cli and a new package teleport_18.

The default version will be bumped in a seperate PR, to allow backporting this one.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 24.11 and 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 24.11 and 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS label May 26, 2025
@ofborg ofborg bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label May 26, 2025
@JuliusFreudenberger JuliusFreudenberger changed the title teleport_18: init at current development version teleport_18: init at 18.0.0 May 29, 2025
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label May 29, 2025
@github-actions github-actions bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels May 29, 2025
@JuliusFreudenberger JuliusFreudenberger force-pushed the teleport_18 branch 2 times, most recently from 42904d4 to ba1518a Compare June 3, 2025 09:10
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Jun 9, 2025
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Jun 14, 2025
@github-actions github-actions bot added the 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. label Jun 14, 2025
@nixpkgs-ci nixpkgs-ci bot removed the 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. label Jul 3, 2025
@nixpkgs-ci nixpkgs-ci bot added the 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. label Jul 8, 2025
@JuliusFreudenberger JuliusFreudenberger marked this pull request as ready for review July 8, 2025 21:03
@JuliusFreudenberger
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 411095

Logs: https://github.com/JuliusFreudenberger/nixpkgs-review-gha/actions/runs/16154327597


x86_64-linux

✅ 3 packages built:
  • teleport_18
  • teleport_18.client
  • wasm-bindgen-cli_0_2_99

aarch64-linux

✅ 3 packages built:
  • teleport_18
  • teleport_18.client
  • wasm-bindgen-cli_0_2_99

x86_64-darwin (sandbox = true)

✅ 1 package built:
  • wasm-bindgen-cli_0_2_99

aarch64-darwin (sandbox = true)

✅ 1 package built:
  • wasm-bindgen-cli_0_2_99

JuliusFreudenberger referenced this pull request Jul 9, 2025
This is the simpler, more lightweight and better maintained version of
the hostname utility.
@JuliusFreudenberger
Copy link
Contributor Author

teleport not being available on darwin is because of #422282 and will be fixed in #423643. Will re-run nixpkgs-review once that landed.

@nixpkgs-ci nixpkgs-ci bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. and removed 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Jul 28, 2025
@techknowlogick
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 411095
Commit: 258762ba43a5d9deb3c34e07babbb4722e194ddd


aarch64-darwin

✅ 7 packages built:
  • teleport (teleport_17)
  • teleport.client (teleport_17.client)
  • teleport_16
  • teleport_16.client
  • teleport_18
  • teleport_18.client
  • wasm-bindgen-cli_0_2_99

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Jul 29, 2025
This facilitates using different Go and wasm-bindgen-cli versions more
easily, which will be needed for the new teleport_18 version.
This is needed for teleport_18
@techknowlogick
Copy link
Member

could you update the PR title too?

@JuliusFreudenberger JuliusFreudenberger changed the title teleport_18: init at 18.0.0 teleport_18: init at 18.1.0 Jul 29, 2025
@JuliusFreudenberger
Copy link
Contributor Author

Yes, sure. Completely forgot about that

@techknowlogick
Copy link
Member

No worries, haha. Just thought I'd give a nudge. Thanks again for keeping the versions up to date even if they don't always get merged immediately (still helpful for my internal flake).

@JuliusFreudenberger JuliusFreudenberger changed the title teleport_18: init at 18.1.0 teleport_18: init at 18.1.1 Jul 30, 2025
@tomberek
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 411095


x86_64-linux

✅ 8 packages built:
  • nixpkgs-manual
  • teleport (teleport_17)
  • teleport.client (teleport_17.client)
  • teleport_16
  • teleport_16.client
  • teleport_18
  • teleport_18.client
  • wasm-bindgen-cli_0_2_99

@tomberek tomberek merged commit 3104ac9 into NixOS:master Aug 20, 2025
27 of 28 checks passed
@JuliusFreudenberger JuliusFreudenberger deleted the teleport_18 branch August 25, 2025 07:19
@simonzkl
Copy link
Contributor

@JuliusFreudenberger How are we supposed to override withRdpClient with this change?

@simonzkl
Copy link
Contributor

simonzkl commented Sep 18, 2025

I'm using this workaround, but it feels a bit hacky:

teleport_16.override { buildTeleport = args: buildTeleport (args // { withRdpClient = false; })

@JuliusFreudenberger
Copy link
Contributor Author

Sorry, I didn't think about this override and will provide a better solution for this.
Thank you for sharing your workaround!

@philiptaron
Copy link
Contributor

github-merge-queue bot pushed a commit that referenced this pull request Sep 20, 2025
The interface for the overrides `withRdpClient` and `extPatches` was
removed with #411095.
philiptaron pushed a commit that referenced this pull request Sep 21, 2025
The interface for the overrides `withRdpClient` and `extPatches` was
removed with #411095.

(cherry picked from commit ec923b6)
aaron-nall pushed a commit to aaron-nall/nixpkgs that referenced this pull request Sep 25, 2025
The interface for the overrides `withRdpClient` and `extPatches` was
removed with NixOS#411095.

(cherry picked from commit ec923b6)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants