Upstream sessions by jtojnar · Pull Request #43992 · NixOS/nixpkgs

jtojnar · 2018-07-23T03:13:41Z

Motivation for this change

See #39871

This is just a first swallow, in the future pull requests we will want to convert more DEs and investigate Wayland.

Things done

cc @hedning, @worldofpeace

GrahamcOfBorg · 2018-07-23T03:24:44Z

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: gnome3.gdm, gnome3.gpaste

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

GrahamcOfBorg · 2018-07-23T04:07:30Z

Failure on x86_64-linux (full log)

Attempted: gnome3.gdm, gnome3.gpaste

Partial log (click to expand)

cannot build derivation '/nix/store/rnnrdjhvrarz8gmvfsmwq5lbpq2914iq-libgdata-0.17.9.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/rp8fzf629m8rx183yy5qy1dn2r530a7x-evolution-data-server-3.28.3.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/qf87jknlll6jn3ix547l6nvrzspqf0g6-grilo-plugins-0.3.5.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/6j3fiy4b8b8s865griqk6p3dg71cyn2z-tracker-miners-2.0.5.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/mb30fs25s83y8msliivqj814pbwnxd2m-nautilus-3.28.1.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/4x8933079xainrzq1db39r5mbjacsbbq-totem-3.26.1.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/7awmzq1rhzbw7z59zw7zy3gnj97y4nd9-cheese-3.28.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/lr6574abdh70w9byyx4f7irp1ia8q6f0-gnome-control-center-3.28.2.drv': 4 dependencies couldn't be built
cannot build derivation '/nix/store/sx6qhvgpjcfh3jlr0sinsl7vgjnm9jwa-gpaste-3.28.2.drv': 1 dependencies couldn't be built
error: build of '/nix/store/sx6qhvgpjcfh3jlr0sinsl7vgjnm9jwa-gpaste-3.28.2.drv' failed

GrahamcOfBorg · 2018-07-23T04:32:58Z

Failure on aarch64-linux (full log)

Attempted: gnome3.gdm, gnome3.gpaste

Partial log (click to expand)

cannot build derivation '/nix/store/lb3h5kiynhps8dafikvzbrdn46q3af7d-libgdata-0.17.9.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/ryvb61q946n7s6mk2pm0k6yi36a2syij-evolution-data-server-3.28.3.drv': 4 dependencies couldn't be built
cannot build derivation '/nix/store/lgch03spbz8mnsp92nxxhq3xxg9fqz08-grilo-plugins-0.3.5.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/ysn1xfa6xqhn12jfyih1n1b6nb59k2aq-tracker-miners-2.0.5.drv': 4 dependencies couldn't be built
cannot build derivation '/nix/store/9nyfnlhrcmjwz5xgl9wzi1fnvf5m0yks-nautilus-3.28.1.drv': 5 dependencies couldn't be built
cannot build derivation '/nix/store/8zplz5hcjw7hnm7bki1brvh283ppj7qd-totem-3.26.1.drv': 7 dependencies couldn't be built
cannot build derivation '/nix/store/9l2n51vhd9syqzn4kfwaap76n04h0lyi-cheese-3.28.0.drv': 5 dependencies couldn't be built
cannot build derivation '/nix/store/k1961fyvc9ihk96z5g84z832vyjv0qpx-gnome-control-center-3.28.2.drv': 11 dependencies couldn't be built
cannot build derivation '/nix/store/9bmz49x5zamxzcidl02nzxish9y7pn5b-gpaste-3.28.2.drv': 4 dependencies couldn't be built
error: build of '/nix/store/3yb1f44wmdpz6ivgcz9rr9lb7y9xjjq2-gdm-3.28.2.drv', '/nix/store/9bmz49x5zamxzcidl02nzxish9y7pn5b-gpaste-3.28.2.drv' failed

hedning · 2018-07-23T11:31:14Z

This seems like good start :)

Did a little testing (with gdm):

Login

Disregard, had a bad .xprofile that crashed the session.

~~1. Tested in a VM without password, which worked as expected~~
~~2. Tested on hardware with my regular user and couldn't log in~~

~~I'm getting this in the log:~~

juli 23 13:10:16 x1 gdm-password][4245]: gkr-pam: no password is available for user

~~Not sure how to reproduce in a VM as the user.password option is ignored for some reason.~~

GPaste

Gnome-control-center can't find the necessary gpaste schema, so it crashes:

Started Gnome Shell in a VM (passwordless user) with services.gnome3.gpaste.enabled = true.
Turned on the gpaste extension.
Tried launching gnome-control-center

Resulting in:

Jul 23 11:27:04 nixos .gnome-control-[1908]: Settings schema 'org.gnome.GPaste' is not installed

jtojnar · 2018-07-23T11:56:11Z

Add Login, maybe this:

If the option users.mutableUsers is true, the password defined in one of the three options will only be set when the user is created for the first time.

Ad GPaste, that is probably the keyboard shortcuts XML file. I do not think it is possible Maybe we could create gnome-control-center-with-plugins expression. Or just give up and re-add the session path (though I am not sure how to do it).

I tried lightdm now, but it does not even see the session. Also in the log, I see ** (lightdm-gtk-greeter:802): WARNING **: 11:41:49.170: [PIDs] Failed to execute command: /usr/lib/at-spi2-core/at-spi-bus-launcher

hedning · 2018-07-23T12:55:41Z

Right, setting mutable users to false made login work with a hardcoded password in a VM, not sure why it won't work on my hardware though (tested on two machines now, will investigate some more).

jtojnar · 2018-07-23T13:31:14Z

Regarding GPaste, I guess, we also could extend the KeyListEntries in the XML file with schemadir attribute and patch Control Center to respect it.

Mic92 · 2018-07-23T13:42:35Z

nixos/modules/services/x11/desktop-managers/gnome3.nix

        description = "Enable Gnome 3 desktop manager.";
      };

-      sessionPath = mkOption {


Is there a way to redirect users to the new option (extraSessionFilePackages?) instead?

It serves a completely different purpose. The replacement to sessionPath is fixing packages.

hedning · 2018-07-23T13:45:13Z

(had a bad .xprofile which caused the crash).

Another option for GPaste would be to compile the schema in /run/current-system/sw/share/glib-2.0/..., not sure if that's possible in a module though?

jtojnar · 2018-07-23T14:05:30Z

Yep, doing as you suggest in #42176 (comment) would be another possibility.

worldofpeace · 2018-07-23T16:19:27Z

Hmm, sddm doesn't see the session either. Maybe that's missing something.

jtojnar · 2018-07-23T16:23:39Z

There is TryExec=gnome-session in ${gnome3.gnome-session}/share/xsessions/gnome.desktop, so we probably need to patch that to absolute path.

worldofpeace · 2018-07-23T16:26:26Z

I thought it was already doing that,

nixpkgs/pkgs/desktops/gnome-3/core/gnome-session/default.nix

Line 37 in 72b27f2

sed -i "s,^Exec=gnome-session,Exec=$out/bin/gnome-session," $desktopFile

jtojnar · 2018-07-23T16:27:54Z

Well there is ^, so only lines starting with Exec will be matched.

worldofpeace · 2018-07-23T16:29:15Z

Oh, I skimmed and didn't notice TryExec.

worldofpeace · 2018-07-23T16:52:14Z

This should be fine

diff --git a/pkgs/desktops/gnome-3/core/gnome-session/default.nix b/pkgs/desktops/gnome-3/core/gnome-session/default.nix
index 7b407aad506..6f9cc384fa2 100644
--- a/pkgs/desktops/gnome-3/core/gnome-session/default.nix
+++ b/pkgs/desktops/gnome-3/core/gnome-session/default.nix
@@ -33,8 +33,10 @@ stdenv.mkDerivation rec {
   preFixup = ''
     for desktopFile in $(grep -rl "Exec=gnome-session" $out/share)
     do
-      echo "Patching gnome-session path in: $desktopFile"
+      echo "Patching Exec gnome-session path in: $desktopFile"
       sed -i "s,^Exec=gnome-session,Exec=$out/bin/gnome-session," $desktopFile
+      echo "Patching TryExec gnome-sesison path in: $desktopFile"
+      sed -i "s,^TryExec=gnome-session,TryExec=$out/bin/gnome-session," $desktopFile
     done
     wrapProgram "$out/bin/gnome-session" \
       --prefix PATH : "${glib.dev}/bin" \

worldofpeace · 2018-07-23T17:20:50Z

Also,

debug = mkEnableOption "gnome-session debug messages";

It would be nice to still have an interface to do that.

jtojnar · 2018-07-23T17:24:35Z

Adding environment.variables.GNOME_SESSION_DEBUG = "1"; will probably be the easiest.

worldofpeace · 2018-07-23T18:04:06Z

Do these lightdm errors look of any interest?

jtojnar · 2018-07-23T19:21:36Z

Not particularly.

With the latest commit, I am able to launch GNOME Shell in lightdm in VM, but it does not seem to receive environment variables (including PATH).

Also, I opened https://gitlab.gnome.org/GNOME/gnome-session/merge_requests/5 so we could drop the substs.

worldofpeace

Ahh so that's what it was about.

GrahamcOfBorg · 2018-07-23T19:41:23Z

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: gnome3.gdm, gnome3.gnome-session, gnome3.gpaste

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

GrahamcOfBorg · 2018-07-23T20:16:49Z

Failure on x86_64-linux (full log)

Attempted: gnome3.gdm, gnome3.gnome-session, gnome3.gpaste

Partial log (click to expand)

strip is /nix/store/fzsyclvxz1p2ia83caniy93v8cwarg0j-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/aw3hz1qsfas7hdnpqr8s27zzjnwlgv8g-cheese-3.28.0-man
checking for references to /build in /nix/store/aw3hz1qsfas7hdnpqr8s27zzjnwlgv8g-cheese-3.28.0-man...
shrinking RPATHs of ELF executables and libraries in /nix/store/bbrqw0s42lcfk6fr2rn213hj11hnl41d-cheese-3.28.0-devdoc
strip is /nix/store/fzsyclvxz1p2ia83caniy93v8cwarg0j-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/bbrqw0s42lcfk6fr2rn213hj11hnl41d-cheese-3.28.0-devdoc
checking for references to /build in /nix/store/bbrqw0s42lcfk6fr2rn213hj11hnl41d-cheese-3.28.0-devdoc...
cannot build derivation '/nix/store/vsysn71qypglwai1slisdjsi6sd80mgd-gnome-control-center-3.28.2.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/4zg3d8a52r9534a6y43di3p8s3afg7rc-gpaste-3.28.2.drv': 1 dependencies couldn't be built
error: build of '/nix/store/4zg3d8a52r9534a6y43di3p8s3afg7rc-gpaste-3.28.2.drv', '/nix/store/8vj9kcg09n2nm17c3n5jwidq8znl9f7z-gnome-session-3.28.1.drv' failed

GrahamcOfBorg · 2018-07-23T21:20:33Z

Failure on aarch64-linux (full log)

Attempted: gnome3.gdm, gnome3.gnome-session, gnome3.gpaste

Partial log (click to expand)

checking for references to /build in /nix/store/ypphf619vmn6z5p67vriczj2na7blsy1-pipewire-0.1.9-dev...
shrinking RPATHs of ELF executables and libraries in /nix/store/2hb889kzpcyk6f3d6bf3w6dy12whbdvg-pipewire-0.1.9-doc
strip is /nix/store/h0nc84ybvb8g724fwysvcghh1675wjli-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/2hb889kzpcyk6f3d6bf3w6dy12whbdvg-pipewire-0.1.9-doc
checking for references to /build in /nix/store/2hb889kzpcyk6f3d6bf3w6dy12whbdvg-pipewire-0.1.9-doc...
cannot build derivation '/nix/store/4wc99hxdlbh9ylngad9ass3wks2c99nc-mutter-3.28.2.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/2d6yjkl45w8cn0b83zhjjapy58ydxh0m-gnome-shell-3.28.2.drv': 14 dependencies couldn't be built
cannot build derivation '/nix/store/1y93zl13zqz9jipb8b35i6ypaqy05nwx-gpaste-3.28.2.drv': 4 dependencies couldn't be built
cannot build derivation '/nix/store/pw75dadrx3licq6n5p813fng7z2y32v3-gnome-session-3.28.1.drv': 3 dependencies couldn't be built
error: build of '/nix/store/1y93zl13zqz9jipb8b35i6ypaqy05nwx-gpaste-3.28.2.drv', '/nix/store/7myq2453dx5zmyjgf7nkp2zrf3n2m4sy-gdm-3.28.2.drv', '/nix/store/pw75dadrx3licq6n5p813fng7z2y32v3-gnome-session-3.28.1.drv' failed

Pass gnome-session to extraSessionFilePackages, remove unnecessary environment variables, move the rest out of old session option, and then drop the option.

TryExec needs absolute path too, otherwise the desktop file will be ignored unless gnome-session is in PATH, in which case, we would not need to patch Exec.

This makes it easier to support a wider variety of .desktop session files. In particular this makes it possible to use both the «legacy» sessions and upstream session files. We separate `xsession` into two parts, `xsessionWrapper` and `xsession`. `xsessionWrapper` sets up the correct environment and then lauches the session's Exec command (from the .desktop file), falling back to launching the default window/desktopManager through the `xsession` script (required by at least some nixos tests). `xsession` then _only_ handles launching desktop-managers/window-managers defined through `services.xserver.desktopManager.session`.

The default session might be found in `extraSessionFilePackages`, but it's not viable to detect at evaluation time, so emit a warning. In LightDM instead of checking `defaultSessionName` against `displayManager.session.names` we rely on the assertions in `desktopManager` and `windowMananger` and just check that there's at least one default set. The second assertion could never actually be triggered.

Sessions from `extraSessionFilePackages` isn't picked automatically as the default session.

Implement through `services.xserver.displayManager.sessionCommands`.

benley · 2018-08-01T18:33:35Z

nixos/modules/services/x11/desktop-managers/gnome3.nix

Really minor punctuation nit:

"Note that this should be a last resort; patching the package is preferred (see GPaste)."
"Note that this should be a last resort, and patching the package is preferred (see GPaste)."

(either of the above is fine)

jtojnar · 2018-08-01T19:25:36Z

Thanks @hedning, now it looks like it is ready to go; all tasks completed and tests passing.

There is a space for more clean-ups, for example, removing pulseaudio from the session wrapper (it is supposed to be socket-activated on modern systems), but we can leave it for future PRs.

Asking maintainers of other DEs for their input: @ttuegel (KDE), @romildo (lxqt), @yegortimoshenko (xfce).

hedning · 2018-10-07T16:48:47Z

@worldofpeace @jtojnar We could check that the default session exists when actually building the desktops derivation perhaps?

nixpkgs/nixos/modules/services/x11/display-managers/default.nix

Line 175 in d9d9221

mkDesktops = names: pkgs.runCommand "desktops"

nixos-discourse · 2020-06-04T18:59:41Z

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/gnome-control-center-wont-start-gpaste-settings-schema-not-installed/7479/4

GrahamcOfBorg added 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Jul 23, 2018

jtojnar mentioned this pull request Jul 23, 2018

Investigate using upstream desktop session files #39871

Closed

GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Jul 23, 2018

Mic92 reviewed Jul 23, 2018

View reviewed changes

worldofpeace reviewed Jul 23, 2018

View reviewed changes

jtojnar and others added 7 commits August 1, 2018 19:14

nixos/gnome3: use upstream session file

e6056c7

Pass gnome-session to extraSessionFilePackages, remove unnecessary environment variables, move the rest out of old session option, and then drop the option.

gnome3.gnome-session: use absolute paths

adbe4e1

TryExec needs absolute path too, otherwise the desktop file will be ignored unless gnome-session is in PATH, in which case, we would not need to patch Exec.

nixos/tests/gnome3: Explicitly set default desktopManager

e8e0edd

Sessions from `extraSessionFilePackages` isn't picked automatically as the default session.

nixos/gnome3: Add back sessionPath

ee34f25

Implement through `services.xserver.displayManager.sessionCommands`.

nixos/gnome3: Add back debug

9cd6342

jtojnar force-pushed the upstream-sessions branch from 0e364e9 to ea3568d Compare August 1, 2018 17:15

benley reviewed Aug 1, 2018

View reviewed changes

nixos/gnome3: warn against sessionPath

62e665e

jtojnar force-pushed the upstream-sessions branch from ea3568d to 62e665e Compare August 1, 2018 18:36

jtojnar added 9.needs: community feedback This needs feedback from more community members. and removed 2.status: work-in-progress labels Aug 1, 2018

jtojnar added this to the 18.09 milestone Aug 1, 2018

jtojnar mentioned this pull request Aug 3, 2018

nixos/xserver: Implement configuration of NVIDIA Optimus via PRIME #42846

Merged

9 tasks

jtojnar merged commit f735d6a into NixOS:master Aug 3, 2018

jtojnar deleted the upstream-sessions branch August 3, 2018 12:23

jtojnar mentioned this pull request Aug 5, 2018

GNOME keeps suspending on unstable #42053

Closed

eqyiel mentioned this pull request Aug 6, 2018

GDM doesn't unlock the GNOME keyring #21859

Closed

jtojnar mentioned this pull request Aug 6, 2018

GNOME 3 does not start with SDDM #24298

Closed

jtojnar mentioned this pull request Aug 15, 2018

freedesktop modules: init #45058

Merged

9 tasks

hedning mentioned this pull request Sep 18, 2018

gnome3 not found when upgrading from 18.03 to 18.09 #46818

Closed

jtojnar mentioned this pull request Sep 28, 2018

Add GNOME Flashback support #47451

Closed

worldofpeace mentioned this pull request Oct 17, 2018

pantheon: init at 5.0 #48637

Merged

6 tasks

jtojnar mentioned this pull request Jan 17, 2019

Install gsettings schemas #54083

Closed

jtojnar mentioned this pull request Dec 14, 2019

Set of redwax modules (modular/federated PKI Tooling) #75620

Closed

9 tasks

jtojnar mentioned this pull request Sep 1, 2020

GNOME Shell extensions: gsettings does not find the schema. #92265

Open

Uh oh!

Conversation

jtojnar commented Jul 23, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Motivation for this change

Things done

Uh oh!

GrahamcOfBorg commented Jul 23, 2018

Uh oh!

GrahamcOfBorg commented Jul 23, 2018

Uh oh!

GrahamcOfBorg commented Jul 23, 2018

Uh oh!

hedning commented Jul 23, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Login

GPaste

Uh oh!

jtojnar commented Jul 23, 2018

Uh oh!

hedning commented Jul 23, 2018

Uh oh!

jtojnar commented Jul 23, 2018

Uh oh!

Mic92 Jul 23, 2018

Choose a reason for hiding this comment

Uh oh!

jtojnar Jul 23, 2018

Choose a reason for hiding this comment

Uh oh!

hedning commented Jul 23, 2018

Uh oh!

jtojnar commented Jul 23, 2018

Uh oh!

worldofpeace commented Jul 23, 2018

Uh oh!

jtojnar commented Jul 23, 2018

Uh oh!

worldofpeace commented Jul 23, 2018

Uh oh!

jtojnar commented Jul 23, 2018

Uh oh!

worldofpeace commented Jul 23, 2018

Uh oh!

worldofpeace commented Jul 23, 2018

Uh oh!

worldofpeace commented Jul 23, 2018

Uh oh!

jtojnar commented Jul 23, 2018

Uh oh!

worldofpeace commented Jul 23, 2018

Uh oh!

jtojnar commented Jul 23, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

worldofpeace left a comment

Choose a reason for hiding this comment

Uh oh!

GrahamcOfBorg commented Jul 23, 2018

Uh oh!

GrahamcOfBorg commented Jul 23, 2018

Uh oh!

GrahamcOfBorg commented Jul 23, 2018

Uh oh!

benley Aug 1, 2018

Choose a reason for hiding this comment

Uh oh!

jtojnar commented Aug 1, 2018

Uh oh!

hedning commented Oct 7, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nixos-discourse commented Jun 4, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

jtojnar commented Jul 23, 2018 •

edited

Loading

hedning commented Jul 23, 2018 •

edited

Loading

jtojnar commented Jul 23, 2018 •

edited

Loading

hedning commented Oct 7, 2018 •

edited

Loading