Set of redwax modules (modular/federated PKI Tooling)#75620
Set of redwax modules (modular/federated PKI Tooling)#75620dirkx wants to merge 532 commits intoNixOS:masterfrom dirkx:master
Conversation
aanderse
left a comment
There was a problem hiding this comment.
Welcome and thanks for deciding to contribute to nixpkgs! We're glad you came. I haven't had a chance to test your code yet, but I have left some suggestions I hope you find helpful. Since this is your first PR I thought that my suggestions might be a little overwhelming so I decided to write some code you can reference when going through my suggestions if you get stuck at any point:
Do you have a working configuration.nix snippet you used to test this code with that you could share?
Don't hesitate to ask any questions at all.
|
Ok - so just changes this to $out/modules -- but happy to change it back !
As to `to such standard location exists' -- it may be easiest go back to our first cut - and follow what 'apxs -q apxs -q libexecdir' tells you -- as that tends to follow the idiosyncrasies of the various (linux) platforms. And thus be closes to what the user expect.
|
|
Jan - not sure if you noticed it - but there is a slight hidden tweak behind that make which is not default Apache-- the https://source.redwax.eu/projects/RS/repos/mod_ca/browse/Makefile.am has been tweaked to both allow the standard linux tweaking; the normal apache synced approach (*bsd, darwin, macports, etc) and a prefix so that you can have the same path within the NIX store that is unique from apache - but they are still the same structure, etc.
|
|
All review issues should be address I hope. |
|
Thanks. Works like a treat.
|
|
All issues from review addresed. |
nixos: fix ip46tables invocation in nat
This hasn't worked since 2016 (#13983) and is being removed very soon, per "Q4 2019" in https://developer.chrome.com/native-client/migration (It's staying around for "Chrome Apps", but those only run on ChromeOS now.) earth.google.com users can use https://earth.google.com/web/?beta=1 to get the wasm version instead of the PNaCl version.
Co-Authored-By: Jan Tojnar <jtojnar@gmail.com>
doc/gnome: update wrapper args example, remove proliferated uses
|
Ok will do. And will check if one of my test configs is sufficiently clean/unencumbered to already share.
Will take a bit of time - as a rebase/move of the commits onto their own branch gives me several conflicts ' pkgs/development/interpreters/octave' and ' pkgs/servers/documize-community/default.nix - so this may require some surgery on my end with the history first.
Dw.
|
Close #71432. Co-authored-by: Norbert Melzer <NobbZ@users.noreply.github.com>
Also refactored expression to follow ordering of most other python packages
gubbi-font: init at 1.3
|
i think the wrong branch was pushed |
|
@dirkx can you please take a look at your branch when you get a chance? |
|
Closing this pull request - will move & squash the commits onto a new branch - and resubmit a pull request (See #76417). |
Set of apache modules that make up most of a PKI framework; along with things like SCEP (automated rollout to things like cisco routers, iPhones, etc), timestamping and so on.
Note that this is our first attempt at a NixOS module set - any and all comments welcome; e.g. should we do it 1) like this - fairly independent; 2) create a library with just the sha/name/desc per module file or 3) create the common elements in the mother module (mod_ca) and minimise the leaf modules by referring somehow to the mod_ca definitions ?
Motivation for this change
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @