Skip to content

Set of redwax modules (modular/federated PKI Tooling)#75620

Closed
dirkx wants to merge 532 commits intoNixOS:masterfrom
dirkx:master
Closed

Set of redwax modules (modular/federated PKI Tooling)#75620
dirkx wants to merge 532 commits intoNixOS:masterfrom
dirkx:master

Conversation

@dirkx
Copy link
Contributor

@dirkx dirkx commented Dec 13, 2019

Set of apache modules that make up most of a PKI framework; along with things like SCEP (automated rollout to things like cisco routers, iPhones, etc), timestamping and so on.

Note that this is our first attempt at a NixOS module set - any and all comments welcome; e.g. should we do it 1) like this - fairly independent; 2) create a library with just the sha/name/desc per module file or 3) create the common elements in the mother module (mod_ca) and minimise the leaf modules by referring somehow to the mod_ca definitions ?

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • [X ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. labels Dec 13, 2019
@dirkx dirkx changed the title Set of redwax modules (modular/federated PKI Tooling) WIP: Set of redwax modules (modular/federated PKI Tooling) Dec 13, 2019
@dirkx dirkx changed the title WIP: Set of redwax modules (modular/federated PKI Tooling) Set of redwax modules (modular/federated PKI Tooling) Dec 13, 2019
@aanderse aanderse self-requested a review December 14, 2019 02:01
Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome and thanks for deciding to contribute to nixpkgs! We're glad you came. I haven't had a chance to test your code yet, but I have left some suggestions I hope you find helpful. Since this is your first PR I thought that my suggestions might be a little overwhelming so I decided to write some code you can reference when going through my suggestions if you get stuck at any point:

https://github.com/NixOS/nixpkgs/compare/master...aanderse:httpd-redwax?expand=1

Do you have a working configuration.nix snippet you used to test this code with that you could share?

Don't hesitate to ask any questions at all.

@dirkx
Copy link
Contributor Author

dirkx commented Dec 14, 2019 via email

@dirkx
Copy link
Contributor Author

dirkx commented Dec 14, 2019 via email

@dirkx
Copy link
Contributor Author

dirkx commented Dec 14, 2019

All review issues should be address I hope.

@dirkx dirkx requested a review from aanderse December 14, 2019 18:57
@dirkx
Copy link
Contributor Author

dirkx commented Dec 14, 2019 via email

@dirkx dirkx requested a review from aanderse December 14, 2019 20:27
@dirkx
Copy link
Contributor Author

dirkx commented Dec 14, 2019

All issues from review addresed.

worldofpeace and others added 7 commits December 14, 2019 23:42
nixos: fix ip46tables invocation in nat
This hasn't worked since 2016 (#13983)
and is being removed very soon, per "Q4 2019" in
https://developer.chrome.com/native-client/migration

(It's staying around for "Chrome Apps", but those only run on ChromeOS now.)

earth.google.com users can use https://earth.google.com/web/?beta=1 to get
the wasm version instead of the PNaCl version.
Co-Authored-By: Jan Tojnar <jtojnar@gmail.com>
doc/gnome: update wrapper args example, remove proliferated uses
@dirkx
Copy link
Contributor Author

dirkx commented Dec 18, 2019 via email

Br1ght0ne and others added 6 commits December 18, 2019 09:03
Close #71432.

Co-authored-by: Norbert Melzer <NobbZ@users.noreply.github.com>
Also refactored expression to follow ordering of most other python packages
gubbi-font: init at 1.3
@jonringer
Copy link
Contributor

i think the wrong branch was pushed

@aanderse
Copy link
Member

@dirkx can you please take a look at your branch when you get a chance?

dirkx added a commit to dirkx/nixpkgs that referenced this pull request Dec 24, 2019
@dirkx dirkx mentioned this pull request Dec 24, 2019
10 tasks
@dirkx
Copy link
Contributor Author

dirkx commented Dec 24, 2019

Closing this pull request - will move & squash the commits onto a new branch - and resubmit a pull request (See #76417).

@dirkx dirkx closed this Dec 24, 2019
@Janik-Haag Janik-Haag added the 12.first-time contribution This PR is the author's first one; please be gentle! label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.first-time contribution This PR is the author's first one; please be gentle!

Projects

None yet

Development

Successfully merging this pull request may close these issues.