pantheon: init at 5.0 by worldofpeace · Pull Request #48637 · NixOS/nixpkgs

worldofpeace · 2018-10-17T18:44:57Z

Description of Change

Add the elementary/pantheon desktop to NixOS!

Notes

~~I didn't add the things to, idk, release-combined.nix because I'm not familiar with that.~~
~~I should probably move gsignond: init at 1.0.7 #43133 here because I did it separately for some reason~~

Things Done

Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
Tested via one or more NixOS tests
- elementary
Tested on Physical Machines
Fits CONTRIBUTING.md.

How To Test

There's https://elementary.cachix.org which can be used as a binary cache.
The packages are built directly off of this branch.

configuration.nix

services.xserver.enable = true;
services.xserver.desktopManager.elementary.enable = true;
services.xserver.desktopManager.default = "pantheon";
services.xserver.displayManager.lightdm.enable = true;
services.xserver.displayManager.lightdm.greeters.elementary.enable = true;

We have to set services.xserver.desktopManager.default = "pantheon"; because sessions from extraSessionFilePackages aren't picked automatically as the default session.

Possible solutions were discussed around here #43992 (comment).

In a VM

Ignore these errors as I can't reproduce them while on a physical machine.
Bluetooth error is pretty expected also.

** (io.elementary.switchboard:1744): CRITICAL **: 21:39:27.969: Manager.vala:64: Error calling StartServiceByName for org.bluez: GDBus.Error:org.freedesktop.DBus.Error.TimedOut: Failed to activate service 'org.bluez': timed out (service_start_timeout=25000ms)

Could't connect to accessibility bus: Failed to connect to socket /tmp/dbus-nF2hddXdYT: Connection refused

On a Physical Machine

Make sure that the home directory doesn't have any .gtkrc* or .dmrc lying around.

If you have a last saved session or something it won't go into the elementary session.
Running this fixed that for me:

dbus-send --system --type=method_call --print-reply --dest=org.freedesktop.Accounts /org/freedesktop/Accounts/User1000 org.freedesktop.Accounts.User.SetXSession string:pantheon

Where User1000 is User and the uid of the user.

Current Issues

~~1. There's no system sounds using elementary-sound-theme~~

~~Needs a sounds module mentioned in #47173~~

elementary-greeter doesn't have a panel with indicators from wingpanel

No idea on this one.

glib setup hook doesn't move networkmanagerapplet schemas

See: #45043

This causes connection from wingpanel-indicator-network to be impossible.

I'm currently doing this horrible "workaround" .

~~4. elementary-greeter can appear really weird on displays less than 1920x1080 and maybe above~~

~~Clearly evident in a screenshot:~~

~~Also note on certain displays that meet that criteria, the font looks awful.~~

switchboard-plug-onlineaccounts isn't functional

Here's the output of authentication on NixOS and elementary.

Also it requests to enter a password for Default Keyring.
It probably shouldn't.

~~6. switchboard-plug-pantheon-shell can't enumerate system wallpapers directory~~

~~Upstream Issue: elementary/settings-desktop#151~~

after locking desktop (or after first login) cursor theme is switched to adwaita
switchboard-plug-print always requests some sort of authentication
enabling both elementary and gnome3 isn't possible

Build fails with:

error: The unique option `networking.networkmanager.basePackages.modemmanager' is defined multiple times, in `nixos/modules/services/x11/desktop-managers/elementary.nix' and `nixos/modules/services/x11/desktop-managers/gnome3.nix'.

Notable Compromises

gnome3.mutter328

We have to keep mutter 3.28 around for elementary's gala and greeter until they get around to adapting to all the API breaking changes in libmutter-3.

patched gnome-settings-daemon

In order for light-locker to kick in, we have to control certain DPMS settings ourselves that are otherwise managed by G-S-D yet ignored by light-locker. This requires a helper package and a patched G-S-D.

Don't really have much of choice here based off of this comment here elementary/greeter#92 (comment)

Unpackaged Software

They remain as such because they're non-functional, problematic, or untested on distros other than Ubuntu.

List of programs and upstream issues

switchboard-plug-locale
- plug cannot determine region and format correctly on fedora elementary/settings-locale#76
switchboard-plug-useraccounts
- plug can't enable newly created user account on fedora elementary/settings-useraccounts#92
- plug fails to detect current user on fedora elementary/settings-useraccounts#91
switchboard-plug-parental-controls
mail
- port to webkit2gtk-4.0 [$20] elementary/mail#8

Though switchboard-plug-useraccounts isn't really useful on NixOS for obvious reasons 😄

Thank you @jtojnar so much for all the guidance! 🎆 🎆 🎆

nixos/modules/services/x11/desktop-managers/elementary.nix

pkgs/desktops/elementary/apps/elementary-calendar/default.nix

pkgs/desktops/elementary/apps/elementary-photos/default.nix

pkgs/desktops/elementary/contractor/default.nix

pkgs/desktops/elementary/elementary-default-settings/wingpanel-overrides.patch

pkgs/desktops/elementary/elementary-greeter/01-sbin-bin.patch

pkgs/desktops/elementary/elementary-greeter/default.nix

jtojnar · 2018-10-18T00:20:10Z

pkgs/desktops/elementary/elementary-greeter/default.nix

Not sure I understand. Could you be more specific?

I think I meant they could use meson to get an absolute path

jtojnar · 2018-10-18T00:24:51Z

More to come later.

pkgs/desktops/elementary/wingpanel/default.nix

pkgs/desktops/elementary/wingpanel-indicators/notifications/default.nix

pkgs/desktops/elementary/wingpanel-indicators/keyboard/default.nix

pkgs/desktops/elementary/wingpanel-indicators/applications-menu/bc.patch

pkgs/desktops/elementary/themeing/elementary-sound-theme/default.nix

pkgs/desktops/elementary/pantheon-agent-geoclue2/default.nix

pkgs/desktops/elementary/gala/default.nix

pkgs/desktops/elementary/extra-elementary-contracts/default.nix

pkgs/desktops/elementary/elementary-settings-daemon/default.nix

GrahamcOfBorg · 2018-10-19T02:22:07Z

Success on aarch64-linux (full log)

Attempted: faba-icon-theme

Partial log (click to expand)

Installing subdir /build/source/Faba to /nix/store/3y30hs0sdln3x9pk7bibk6rg3f6bd74h-faba-icon-theme-4.3/share/icons/Faba
Running custom install script '/build/source/meson/post_install.py'
glibPreFixupPhase
hicolorPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/3y30hs0sdln3x9pk7bibk6rg3f6bd74h-faba-icon-theme-4.3
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/3y30hs0sdln3x9pk7bibk6rg3f6bd74h-faba-icon-theme-4.3
checking for references to /build in /nix/store/3y30hs0sdln3x9pk7bibk6rg3f6bd74h-faba-icon-theme-4.3...
/nix/store/3y30hs0sdln3x9pk7bibk6rg3f6bd74h-faba-icon-theme-4.3

GrahamcOfBorg · 2018-10-19T02:22:18Z

Success on x86_64-linux (full log)

Attempted: faba-icon-theme

Partial log (click to expand)

Installing subdir /build/source/Faba to /nix/store/h8w7fpbhvcs8wvpc32rqzcnyikj561lz-faba-icon-theme-4.3/share/icons/Faba
Running custom install script '/build/source/meson/post_install.py'
glibPreFixupPhase
hicolorPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/h8w7fpbhvcs8wvpc32rqzcnyikj561lz-faba-icon-theme-4.3
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/h8w7fpbhvcs8wvpc32rqzcnyikj561lz-faba-icon-theme-4.3
checking for references to /build in /nix/store/h8w7fpbhvcs8wvpc32rqzcnyikj561lz-faba-icon-theme-4.3...
/nix/store/h8w7fpbhvcs8wvpc32rqzcnyikj561lz-faba-icon-theme-4.3

worldofpeace · 2018-10-19T02:23:24Z

Heh, wonder which commit made the eval succeed.

worldofpeace · 2018-10-19T05:20:52Z

If i try to enable both gnome3 and elementary this happens

error: The unique option `networking.networkmanager.basePackages.modemmanager' is defined multiple times, in `nixos/modules/services/x11/desktop-managers/elementary.nix' and `nixos/modules/services/x11/desktop-managers/gnome3.nix'.

GrahamcOfBorg · 2018-10-19T05:39:40Z

Success on aarch64-linux (full log)

Attempted: faba-icon-theme

Partial log (click to expand)

Installing subdir /build/source/Faba to /nix/store/3y30hs0sdln3x9pk7bibk6rg3f6bd74h-faba-icon-theme-4.3/share/icons/Faba
Running custom install script '/build/source/meson/post_install.py'
glibPreFixupPhase
hicolorPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/3y30hs0sdln3x9pk7bibk6rg3f6bd74h-faba-icon-theme-4.3
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/3y30hs0sdln3x9pk7bibk6rg3f6bd74h-faba-icon-theme-4.3
checking for references to /build in /nix/store/3y30hs0sdln3x9pk7bibk6rg3f6bd74h-faba-icon-theme-4.3...
/nix/store/3y30hs0sdln3x9pk7bibk6rg3f6bd74h-faba-icon-theme-4.3

GrahamcOfBorg · 2018-10-19T05:40:19Z

Success on x86_64-linux (full log)

Attempted: faba-icon-theme

Partial log (click to expand)

Installing subdir /build/source/Faba to /nix/store/h8w7fpbhvcs8wvpc32rqzcnyikj561lz-faba-icon-theme-4.3/share/icons/Faba
Running custom install script '/build/source/meson/post_install.py'
glibPreFixupPhase
hicolorPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/h8w7fpbhvcs8wvpc32rqzcnyikj561lz-faba-icon-theme-4.3
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/h8w7fpbhvcs8wvpc32rqzcnyikj561lz-faba-icon-theme-4.3
checking for references to /build in /nix/store/h8w7fpbhvcs8wvpc32rqzcnyikj561lz-faba-icon-theme-4.3...
/nix/store/h8w7fpbhvcs8wvpc32rqzcnyikj561lz-faba-icon-theme-4.3

GrahamcOfBorg · 2018-10-19T05:42:38Z

Success on x86_64-linux (full log)

Attempted: faba-icon-theme

Partial log (click to expand)

/nix/store/h8w7fpbhvcs8wvpc32rqzcnyikj561lz-faba-icon-theme-4.3

GrahamcOfBorg · 2018-10-19T05:42:48Z

Success on aarch64-linux (full log)

Attempted: faba-icon-theme

Partial log (click to expand)

/nix/store/3y30hs0sdln3x9pk7bibk6rg3f6bd74h-faba-icon-theme-4.3

GrahamcOfBorg · 2018-10-19T06:38:22Z

Success on x86_64-linux (full log)

Attempted: faba-icon-theme

Partial log (click to expand)

/nix/store/h8w7fpbhvcs8wvpc32rqzcnyikj561lz-faba-icon-theme-4.3

GrahamcOfBorg · 2018-10-19T06:38:24Z

Success on aarch64-linux (full log)

Attempted: faba-icon-theme

Partial log (click to expand)

/nix/store/3y30hs0sdln3x9pk7bibk6rg3f6bd74h-faba-icon-theme-4.3

GrahamcOfBorg · 2018-10-19T09:56:59Z

Success on aarch64-linux (full log)

Attempted: faba-icon-theme

Partial log (click to expand)

/nix/store/3y30hs0sdln3x9pk7bibk6rg3f6bd74h-faba-icon-theme-4.3

GrahamcOfBorg · 2018-10-19T09:57:39Z

Success on x86_64-linux (full log)

Attempted: faba-icon-theme

Partial log (click to expand)

/nix/store/h8w7fpbhvcs8wvpc32rqzcnyikj561lz-faba-icon-theme-4.3

GrahamcOfBorg · 2018-10-19T13:19:59Z

Success on aarch64-linux (full log)

Attempted: faba-icon-theme

Partial log (click to expand)

/nix/store/3y30hs0sdln3x9pk7bibk6rg3f6bd74h-faba-icon-theme-4.3

GrahamcOfBorg · 2018-10-19T13:20:35Z

Success on x86_64-linux (full log)

Attempted: faba-icon-theme

Partial log (click to expand)

/nix/store/h8w7fpbhvcs8wvpc32rqzcnyikj561lz-faba-icon-theme-4.3

GrahamcOfBorg · 2018-10-26T20:19:28Z

Success on aarch64-linux (full log)

Attempted: faba-icon-theme

Partial log (click to expand)

Installing subdir /build/source/Faba to /nix/store/2nh2rza1p1v749niwc5r381wshkpx2am-faba-icon-theme-4.3/share/icons/Faba
Running custom install script '/build/source/meson/post_install.py'
glibPreFixupPhase
hicolorPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/2nh2rza1p1v749niwc5r381wshkpx2am-faba-icon-theme-4.3
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/2nh2rza1p1v749niwc5r381wshkpx2am-faba-icon-theme-4.3
checking for references to /build in /nix/store/2nh2rza1p1v749niwc5r381wshkpx2am-faba-icon-theme-4.3...
/nix/store/2nh2rza1p1v749niwc5r381wshkpx2am-faba-icon-theme-4.3

worldofpeace · 2019-01-18T22:05:19Z

@davidak This should build now and I think I've pushed all of it to cachix.

davidak · 2019-01-19T06:18:39Z

I build it myself to check for problems there.

It seems that many packages don't build on staging. Now i get "No space left on device", but i have 300 GB free. Isn't that enough to build Chromium? I give up for today.

davidak · 2019-01-19T15:54:15Z

Now i have disabled enough packages to build it.

I can confirm that issue 4 is fixed and it generally works!

I noticed that the display brightness setting has no effect. But that's a non critical issue i will report in a new issue when this is merged.

worldofpeace · 2019-01-19T16:17:06Z

Now i have disabled enough packages to build it.
I can confirm that issue 4 is fixed and it generally works!

Great, we shouldn't be too far of then from getting this in.
If you can, ping me in #nixos if something jarring occurs.

I noticed that the display brightness setting has no effect.

I'm thinking the major pain point we have here is power management.
You may also run into #14168 as we're also affected by it.

davidak · 2019-01-19T18:43:41Z

Log out, Suspend and Shutdown have no function.

Can you reproduce that?

worldofpeace · 2019-01-19T19:25:22Z

Log out, Suspend and Shutdown have no function.

Can you reproduce that?

Can't in QEMU. It's possible that there's a stateful variable playing a hand in this.

Do you actually ever see the dialog?

Also try getting the output when you try to select it.
This can be done by killing the io.elementary.cerbere process and wingpanel
then running wingpanel like

G_MESSAGES_DEBUG=all wingpanel

We have to kill cerbere because it will restart wingpanel if killed.

davidak · 2019-01-19T19:48:27Z

Do you actually ever see the dialog?

yes. i have seen the shutdown dialog, but when i clicked on shutdown or restart, nothing happened.

i shut the system down from the command line and started it again and now i can't reproduce the problem.

so not a critical problem preventing the merge. i will open an issue if i have this problem ever again.

nixos/modules/services/x11/desktop-managers/elementary.nix

worldofpeace · 2019-01-20T05:42:43Z

Should I add the test to https://github.com/NixOS/nixpkgs/blob/master/nixos/release-combined.nix in a similar fashion to gnome3 (excluding aarch)?

jtojnar · 2019-01-20T05:46:48Z

Probably a good idea.

pkgs/desktops/gnome-3/core/evolution-data-server/hardcode-gsettings.patch

worldofpeace · 2019-01-20T08:29:52Z

Ok, I think all that's left is

https://github.com/NixOS/nixpkgs/pull/48637/files#r248507070
Accompanied by changing the attribute to pantheon, etc, once i hear back from cassidy
Write a Release Note

After this is merged I will migrate all the issues out of here, add a Pantheon label and project.

worldofpeace · 2019-01-22T22:02:56Z

@jtojnar Any idea what

gsd-xsettings Failed to get current display configuration state: GDBus.Error:org.freedesktop.DBus.Error.NameHasNoOwner: Name "org.gnome.Mutter.DisplayConfig" does not exist

Means?

worldofpeace · 2019-01-24T03:27:07Z

So I made this a bit better getting rid of some more session path, as I found I had some of it in a stash already.

Though the commit got squashed so here are the changes.

worldofpeace · 2019-01-24T20:55:40Z

Hope that was fine 😄

Thank you so much to @jtojnar and @davidak 🎇

dtzWill · 2019-01-28T04:46:22Z

Yay! I apologize if I'm using a slightly dated version, but in case it's useful...

I ran into an assert failure due to bad pname usage (this may have been reverted on master but I like it so kept it), fix was relatively straightforward. Please apply if this looks good, or bug me and I'll make a PR or something :).

dtzWill@663293e

worldofpeace · 2019-01-28T09:05:03Z

Yay! I apologize if I'm using a slightly dated version, but in case it's useful...

I ran into an assert failure due to bad pname usage (this may have been reverted on master but I like it so kept it), fix was relatively straightforward. Please apply if this looks good, or bug me and I'll make a PR or something :).

dtzWill@663293e

Yeah I actually wanted to switch to repoName and jtojnar also suggested appName or projectName.
I think repoName or projectName would make the most sense for what's it's used for.

It would be really nice if you'd pr that for all pantheon 😄 ❇️

vcunat · 2019-02-01T08:48:28Z

See f55f45f (gst-ffmpeg removal).

matthewbauer requested a review from jtojnar October 17, 2018 18:47

GrahamcOfBorg added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Oct 17, 2018

jtojnar reviewed Oct 18, 2018

View reviewed changes

worldofpeace force-pushed the elementary-cleaned branch from d09a26b to 8a0f0fe Compare October 21, 2018 19:10

GrahamcOfBorg added the 2.status: merge conflict This PR has merge conflicts with the target branch label Oct 21, 2018

worldofpeace mentioned this pull request Oct 26, 2018

gsignond: init at 1.0.7 #43133

Merged

9 tasks

worldofpeace force-pushed the elementary-cleaned branch from 8a0f0fe to be71b3e Compare October 26, 2018 20:02

GrahamcOfBorg removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Oct 26, 2018

worldofpeace commented Jan 19, 2019

View reviewed changes

nixos/modules/services/x11/desktop-managers/elementary.nix Outdated Show resolved Hide resolved

davidak mentioned this pull request Jan 19, 2019

Trying to build with cmake 3.5.1 fails with "No libmarkdown package found" Philip-Scott/Notes-up#252

Closed

jtojnar reviewed Jan 20, 2019

View reviewed changes

pkgs/desktops/gnome-3/core/evolution-data-server/hardcode-gsettings.patch Outdated Show resolved Hide resolved

worldofpeace added 6 commits January 24, 2019 12:48

elementary-gtk-theme: drop

b1cab6a

pantheon-terminal: drop

658d168

elementary-icon-theme: drop

588926d

gnome3.evolution-data-server: hardcode for DefaultSources gschema

6de386e

pantheon: init a 5.0

4fbecf4

release-notes/rl-1903: add pantheon

e2d999b

worldofpeace mentioned this pull request Jan 25, 2019

autotag Pantheon NixOS/ofborg#308

Merged

davidak mentioned this pull request Jan 25, 2019

Pantheon DE: volume get's turned up to max randomly #54594

Closed

worldofpeace mentioned this pull request Mar 11, 2019

Pantheon not working #57327

Closed

worldofpeace mentioned this pull request Aug 5, 2019

stylize Pantheon #66136

Merged

10 tasks

bobby285271 mentioned this pull request Aug 11, 2021

Pantheon 6.0.2 #130380

Merged

12 tasks

Uh oh!

Conversation

worldofpeace commented Oct 17, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description of Change

Notes

Things Done

How To Test

configuration.nix

In a VM

On a Physical Machine

Current Issues

Notable Compromises

gnome3.mutter328

patched gnome-settings-daemon

Unpackaged Software

List of programs and upstream issues

Thank you @jtojnar so much for all the guidance! 🎆 🎆 🎆

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jtojnar Oct 18, 2018

Choose a reason for hiding this comment

Uh oh!

worldofpeace Oct 18, 2018

Choose a reason for hiding this comment

Uh oh!

jtojnar commented Oct 18, 2018

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

GrahamcOfBorg commented Oct 19, 2018

Uh oh!

GrahamcOfBorg commented Oct 19, 2018

Uh oh!

worldofpeace commented Oct 19, 2018

Uh oh!

worldofpeace commented Oct 19, 2018

Uh oh!

GrahamcOfBorg commented Oct 19, 2018

Uh oh!

GrahamcOfBorg commented Oct 19, 2018

Uh oh!

GrahamcOfBorg commented Oct 19, 2018

Uh oh!

GrahamcOfBorg commented Oct 19, 2018

Uh oh!

GrahamcOfBorg commented Oct 19, 2018

Uh oh!

GrahamcOfBorg commented Oct 19, 2018

Uh oh!

GrahamcOfBorg commented Oct 19, 2018

Uh oh!

GrahamcOfBorg commented Oct 19, 2018

Uh oh!

GrahamcOfBorg commented Oct 19, 2018

Uh oh!

GrahamcOfBorg commented Oct 19, 2018

Uh oh!

GrahamcOfBorg commented Oct 26, 2018

Uh oh!

worldofpeace commented Jan 18, 2019

Uh oh!

davidak commented Jan 19, 2019

Uh oh!

worldofpeace commented Oct 17, 2018 •

edited

Loading