Skip to content

qq: fix update.sh #436230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lonerOrz wants to merge 1 commit into from
Closed

qq: fix update.sh #436230

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pkgs/by-name/qq/qq/package.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@ let
fee1-dead
prince213
ryan4yin
lonerOrz
];
};
in
Expand Down
6 changes: 3 additions & 3 deletions pkgs/by-name/qq/qq/update.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ darwin_url=$(jq -r .downloadUrl <<< "$darwin_payload")
darwin_hash=$(nix-prefetch-url $darwin_url)

# use friendlier hashes
darwin_hash=$(nix --extra-experimental-features nix-command hash convert --to sri --hash-algo sha256 "$darwin_hash")
darwin_hash="sha256-$(nix hash to-base64 "sha256:$darwin_hash")"
Copy link
Contributor

@philiptaron philiptaron Aug 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This reverts (kind of) #421823

This change looks wrong to me.

Copy link
Member

@Frontear Frontear Aug 23, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. Also out of curiosity why aren't we using nix-hash --type sha256 --to-sri <hash> instead of the nix3 CLI? I know it's not really a big difference but tacking on the experimental features feels excessive when a simpler command will do.


# linux

Expand All @@ -29,8 +29,8 @@ linux_aarch64_hash=$(nix-prefetch-url $linux_aarch64_url)
linux_x86_64_hash=$(nix-prefetch-url $linux_x86_64_url)

# use friendlier hashes
linux_aarch64_hash=$(nix --extra-experimental-features nix-command hash convert --to sri --hash-algo sha256 "$linux_aarch64_hash")
linux_x86_64_hash=$(nix --extra-experimental-features nix-command hash convert --to sri --hash-algo sha256 "$linux_x86_64_hash")
linux_aarch64_hash="sha256-$(nix hash to-base64 "sha256:$linux_aarch64_hash")"
linux_x86_64_hash="sha256-$(nix hash to-base64 "sha256:$linux_x86_64_hash")"

cat >sources.nix <<EOF
# Generated by ./update.sh - do not update manually!
Expand Down
Loading