[Backport release-25.05] lib/tests/test-with-nix: run misc.nix and fetchers.nix tests in the derivation#434761
Merged
emilazy merged 5 commits intorelease-25.05from Aug 19, 2025
Merged
Conversation
(cherry picked from commit 74799dd)
(cherry picked from commit 76a7b54)
This would have allowed us to catch to fromTOML regression in [1] without waiting for the dogfooding on master, since previously these tests [2] were not run for the Nix/Lix under test - only the host nix. [1]: NixOS/nix#13741 [2]: #433710 (cherry picked from commit 67ef265)
This doesn't do the right thing here, because it evaluates
the test with nix that is evaluating the `nixpkgs-lib-tests-nix-${nix.version}`
derivation, not the Nix/Lix under test. This was just really busted for a long
time.
(cherry picked from commit c269837)
This suffers from the same issue as misc.nix tests, because they were evaluated by the host nix, not the one that is being tested. (cherry picked from commit 609c879)
13 tasks
nixpkgs-ci
bot
added
10.rebuild-linux: 1-10
lf-
pushed a commit
to lix-project/lix
that referenced
this pull request
Sep 10, 2025
Several nixpkgs bumps up to NixOS/nixpkgs#434761 will be required to fix them. Disable the tests temporarily to avoid having to squash all the backports, which would lose history. Change-Id: I6a6a6964029a3442c4691e74a52923e3f59d6448
lf-
pushed a commit
to lix-project/lix
that referenced
this pull request
Sep 10, 2025
Without NixOS/nixpkgs#434761 evaluation of the `nixpkgsLibTests` will fail in CI with recent enough Lix, due to reliance on the TOML integer saturation bug. Reported-by: Sergei Zimmerman <sergei@zimmerman.foo> Change-Id: I6a6a6964838009d2c525f67035f84072fdfad988
lf-
pushed a commit
to lix-project/lix
that referenced
this pull request
Sep 10, 2025
Several nixpkgs bumps up to NixOS/nixpkgs#434761 will be required to fix them. Disable the tests temporarily to avoid having to squash all the backports, which would lose history. Change-Id: I6a6a6964029a3442c4691e74a52923e3f59d6448
lf-
pushed a commit
to lix-project/lix
that referenced
this pull request
Sep 10, 2025
Without NixOS/nixpkgs#434761 evaluation of the `nixpkgsLibTests` will fail in CI with recent enough Lix, due to reliance on the TOML integer saturation bug. Reported-by: Sergei Zimmerman <sergei@zimmerman.foo> Change-Id: I6a6a6964838009d2c525f67035f84072fdfad988
lf-
pushed a commit
to lix-project/lix
that referenced
this pull request
Sep 10, 2025
Without NixOS/nixpkgs#434761 evaluation of the `nixpkgsLibTests` will fail in CI with recent enough Lix, due to reliance on the TOML integer saturation bug. Reported-by: Sergei Zimmerman <sergei@zimmerman.foo> Change-Id: I6a6a6964838009d2c525f67035f84072fdfad988
lf-
pushed a commit
to lix-project/lix
that referenced
this pull request
Sep 10, 2025
Without NixOS/nixpkgs#434761 evaluation of the `nixpkgsLibTests` will fail in CI with recent enough Lix, due to reliance on the TOML integer saturation bug. Reported-by: Sergei Zimmerman <sergei@zimmerman.foo> Change-Id: I6a6a6964838009d2c525f67035f84072fdfad988
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bot-based backport to
release-25.05, triggered by a label in #433729.