lib/tests/test-with-nix: run misc.nix and fetchers.nix tests in the derivation#433729
Merged
emilazy merged 5 commits intoNixOS:masterfrom Aug 14, 2025
Merged
lib/tests/test-with-nix: run misc.nix and fetchers.nix tests in the derivation#433729emilazy merged 5 commits intoNixOS:masterfrom
emilazy merged 5 commits intoNixOS:masterfrom
Conversation
This would have allowed us to catch to fromTOML regression in [1] without waiting for the dogfooding on master, since previously these tests [2] were not run for the Nix/Lix under test - only the host nix. [1]: NixOS/nix#13741 [2]: NixOS#433710
nixpkgs-ci
bot
added
10.rebuild-linux: 1-10
xokdvium
changed the title
This doesn't do the right thing here, because it evaluates
the test with nix that is evaluating the `nixpkgs-lib-tests-nix-${nix.version}`
derivation, not the Nix/Lix under test. This was just really busted for a long
time.
This suffers from the same issue as misc.nix tests, because they were evaluated by the host nix, not the one that is being tested.
nixpkgs-ci
bot
added
the
12.approvals: 1
xokdvium
force-pushed
the
lib-tests-nix
branch
from
5e30a9f to
609c879
Compare
Contributor
Author
I suppose it makes sense, since there are no other in-tree users of this. Dropped the file. |
lf-
approved these changes
Aug 14, 2025
Member
lf-
left a comment
lf-
left a comment
There was a problem hiding this comment.
I believe this has no effect on lix's out of tree usage and looks overall good to me.
nixpkgs-ci
bot
added
12.approvals: 2
Member
|
Let’s try it out. cc @wolfgangwalther since this is CI‐related. |
Contributor
|
Successfully created backport PR for |
1 task
github-actions
bot
added
the
8.has: port to stable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This would have allowed us to catch to fromTOML regression in
1 without waiting for the dogfooding on master, since previously
these tests 2 were not run for the Nix/Lix under test - only the host
nix.
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.