Skip to content

make-tarball / lib-tests: reduce duplication#64563

Merged
FRidh merged 1 commit intoNixOS:masterfrom
FRidh:tarball
Jul 11, 2019
Merged

make-tarball / lib-tests: reduce duplication#64563
FRidh merged 1 commit intoNixOS:masterfrom
FRidh:tarball

Conversation

@FRidh
Copy link
Member

@FRidh FRidh commented Jul 10, 2019

The misc.nix and systems.nix tests were invoked at three different
places. Let's not that.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

The misc.nix and systems.nix tests were invoked at three different
places. Let's not that.
@FRidh FRidh requested review from edolstra and nbp as code owners July 10, 2019 10:42
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jul 10, 2019
@FRidh FRidh merged commit 8931db9 into NixOS:master Jul 11, 2019
@FRidh FRidh deleted the tarball branch July 11, 2019 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant