Conversation
|
first time contributing, made some mistakes and it was simpler to remake the PR |
57a37bc to
e51f9d1
Compare
|
for the test cases they're running their tests from a makefile so when I did I'm already doing the python check inputs. I was checking the other packages for an example but I'm not finding them. |
|
When they try to build packages with poetry then we can excempt the tests as that usually does not work but are all packages doing that? |
|
yea they're all doing that, which I'm not surprised because they're all related to the supabase platform. |
|
Could you please resolve the merge conflict, you probably need to rebase the branch on master and solve conflicts @Siegema I would like to move this PR forward if you're still interested in working on it, please feel free to do so, if not just let me know, I'll open a new one and attempt to have it land in Nixpkgs |
|
Thanks for the update on the PR, |
|
aww someone pushed postgrest |
AkechiShiro
left a comment
There was a problem hiding this comment.
LGTM, thanks for the work on this PR
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-already-reviewed/2617/2465 |
|
@SuperSandro2000 Could you maybe please review one more time this PR ? |
e44f315 to
ac14adb
Compare
|
Hello @Siegema, Not sure if you have seen this behavior but when I try to import the Adding |
3730a76 to
1bb0ea9
Compare
|
quickly fixed the missing comma 😅 |
|
|
Successfully created backport PR for |
|
|
||
| build-system = [ poetry-core ]; | ||
|
|
||
| pythonImportCheck = [ "storage3" ]; |
There was a problem hiding this comment.
typo.
| pythonImportCheck = [ "storage3" ]; | |
| pythonImportsCheck = [ "storage3" ]; |
There was a problem hiding this comment.
thanks I appreciate you catching that. I opened a new PR #430804
adding the supabase-py client with dependencies
realtime
storage3
supafunc
postgrest
supabase-auth
gotrue
gotrue and supabase-auth point to the same repo because their builds result in 2 pypi packages where the import names are different
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.