Skip to content

Python supabase#398562

Merged
SuperSandro2000 merged 6 commits intoNixOS:masterfrom
Siegema:python-supabase
Jul 31, 2025
Merged

Python supabase#398562
SuperSandro2000 merged 6 commits intoNixOS:masterfrom
Siegema:python-supabase

Conversation

@Siegema
Copy link
Contributor

@Siegema Siegema commented Apr 14, 2025

adding the supabase-py client with dependencies

realtime
storage3
supafunc
postgrest
supabase-auth
gotrue

gotrue and supabase-auth point to the same repo because their builds result in 2 pypi packages where the import names are different

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: python Python is a high-level, general-purpose programming language. 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` labels Apr 14, 2025
@Siegema
Copy link
Contributor Author

Siegema commented Apr 14, 2025

first time contributing, made some mistakes and it was simpler to remake the PR
#398467 (comment)

@nix-owners nix-owners bot requested a review from natsukium April 14, 2025 13:22
@github-actions github-actions bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Apr 14, 2025
@Siegema
Copy link
Contributor Author

Siegema commented Apr 15, 2025

for the test cases they're running their tests from a makefile so when I did make tests. Their tests require a proper poetry environment, it also tries to install poetry. How deep down the rabbit hole do we go? Do I write custom checkphases and do I start doing things so I can fit the tests in?

I'm already doing the python check inputs. I was checking the other packages for an example but I'm not finding them.

@Siegema Siegema mentioned this pull request Apr 15, 2025
13 tasks
@SuperSandro2000
Copy link
Member

When they try to build packages with poetry then we can excempt the tests as that usually does not work but are all packages doing that?

@Siegema
Copy link
Contributor Author

Siegema commented Apr 16, 2025

yea they're all doing that, which I'm not surprised because they're all related to the supabase platform.

@Siegema Siegema requested a review from SuperSandro2000 April 18, 2025 20:42
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label May 17, 2025
@AkechiShiro
Copy link
Contributor

AkechiShiro commented Jun 24, 2025

Could you please resolve the merge conflict, you probably need to rebase the branch on master and solve conflicts @Siegema

I would like to move this PR forward if you're still interested in working on it, please feel free to do so, if not just let me know, I'll open a new one and attempt to have it land in Nixpkgs

@nixpkgs-ci nixpkgs-ci bot added the 12.first-time contribution This PR is the author's first one; please be gentle! label Jun 24, 2025
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Jun 25, 2025
@Siegema Siegema requested a review from AkechiShiro June 27, 2025 21:11
@Moraxyc Moraxyc mentioned this pull request Jun 29, 2025
13 tasks
@nixpkgs-ci nixpkgs-ci bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Jun 30, 2025
@AkechiShiro
Copy link
Contributor

Thanks for the update on the PR,
I was planning to leave a review on the PR, but there is a merge conflict again, could you please resolve the conflict @Siegema ?

@Siegema Siegema force-pushed the python-supabase branch from 8c5b76f to 1458251 Compare July 2, 2025 01:28
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Jul 2, 2025
@Siegema
Copy link
Contributor Author

Siegema commented Jul 2, 2025

aww someone pushed postgrest

Copy link
Contributor

@AkechiShiro AkechiShiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the work on this PR

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jul 2, 2025
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/2465

@AkechiShiro
Copy link
Contributor

@SuperSandro2000 Could you maybe please review one more time this PR ?
Would you deem it good enough to be merged ?

@AkechiShiro AkechiShiro requested a review from D3vil0p3r July 17, 2025 06:06
@Siegema Siegema force-pushed the python-supabase branch 2 times, most recently from e44f315 to ac14adb Compare July 19, 2025 03:45
@AkechiShiro
Copy link
Contributor

Hello @Siegema,

Not sure if you have seen this behavior but when I try to import the supabase in a python REPL, I get this traceback :

Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/nix/store/j84rlpm2vsip5cckkypz2z8bz3g58j8h-python3.13-supabase-py-2.16.0/lib/python3.13/site-packages/supabase/__init__.py", line 1, in <module>
    from gotrue.errors import (
  File "/nix/store/7yqpam1l8pjf6l39g9h822dhhaslb9rn-python3.13-gotrue-2.12.0/lib/python3.13/site-packages/gotrue/__init__.py", line 3, in <module>
    from ._async.gotrue_admin_api import AsyncGoTrueAdminAPI  # type: ignore # noqa: F401
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/nix/store/7yqpam1l8pjf6l39g9h822dhhaslb9rn-python3.13-gotrue-2.12.0/lib/python3.13/site-packages/gotrue/_async/gotrue_admin_api.py", line 6, in <module>
    from ..helpers import model_validate, parse_link_response, parse_user_response
  File "/nix/store/7yqpam1l8pjf6l39g9h822dhhaslb9rn-python3.13-gotrue-2.12.0/lib/python3.13/site-packages/gotrue/helpers.py", line 15, in <module>
    from pydantic import BaseModel
  File "/nix/store/wa8b4x0vsvxz1dvgwnm9gdwhvba7ka70-python3.13-pydantic-2.11.7/lib/python3.13/site-packages/pydantic/__init__.py", line 5, in <module>
    from ._migration import getattr_migration
  File "/nix/store/wa8b4x0vsvxz1dvgwnm9gdwhvba7ka70-python3.13-pydantic-2.11.7/lib/python3.13/site-packages/pydantic/_migration.py", line 4, in <module>
    from .version import version_short
  File "/nix/store/wa8b4x0vsvxz1dvgwnm9gdwhvba7ka70-python3.13-pydantic-2.11.7/lib/python3.13/site-packages/pydantic/version.py", line 5, in <module>
    from pydantic_core import __version__ as __pydantic_core_version__
  File "/nix/store/85cxbradwqy5a4r1iv6pcivcqna903h8-python3.13-pydantic-core-2.33.2/lib/python3.13/site-packages/pydantic_core/__init__.py", line 6, in <module>
    from ._pydantic_core import (
ModuleNotFoundError: No module named 'pydantic_core._pydantic_core'

Adding python3Packages.pydantic to the env, this fixes the import issue, maybe there is a missing dependency for supabase ?

@AkechiShiro AkechiShiro removed the 12.approvals: 1 This PR was reviewed and approved by one person. label Jul 30, 2025
@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jul 30, 2025
@SuperSandro2000
Copy link
Member

quickly fixed the missing comma 😅

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Jul 31, 2025
@SuperSandroBot
Copy link

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 398562

Logs: https://github.com/SuperSandro2000/nixpkgs-review-gha/actions/runs/16651135287


x86_64-linux

✅ 20 packages built:
  • python312Packages.gotrue
  • python312Packages.gotrue.dist
  • python312Packages.realtime
  • python312Packages.realtime.dist
  • python312Packages.storage3
  • python312Packages.storage3.dist
  • python312Packages.supabase
  • python312Packages.supafunc (python312Packages.supabase-functions)
  • python312Packages.supafunc.dist (python312Packages.supabase-functions.dist)
  • python312Packages.supabase.dist
  • python313Packages.gotrue
  • python313Packages.gotrue.dist
  • python313Packages.realtime
  • python313Packages.realtime.dist
  • python313Packages.storage3
  • python313Packages.storage3.dist
  • python313Packages.supabase
  • python313Packages.supafunc (python313Packages.supabase-functions)
  • python313Packages.supafunc.dist (python313Packages.supabase-functions.dist)
  • python313Packages.supabase.dist

aarch64-linux

✅ 20 packages built:
  • python312Packages.gotrue
  • python312Packages.gotrue.dist
  • python312Packages.realtime
  • python312Packages.realtime.dist
  • python312Packages.storage3
  • python312Packages.storage3.dist
  • python312Packages.supabase
  • python312Packages.supafunc (python312Packages.supabase-functions)
  • python312Packages.supafunc.dist (python312Packages.supabase-functions.dist)
  • python312Packages.supabase.dist
  • python313Packages.gotrue
  • python313Packages.gotrue.dist
  • python313Packages.realtime
  • python313Packages.realtime.dist
  • python313Packages.storage3
  • python313Packages.storage3.dist
  • python313Packages.supabase
  • python313Packages.supafunc (python313Packages.supabase-functions)
  • python313Packages.supafunc.dist (python313Packages.supabase-functions.dist)
  • python313Packages.supabase.dist

x86_64-darwin (sandbox = true)

✅ 20 packages built:
  • python312Packages.gotrue
  • python312Packages.gotrue.dist
  • python312Packages.realtime
  • python312Packages.realtime.dist
  • python312Packages.storage3
  • python312Packages.storage3.dist
  • python312Packages.supabase
  • python312Packages.supafunc (python312Packages.supabase-functions)
  • python312Packages.supafunc.dist (python312Packages.supabase-functions.dist)
  • python312Packages.supabase.dist
  • python313Packages.gotrue
  • python313Packages.gotrue.dist
  • python313Packages.realtime
  • python313Packages.realtime.dist
  • python313Packages.storage3
  • python313Packages.storage3.dist
  • python313Packages.supabase
  • python313Packages.supafunc (python313Packages.supabase-functions)
  • python313Packages.supafunc.dist (python313Packages.supabase-functions.dist)
  • python313Packages.supabase.dist

aarch64-darwin (sandbox = true)

✅ 20 packages built:
  • python312Packages.gotrue
  • python312Packages.gotrue.dist
  • python312Packages.realtime
  • python312Packages.realtime.dist
  • python312Packages.storage3
  • python312Packages.storage3.dist
  • python312Packages.supabase
  • python312Packages.supafunc (python312Packages.supabase-functions)
  • python312Packages.supafunc.dist (python312Packages.supabase-functions.dist)
  • python312Packages.supabase.dist
  • python313Packages.gotrue
  • python313Packages.gotrue.dist
  • python313Packages.realtime
  • python313Packages.realtime.dist
  • python313Packages.storage3
  • python313Packages.storage3.dist
  • python313Packages.supabase
  • python313Packages.supafunc (python313Packages.supabase-functions)
  • python313Packages.supafunc.dist (python313Packages.supabase-functions.dist)
  • python313Packages.supabase.dist

@SuperSandro2000 SuperSandro2000 merged commit e5139f5 into NixOS:master Jul 31, 2025
25 of 28 checks passed
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Jul 31, 2025

Successfully created backport PR for release-25.05:

@github-actions github-actions bot added the 8.has: port to stable This PR already has a backport to the stable release. label Jul 31, 2025

build-system = [ poetry-core ];

pythonImportCheck = [ "storage3" ];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo.

Suggested change
pythonImportCheck = [ "storage3" ];
pythonImportsCheck = [ "storage3" ];

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks I appreciate you catching that. I opened a new PR #430804

@Siegema Siegema deleted the python-supabase branch August 3, 2025 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 8.has: port to stable This PR already has a backport to the stable release. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons. 12.first-time contribution This PR is the author's first one; please be gentle!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants