Skip to content

Comments

electron_{33,34}-bin: remove#427430

Merged
yayayayaka merged 2 commits intoNixOS:masterfrom
teutat3s:electron_34-bin-drop
Jul 30, 2025
Merged

electron_{33,34}-bin: remove#427430
yayayayaka merged 2 commits intoNixOS:masterfrom
teutat3s:electron_34-bin-drop

Conversation

@teutat3s
Copy link
Member

@teutat3s teutat3s commented Jul 22, 2025

Previously:

End of life for electron_33 was 2025-04-29.
End of life for electron_34 was 2025-06-25.

Last package using electron_33-bin is electron-fiddle: #402588.

rg shows 0 packages using electron_34.

Related to #295770.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@teutat3s teutat3s force-pushed the electron_34-bin-drop branch from 926d51f to 4bc6a90 Compare July 22, 2025 11:52
@teutat3s teutat3s marked this pull request as draft July 22, 2025 11:54
teutat3s added 2 commits July 28, 2025 23:35
End of life on 2025-06-25.
End of life on 2025-04-29.
@teutat3s teutat3s force-pushed the electron_34-bin-drop branch from 4bc6a90 to 37e3d16 Compare July 28, 2025 21:35
@teutat3s teutat3s marked this pull request as ready for review July 28, 2025 21:36
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jul 28, 2025
Copy link
Member

@yayayayaka yayayayaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With #402588 merged, there are no more blockers left.

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jul 29, 2025
@yayayayaka yayayayaka merged commit 498f318 into NixOS:master Jul 30, 2025
29 of 33 checks passed
@teutat3s teutat3s deleted the electron_34-bin-drop branch July 30, 2025 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants