Skip to content

Comments

electron-{24,27,28,29,30,31}-bin: remove#384809

Merged
mweinelt merged 13 commits intoNixOS:masterfrom
mweinelt:electron-24-bin-drop
Mar 5, 2025
Merged

electron-{24,27,28,29,30,31}-bin: remove#384809
mweinelt merged 13 commits intoNixOS:masterfrom
mweinelt:electron-24-bin-drop

Conversation

@mweinelt
Copy link
Member

@mweinelt mweinelt commented Feb 24, 2025

This change removes electron-fiddle, logseq, whalebird, micropad, passky-desktop which have previously been transitively marked vulnerable when Electron 24/27/28/29/30 went EOL and blocked their removal.

for electron-fiddle @andersk
for logseq @cheeseecake
for whalebird @Weathercold
for micropad @rhysmdnz
for passky-desktop @akkesm

for electron @emilylange @yuyuyureka

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Feb 24, 2025
@TomaSajt
Copy link
Contributor

I had a fix PR for electron-fiddle, but I don't use the package, so I don't really care if we drop it.

@mweinelt mweinelt changed the title electron-24-bin: remove; electron-fiddle: remove electron-{24,27,28,29,30}-bin: remove Feb 24, 2025
@github-actions github-actions bot added 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Feb 24, 2025
@mweinelt mweinelt force-pushed the electron-24-bin-drop branch from 3257162 to 078f1d3 Compare February 24, 2025 23:56
@mweinelt mweinelt changed the title electron-{24,27,28,29,30}-bin: remove electron-{24,27,28,29,30,31}-bin: remove Feb 24, 2025
@mweinelt mweinelt force-pushed the electron-24-bin-drop branch from 078f1d3 to dc0a2ce Compare February 25, 2025 00:42
@mweinelt mweinelt added this to the 25.05 milestone Feb 25, 2025
@mweinelt
Copy link
Member Author

Okay, I believe this is complete.

@emilylange emilylange added the 8.has: clean-up This PR removes packages or removes other cruft label Feb 25, 2025
@wegank wegank added the 12.approvals: 2 This PR was reviewed and approved by two persons. label Feb 25, 2025
@andersk
Copy link
Contributor

andersk commented Feb 28, 2025

I’ve fixed electron-fiddle at

@FliegendeWurst FliegendeWurst added the 2.status: merge conflict This PR has merge conflicts with the target branch label Mar 1, 2025
Copy link
Member

@teutat3s teutat3s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and thank you!

mweinelt added 6 commits March 5, 2025 12:01
End of life in 2023-10.
Last updated in 2024-04 and stuck on Electron 27, which went EOL in
in the same month. It has since blocked the Electron 27 removal.
Last updated in 2024-01 and using Electron 27 which went EOL in 2024-04.
EOL in 2024-04.
EOL in 2024-06.
Last updated in 2024-04 and using Electron 29 which went EOL in 2024-08.
@mweinelt mweinelt force-pushed the electron-24-bin-drop branch from dc0a2ce to 8c7aa31 Compare March 5, 2025 11:02
@mweinelt
Copy link
Member Author

mweinelt commented Mar 5, 2025

Rebased and I think we should go for merge once eval completes.

@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Mar 5, 2025
@teutat3s teutat3s added 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. 12.approvals: 3+ This PR was reviewed and approved by three or more persons. and removed 12.approvals: 2 This PR was reviewed and approved by two persons. labels Mar 5, 2025
@mweinelt mweinelt merged commit 46c7edc into NixOS:master Mar 5, 2025
25 checks passed
@mweinelt mweinelt deleted the electron-24-bin-drop branch March 5, 2025 11:33
@nyabinary
Copy link
Contributor

nyabinary commented Mar 11, 2025

Logseq is about to be updatedto Electron 35:
logseq/logseq#11780

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: clean-up This PR removes packages or removes other cruft 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 3+ This PR was reviewed and approved by three or more persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants