electron-{24,27,28,29,30,31}-bin: remove#384809
Merged
mweinelt merged 13 commits intoNixOS:masterfrom Mar 5, 2025
Merged
Conversation
yuyuyureka
approved these changes
Feb 24, 2025
Contributor
|
I had a fix PR for electron-fiddle, but I don't use the package, so I don't really care if we drop it. |
3257162 to
078f1d3
Compare
078f1d3 to
dc0a2ce
Compare
Member
Author
|
Okay, I believe this is complete. |
emilylange
approved these changes
Feb 25, 2025
This was referenced Feb 25, 2025
Contributor
|
I’ve fixed electron-fiddle at |
End of life in 2023-10.
Last updated in 2024-04 and stuck on Electron 27, which went EOL in in the same month. It has since blocked the Electron 27 removal.
Last updated in 2024-01 and using Electron 27 which went EOL in 2024-04.
EOL in 2024-04.
EOL in 2024-06.
Last updated in 2024-04 and using Electron 29 which went EOL in 2024-08.
EOL in 2024-08.
EOL in 2024-08.
EOL in 2024-10.
EOL in 2024-10.
EOL in 2025-01.
EOL in 2025-01.
dc0a2ce to
8c7aa31
Compare
Member
Author
|
Rebased and I think we should go for merge once eval completes. |
2 tasks
Contributor
|
Logseq is about to be updatedto Electron 35: |
1 task
13 tasks
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change removes electron-fiddle, logseq, whalebird, micropad, passky-desktop which have previously been transitively marked vulnerable when Electron 24/27/28/29/30 went EOL and blocked their removal.
for electron-fiddle @andersk
for logseq @cheeseecake
for whalebird @Weathercold
for micropad @rhysmdnz
for passky-desktop @akkesm
for electron @emilylange @yuyuyureka
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.