Skip to content

[staging-next] sage: unpin python, adapt to scipy 1.16 update#423832

Merged
collares merged 2 commits intoNixOS:staging-nextfrom
collares:sage-unpin-python
Jul 9, 2025
Merged

[staging-next] sage: unpin python, adapt to scipy 1.16 update#423832
collares merged 2 commits intoNixOS:staging-nextfrom
collares:sage-unpin-python

Conversation

@collares
Copy link
Member

@collares collares commented Jul 9, 2025

Revert #418009, since the relevant CPython 3.13 bug was fixed in 3.13.5. We also update the expectations for some numerical optimization tests due to the SciPy update.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other contributing documentation in corresponding paths.

Add a 👍 reaction to pull requests you find important.

This reverts commit 9944fed.
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Jul 9, 2025
@collares collares changed the title [staging-next] sage: unpin python [staging-next] sage: unpin python, adapt to scipy 1.16 update Jul 9, 2025
@collares
Copy link
Member Author

collares commented Jul 9, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 423832
Commit: 739a7b4848c875e333d47ab55b48ca30657baa7b


x86_64-linux

❌ 1 package failed to build:
  • labplot
✅ 3 packages built:
  • cantor (libsForQt5.cantor, plasma5Packages.cantor)
  • sage
  • sageWithDoc

@collares
Copy link
Member Author

collares commented Jul 9, 2025

The labplot failure is unrelated. It happens because readstat is broken (cc @swflint):

configure.ac:43: warning: macro 'AM_ICONV' not found in library
autoreconf: running: /nix/store/0qmqybsb86p5g6vqxj992grj9hyh72wa-autoconf-2.72/bin/autoconf --force
configure.ac:43: error: possibly undefined macro: AM_ICONV
      If this token and others are legitimate, please use m4_pattern_allow.
      See the Autoconf documentation.

A fix similar to #421040 needs to be applied to readstat.

@collares collares merged commit 628b324 into NixOS:staging-next Jul 9, 2025
25 of 29 checks passed
@collares collares deleted the sage-unpin-python branch July 9, 2025 21:41
@AndrewKvalheim
Copy link
Member

A fix similar to #421040 needs to be applied to readstat.

Completed in #425879

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

9.needs: reviewer This PR currently has no reviewers requested and needs attention. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants