python3Packages.mlx-lm: init at 0.26.0#424177
Conversation
|
@ferrine can you make @Aleksanaa's requested change? I need to land the update to xgrammar. |
|
|
strange, just rebased and this is what I get |
|
Something was fixed upstream. In any case, looks good to me. |
|
Building I have |
What is this test about? If it needs network connection, it seems we should disable that |
|
I am having the same errors and agree that it should be disabled |
This comment was marked as outdated.
This comment was marked as outdated.
sarahec
left a comment
There was a problem hiding this comment.
I was able to reproduce the test errors. Here's what you need to exclude.
There was a problem hiding this comment.
| # ModuleNotFoundError: No module named 'datasets' | |
| "tests/test_datsets.py::TestDatasets::test_hf" | |
| # RuntimeError: [metal_kernel] No GPU back-end. | |
| "tests/test_models.py::TestModels::test_bitnet" | |
| # Requires network access to huggingface.co | |
| "tests/test_datsets.py" | |
| "tests/test_generate.py" | |
| "tests/test_server.py" | |
| "tests/test_tokenizers.py" | |
| "tests/test_utils.py::TestUtils::test_convert" | |
| "tests/test_utils.py::TestUtils::test_load" | |
| "tests/test_utils_load_model.py" | |
| "tests/test_prompt_cache.py::TestPromptCache::test_cache_to_quantized" | |
| "tests/test_prompt_cache.py::TestPromptCache::test_cache_with_generate" | |
| "tests/test_prompt_cache.py::TestPromptCache::test_trim_cache_with_generate" | |
| # RuntimeError: [metal_kernel] No GPU back-end. | |
| "tests/test_models.py::TestModels::test_bitnet" |
There was a problem hiding this comment.
For your reference:
tests/test_datsets.py FFF [ 2%]
tests/test_finetune.py ............... [ 15%]
tests/test_generate.py EEEEEE [ 21%]
tests/test_gguf.py . [ 22%]
tests/test_models.py ........................s..................... [ 62%]
tests/test_prompt_cache.py .FF.....F [ 70%]
tests/test_sample_utils.py .... [ 74%]
tests/test_server.py EEEEEEEEEE....... [ 89%]
tests/test_tokenizers.py FFFF [ 92%]
tests/test_tuner_utils.py .. [ 94%]
tests/test_utils.py FF.. [ 98%]
tests/test_utils_load_model.py FF [100%]
=========================== short test summary info ============================
FAILED tests/test_datsets.py::TestDatasets::test_chat - OSError: We couldn't connect to 'https://huggingface.co' to load the files,...
FAILED tests/test_datsets.py::TestDatasets::test_completions - OSError: We couldn't connect to 'https://huggingface.co' to load the files,...
FAILED tests/test_datsets.py::TestDatasets::test_text - OSError: We couldn't connect to 'https://huggingface.co' to load the files,...
FAILED tests/test_prompt_cache.py::TestPromptCache::test_cache_to_quantized - huggingface_hub.errors.LocalEntryNotFoundError: An error happened while try...
FAILED tests/test_prompt_cache.py::TestPromptCache::test_cache_with_generate - huggingface_hub.errors.LocalEntryNotFoundError: An error happened while try...
FAILED tests/test_prompt_cache.py::TestPromptCache::test_trim_cache_with_generate - huggingface_hub.errors.LocalEntryNotFoundError: An error happened while try...
FAILED tests/test_tokenizers.py::TestTokenizers::test_special_tokens - huggingface_hub.errors.LocalEntryNotFoundError: An error happened while try...
FAILED tests/test_tokenizers.py::TestTokenizers::test_thinking - huggingface_hub.errors.LocalEntryNotFoundError: An error happened while try...
FAILED tests/test_tokenizers.py::TestTokenizers::test_tokenizers - huggingface_hub.errors.LocalEntryNotFoundError: An error happened while try...
FAILED tests/test_tokenizers.py::TestTokenizers::test_tool_calling - huggingface_hub.errors.LocalEntryNotFoundError: An error happened while try...
FAILED tests/test_utils.py::TestUtils::test_convert - huggingface_hub.errors.LocalEntryNotFoundError: An error happened while try...
FAILED tests/test_utils.py::TestUtils::test_load - huggingface_hub.errors.LocalEntryNotFoundError: An error happened while try...
FAILED tests/test_utils_load_model.py::TestLoadModelCustomGetClasses::test_load_model_with_custom_get_classes - huggingface_hub.errors.LocalEntryNotFoundError: An error happened while try...
FAILED tests/test_utils_load_model.py::TestLoadModelCustomGetClasses::test_load_model_with_default_get_classes - huggingface_hub.errors.LocalEntryNotFoundError: An error happened while try...
ERROR tests/test_generate.py::TestGenerate::test_generate - huggingface_hub.errors.LocalEntryNotFoundError: An error happened while try...
ERROR tests/test_generate.py::TestGenerate::test_generate_with_logit_bias - huggingface_hub.errors.LocalEntryNotFoundError: An error happened while try...
ERROR tests/test_generate.py::TestGenerate::test_generate_with_processor - huggingface_hub.errors.LocalEntryNotFoundError: An error happened while try...
ERROR tests/test_generate.py::TestGenerate::test_stream_generate_input_embeddings - huggingface_hub.errors.LocalEntryNotFoundError: An error happened while try...
ERROR tests/test_generate.py::TestGenerate::test_stream_generate_input_embeddings_prefill - huggingface_hub.errors.LocalEntryNotFoundError: An error happened while try...
ERROR tests/test_generate.py::TestGenerate::test_stream_generate_speculative - huggingface_hub.errors.LocalEntryNotFoundError: An error happened while try...
ERROR tests/test_server.py::TestServer::test_handle_chat_completions - huggingface_hub.errors.LocalEntryNotFoundError: An error happened while try...
ERROR tests/test_server.py::TestServer::test_handle_chat_completions_with_content_fragments - huggingface_hub.errors.LocalEntryNotFoundError: An error happened while try...
ERROR tests/test_server.py::TestServer::test_handle_chat_completions_with_null_tool_content - huggingface_hub.errors.LocalEntryNotFoundError: An error happened while try...
ERROR tests/test_server.py::TestServer::test_handle_completions - huggingface_hub.errors.LocalEntryNotFoundError: An error happened while try...
ERROR tests/test_server.py::TestServer::test_handle_models - huggingface_hub.errors.LocalEntryNotFoundError: An error happened while try...
ERROR tests/test_server.py::TestServer::test_sequence_overlap - huggingface_hub.errors.LocalEntryNotFoundError: An error happened while try...
ERROR tests/test_server.py::TestServerWithDraftModel::test_handle_chat_completions_with_draft_model - huggingface_hub.errors.LocalEntryNotFoundError: An error happened while try...
ERROR tests/test_server.py::TestServerWithDraftModel::test_handle_completions_with_draft_model - huggingface_hub.errors.LocalEntryNotFoundError: An error happened while try...
ERROR tests/test_server.py::TestServerWithDraftModel::test_prompt_cache_with_draft_model - huggingface_hub.errors.LocalEntryNotFoundError: An error happened while try...
ERROR tests/test_server.py::TestServerWithDraftModel::test_streaming_with_draft_model - huggingface_hub.errors.LocalEntryNotFoundError: An error happened while try...
====== 14 failed, 82 passed, 1 skipped, 2 deselected, 16 errors in 20.27s ======There was a problem hiding this comment.
Right, I've added these changes, will run nixpkgs-review in the background
|
|
|
seems to be again the issue with cache on my side, will be back on it later |
|
Not sure if this is something that Sorry for the drive-by (I'm on mobile), but this has gotten me past a few checkPhase errors in the past, so thought I'd throw it out there. Thanks for the work on this package! |
|
Packages must not contact the internet outside of FODs; if they do, it’s a bug. So it shouldn’t be worked around, if it is indeed doing DNS lookups for a remote host; the tests should be adjusted or disabled. |
|
I'm not able to fail the nixpkgs-review, what is the error log for python312? @ethancedwards8 |
|
GaetanLepage
left a comment
There was a problem hiding this comment.
Looks very good already!
Update pkgs/development/python-modules/mlx-lm/default.nix Co-authored-by: Ethan Carter Edwards <ethan@ethancedwards.com>
|
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.