Skip to content

python3Packages.valkey: disable failing tests on Darwin#419715

Closed
ConnorBaker wants to merge 1 commit intoNixOS:masterfrom
ConnorBaker:fix/darwin-python3Packages-valkey-tests
Closed

python3Packages.valkey: disable failing tests on Darwin#419715
ConnorBaker wants to merge 1 commit intoNixOS:masterfrom
ConnorBaker:fix/darwin-python3Packages-valkey-tests

Conversation

@ConnorBaker
Copy link
Contributor

I noticed these failures while running nixpkgs-review for an unrelated PR.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 24.11 and 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 24.11 and 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other contributing documentation in corresponding paths.

Add a 👍 reaction to pull requests you find important.

Signed-off-by: Connor Baker <connorbaker01@gmail.com>
@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Jun 24, 2025
@ConnorBaker ConnorBaker self-assigned this Jun 24, 2025
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 6.topic: python Python is a high-level, general-purpose programming language. labels Jun 24, 2025
@nixpkgs-ci nixpkgs-ci bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Jul 9, 2025
@ConnorBaker
Copy link
Contributor Author

Should have been fixed by #422850.

@ConnorBaker ConnorBaker deleted the fix/darwin-python3Packages-valkey-tests branch July 17, 2025 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2.status: merge conflict This PR has merge conflicts with the target branch 6.topic: darwin Running or building packages on Darwin 6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant