-
-
Notifications
You must be signed in to change notification settings - Fork 17.2k
rust: 1.87.0 -> 1.88.0 #420390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rust: 1.87.0 -> 1.88.0 #420390
Conversation
|
Built fd on x86_64-darwin, aarch64-darwin, aarch64-linux. |
|
built cargo on |
|
Built and ran lutgen and eza on |
|
Have we given up on the normal checklist for Rust updates? nixpkgs/pkgs/development/compilers/rust/1_88.nix Lines 1 to 10 in 3dc866c
|
|
Let's clean up that comment then?
|
Are any of those checks not satisfied? |
|
Who built Firefox and Thunderbird? |
|
You're right, I don't think that's been done, sorry. I'm on aarch64-darwin but I believe I could set up linux-builder and try building Firefox and Thunderbird for x86_64-linux, if that's still something that should be done. Forgive me, this is my first merged contribution after all ^^' |
|
It's okay — it wasn't your responsibility necessarily anyway, and I don't think checking that in advance has been worth the amount of time it's taken per update anyway, at least for the last few years, and evidently the other maintainers who haven't been doing it for the last few updates agree. So let's just drop it: #421017 Thank you for your contribution. :) |
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release-25.05
git worktree add -d .worktree/backport-420390-to-release-25.05 origin/release-25.05
cd .worktree/backport-420390-to-release-25.05
git switch --create backport-420390-to-release-25.05
git cherry-pick -x 3dc866c475dd680885594c9c773933072e849eab |
Release notes: https://github.com/rust-lang/rust/releases/tag/1.88.0
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.