Skip to content

Conversation

@valentinegb
Copy link
Contributor

@valentinegb valentinegb commented Jun 27, 2025

Release notes: https://github.com/rust-lang/rust/releases/tag/1.88.0

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 24.11 and 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 24.11 and 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other contributing documentation in corresponding paths.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 12.first-time contribution This PR is the author's first one; please be gentle! 6.topic: rust General-purpose programming language emphasizing performance, type safety, and concurrency. labels Jun 27, 2025
@zowoq
Copy link
Contributor

zowoq commented Jun 27, 2025

Built fd on x86_64-darwin, aarch64-darwin, aarch64-linux.

@Redhawk18
Copy link
Member

built cargo on x86_64-linux

@ozwaldorf
Copy link
Contributor

ozwaldorf commented Jun 28, 2025

Built and ran lutgen and eza on x86_64-linux

@zowoq zowoq merged commit f9dc03a into NixOS:staging Jun 28, 2025
31 of 33 checks passed
@alyssais
Copy link
Member

Have we given up on the normal checklist for Rust updates?

# New rust versions should first go to staging.
# Things to check after updating:
# 1. Rustc should produce rust binaries on x86_64-linux, aarch64-linux and x86_64-darwin:
# i.e. nix-shell -p fd or @GrahamcOfBorg build fd on github
# This testing can be also done by other volunteers as part of the pull
# request review, in case platforms cannot be covered.
# 2. The LLVM version used for building should match with rust upstream.
# Check the version number in the src/llvm-project git submodule in:
# https://github.com/rust-lang/rust/blob/<version-tag>/.gitmodules
# 3. Firefox and Thunderbird should still build on x86_64-linux.

@zowoq
Copy link
Contributor

zowoq commented Jun 28, 2025

Have we given up on the normal checklist for Rust updates?

#407444, #395734?

@alyssais
Copy link
Member

alyssais commented Jun 28, 2025 via email

@valentinegb
Copy link
Contributor Author

Have we given up on the normal checklist for Rust updates?

# New rust versions should first go to staging.
# Things to check after updating:
# 1. Rustc should produce rust binaries on x86_64-linux, aarch64-linux and x86_64-darwin:
# i.e. nix-shell -p fd or @GrahamcOfBorg build fd on github
# This testing can be also done by other volunteers as part of the pull
# request review, in case platforms cannot be covered.
# 2. The LLVM version used for building should match with rust upstream.
# Check the version number in the src/llvm-project git submodule in:
# https://github.com/rust-lang/rust/blob/<version-tag>/.gitmodules
# 3. Firefox and Thunderbird should still build on x86_64-linux.

Are any of those checks not satisfied?

@alyssais
Copy link
Member

Who built Firefox and Thunderbird?

@valentinegb
Copy link
Contributor Author

You're right, I don't think that's been done, sorry. I'm on aarch64-darwin but I believe I could set up linux-builder and try building Firefox and Thunderbird for x86_64-linux, if that's still something that should be done. Forgive me, this is my first merged contribution after all ^^'

@alyssais
Copy link
Member

It's okay — it wasn't your responsibility necessarily anyway, and I don't think checking that in advance has been worth the amount of time it's taken per update anyway, at least for the last few years, and evidently the other maintainers who haven't been doing it for the last few updates agree. So let's just drop it: #421017

Thank you for your contribution. :)

@valentinegb valentinegb deleted the rust-1.88.0 branch June 29, 2025 16:45
@niklaskorz niklaskorz mentioned this pull request Jul 10, 2025
13 tasks
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Jul 31, 2025

Backport failed for release-25.05, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-25.05
git worktree add -d .worktree/backport-420390-to-release-25.05 origin/release-25.05
cd .worktree/backport-420390-to-release-25.05
git switch --create backport-420390-to-release-25.05
git cherry-pick -x 3dc866c475dd680885594c9c773933072e849eab

@mdaniels5757 mdaniels5757 removed the backport release-25.05 Backport PR automatically label Aug 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: rust General-purpose programming language emphasizing performance, type safety, and concurrency. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 12.first-time contribution This PR is the author's first one; please be gentle!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants