rust: drop Firefox and Thunderbird from checklist #421017
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nixpkgs-ci
bot
added
10.rebuild-darwin: 0
winterqt
approved these changes
Jun 29, 2025
Member
winterqt
left a comment
winterqt
left a comment
There was a problem hiding this comment.
Reasonable.
(When you say that there was a patch that could be backported for Thunderbird, you mean before we had to get directly involved/file a bug?)
nixpkgs-ci
bot
added
the
12.approvals: 1
Member
Author
|
No, because Firefox had already fixed it, so I just picked it from Firefox to Thunderbird. |
nixpkgs-ci
bot
added
the
2.status: merge conflict
This hasn't been done for the last few releases, there haven't been any problems, and documentation should match reality. Last time Thunderbird broke there was a patch for it that could be backported.
alyssais
force-pushed
the
rust-firefox-thunderbird
branch
from
ea11136 to
3e14707
Compare
nixpkgs-ci
bot
removed
the
2.status: merge conflict
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This hasn't been done for the last few releases, there haven't been any problems, and documentation should match reality. Last time Thunderbird broke there was a patch for it that could be backported.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.