-
-
Notifications
You must be signed in to change notification settings - Fork 17.2k
rustc: 1.86.0 -> 1.87.0 #407444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rustc: 1.86.0 -> 1.87.0 #407444
Conversation
|
(forgot whether we normally backport these or not (we don't, it seems) -- but I guess it may be nice to get it into 25.05...?) |
|
How about adding |
|
Good idea, though it seems like we usually don’t do that until something that requires it comes up. If we were doing another staging cycle before the release then I’d backport it, but… dunno. |
Indeed. It doesn't seem like there's anything earth-shattering in this release that makes it particularly urgent to have this in stable (where we'd then be forced to keep it around for six months). |
alyssais
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Diff LGTM.
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release-25.05
git worktree add -d .worktree/backport-407444-to-release-25.05 origin/release-25.05
cd .worktree/backport-407444-to-release-25.05
git switch --create backport-407444-to-release-25.05
git cherry-pick -x 3b58d0ac8533e58882c9b4e6e2ffe0fc4a300dbf 4efa2ff7a1c0343a0a253fb02c7725d119a4321c 1000a826ebc4b104746cb127852993ca3910efbd |
|
Can you create a backport PR to 25.05 for 1.87 rustc version please? |
|
We don't backport Rust updates, as they can be breaking for packages that use nightly features, of which we have many. |
|
(When we really need a newer Rust version on stable, e.g. to build browsers, it's added as a new, versioned attribute.) |
Do we have a good example or pattern for creating this versioned backport? I've now hit two security important patches that really should be backported, kanidm and fractal, that need a newer rustc. I'd probably suggest 1.88 since that's what the matrix libraries want. |
|
You can't backport just the security fix, not the changes to use newer Rust features? |
|
In the case of Fractal, they upgraded to the newer version of matrix-rust-sdk which depends on 1.88, but is where the important security fixes come in. So no, there's not really a trivial way to just backport the security fix. For kanidm, there are multiple dependencies that want 1.87+. While not technically a security fix, we do follow upstream's support lifecycle and backport upgrades. Since it's a security important tool, I'd much prefer to continue to stick to what upstream supports. |
Hmm yes, it's annoying that we don't have a good way to patch dependencies. Anyway, if you do need to backport a rustc, look at past Firefox backports, I guess. |
https://github.com/rust-lang/rust/releases/tag/1.87.0
Things done
nix-build -A fdnix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.