Skip to content

[Backport release-25.05] [python3Packages.]uv: remove cmake, reuse existing uv binary.#420015

Merged
GaetanLepage merged 3 commits intoNixOS:release-25.05from
bengsparks:pyUv.backports
Jun 25, 2025
Merged

[Backport release-25.05] [python3Packages.]uv: remove cmake, reuse existing uv binary.#420015
GaetanLepage merged 3 commits intoNixOS:release-25.05from
bengsparks:pyUv.backports

Conversation

@bengsparks
Copy link
Contributor

Backport of #407665 (remove cmake, pkg-config) and #412206 (reuse existing uv binary).

As these changes only affect the way the package is built, and don't change anything about how uv functions, this should be acceptable for backport.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 24.11 and 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 24.11 and 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other contributing documentation in corresponding paths.

Add a 👍 reaction to pull requests you find important.

github-actions[bot]

This comment was marked as resolved.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 501-1000 This PR causes many rebuilds on Linux and should normally target the staging branches. 6.topic: python Python is a high-level, general-purpose programming language. 4.workflow: backport This targets a stable branch labels Jun 25, 2025
master: `nix-build -A python3Packages.uv` - `0.59s user 0.19s system 0% cpu 12:01.12 total`
branch: `nix-build -A python3Packages.uv` - `1.55s user 0.15s system 7% cpu 9.331 total`
(cherry picked from commit 0b12c69)
@github-actions github-actions bot dismissed their stale review June 25, 2025 19:43

All cherry-picks are good now, thank you!

@bengsparks
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 420015 --skip-package-regex home-assistant.*
Commit: 9752cc5e90a92f71451b730464ca1407838aa0d3


aarch64-darwin

✅ 9 packages built:
  • hatch
  • hatch.dist
  • prefect
  • prefect.dist
  • python312Packages.uv
  • python312Packages.uv.dist
  • python313Packages.uv
  • python313Packages.uv.dist
  • uv

@bengsparks
Copy link
Contributor Author

I would review with aarch64-linux, but it's currently OOMing during the linker phase. CC @GaetanLepage @Prince213 .
I'll additionally backport uv when this PR is merged.

@bengsparks bengsparks marked this pull request as ready for review June 25, 2025 21:11
@GaetanLepage
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 420015 --skip-package-regex home-assistant.*
Commit: 9752cc5e90a92f71451b730464ca1407838aa0d3


x86_64-linux

✅ 15 packages built:
  • hatch
  • hatch.dist
  • heroic
  • prefect
  • prefect.dist
  • python312Packages.uv
  • python312Packages.uv.dist
  • python313Packages.homeassistant-stubs
  • python313Packages.homeassistant-stubs.dist
  • python313Packages.uv
  • python313Packages.uv.dist
  • umu-launcher
  • umu-launcher-unwrapped
  • uv
  • windmill

Copy link
Contributor

@GaetanLepage GaetanLepage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@GaetanLepage GaetanLepage requested a review from drupol June 25, 2025 21:52
@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 2 This PR was reviewed and approved by two persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Jun 25, 2025
@GaetanLepage GaetanLepage merged commit f66a490 into NixOS:release-25.05 Jun 25, 2025
30 of 32 checks passed
@bengsparks bengsparks deleted the pyUv.backports branch June 25, 2025 22:45
@Prince213 Prince213 mentioned this pull request Jun 26, 2025
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4.workflow: backport This targets a stable branch 6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 501-1000 This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 12.approvals: 2 This PR was reviewed and approved by two persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants