Skip to content

python3Packages.uv: reuse already built uv binary#412206

Merged
GaetanLepage merged 1 commit intoNixOS:masterfrom
bengsparks:uv-no-maturin
May 31, 2025
Merged

python3Packages.uv: reuse already built uv binary#412206
GaetanLepage merged 1 commit intoNixOS:masterfrom
bengsparks:uv-no-maturin

Conversation

@bengsparks
Copy link
Contributor

Same principal as #412112, but with even more speedup.

master: nix-build -A python3Packages.uv - 0.59s user 0.19s system 0% cpu 12:01.12 total
branch: nix-build -A python3Packages.uv - 1.55s user 0.15s system 7% cpu 9.331 total

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 24.11 and 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 24.11 and 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

master: `nix-build -A python3Packages.uv` - `0.59s user 0.19s system 0% cpu 12:01.12 total`
branch: `nix-build -A python3Packages.uv` - `1.55s user 0.15s system 7% cpu 9.331 total`
@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label May 30, 2025
@nix-owners nix-owners bot requested a review from natsukium May 30, 2025 00:25
@github-actions github-actions bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 501-1000 This PR causes many rebuilds on Linux and should normally target the staging branches. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. labels May 30, 2025
@nix-owners nix-owners bot requested review from GaetanLepage and Prince213 May 30, 2025 00:29
@bengsparks
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 412206 --skip-package-regex home-assistant.*


aarch64-darwin

✅ 8 packages built:
  • hatch
  • hatch.dist
  • prefect
  • prefect.dist
  • python312Packages.uv
  • python312Packages.uv.dist
  • python313Packages.uv
  • python313Packages.uv.dist

Copy link
Member

@Prince213 Prince213 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built on x86_64-linux and build logs LGTM

@Prince213 Prince213 added the 12.approvals: 1 This PR was reviewed and approved by one person. label May 30, 2025
@bengsparks bengsparks mentioned this pull request May 30, 2025
13 tasks
@GaetanLepage
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 412206 --skip-package-regex home-assistant.*
Commit: 0b12c690c53b5d98d8fc75e2469eff1c4f08a7e3


x86_64-linux

✅ 13 packages built:
  • hatch
  • hatch.dist
  • heroic
  • prefect
  • prefect.dist
  • python312Packages.uv
  • python312Packages.uv.dist
  • python313Packages.homeassistant-stubs
  • python313Packages.homeassistant-stubs.dist
  • python313Packages.uv
  • python313Packages.uv.dist
  • umu-launcher
  • umu-launcher-unwrapped

aarch64-linux

✅ 12 packages built:
  • hatch
  • hatch.dist
  • prefect
  • prefect.dist
  • python312Packages.uv
  • python312Packages.uv.dist
  • python313Packages.homeassistant-stubs
  • python313Packages.homeassistant-stubs.dist
  • python313Packages.uv
  • python313Packages.uv.dist
  • umu-launcher
  • umu-launcher-unwrapped

x86_64-darwin

✅ 8 packages built:
  • hatch
  • hatch.dist
  • prefect
  • prefect.dist
  • python312Packages.uv
  • python312Packages.uv.dist
  • python313Packages.uv
  • python313Packages.uv.dist

aarch64-darwin

✅ 8 packages built:
  • hatch
  • hatch.dist
  • prefect
  • prefect.dist
  • python312Packages.uv
  • python312Packages.uv.dist
  • python313Packages.uv
  • python313Packages.uv.dist

Copy link
Contributor

@GaetanLepage GaetanLepage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for this effort.

@GaetanLepage GaetanLepage requested a review from kirillrdy May 31, 2025 18:30
@GaetanLepage GaetanLepage merged commit 2ce7ae3 into NixOS:master May 31, 2025
17 of 18 checks passed
@bengsparks bengsparks deleted the uv-no-maturin branch May 31, 2025 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 501-1000 This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants