Skip to content

[Backport release-24.11] libxmp: 4.6.0 -> 4.6.3; cleanup#419035

Merged
pbsds merged 6 commits intoNixOS:release-24.11from
mdaniels5757:backport-407247-to-release-24.11
Jun 24, 2025
Merged

[Backport release-24.11] libxmp: 4.6.0 -> 4.6.3; cleanup#419035
pbsds merged 6 commits intoNixOS:release-24.11from
mdaniels5757:backport-407247-to-release-24.11

Conversation

@mdaniels5757
Copy link
Member

Backport of #369944 #384918 #402124 #407247 to release-24.11. Fixes GHSA-vg32-cm75-rjr5.

  • Before merging, ensure that this backport is acceptable for the release.
    • Even as a non-committer, if you find that it is not acceptable, leave a comment.

@mdaniels5757 mdaniels5757 added the 1.severity: security Issues which raise a security issue, or PRs that fix one label Jun 22, 2025
@mdaniels5757 mdaniels5757 force-pushed the backport-407247-to-release-24.11 branch from 79884e1 to c3cdc05 Compare June 22, 2025 22:21
@github-actions github-actions bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 4.workflow: backport This targets a stable branch labels Jun 22, 2025
@mdaniels5757

This comment was marked as outdated.

@pbsds pbsds requested a review from marcin-serwin June 24, 2025 02:22
r-ryantm and others added 6 commits June 24, 2025 09:48
(cherry picked from commit b57fc48)
(cherry picked from commit 9e7bd41)
(cherry picked from commit 54c1541)
(cherry picked from commit f5a888c)
@mdaniels5757 mdaniels5757 force-pushed the backport-407247-to-release-24.11 branch from c3cdc05 to 9a2ee45 Compare June 24, 2025 13:50
@mdaniels5757
Copy link
Member Author

mdaniels5757 commented Jun 24, 2025

The ut1999 failure is just because it requires an unfree binary be retrieved via nix-prefetch-url.

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 419035

Logs: https://github.com/mdaniels5757/nixpkgs-review-gha/actions/runs/15852382877


x86_64-linux (sandbox = true)

❌ 1 package failed to build:
  • ut1999
✅ 11 packages built:
  • easyrpg-player
  • ironwail
  • libretro.easyrpg
  • libxmp
  • libxmp.dev
  • libxmp.man
  • openarena
  • quakespasm
  • retroarchFull
  • woof-doom
  • xmp

aarch64-linux (sandbox = true)

❌ 1 package failed to build:
  • ut1999
✅ 11 packages built:
  • easyrpg-player
  • ironwail
  • libretro.easyrpg
  • libxmp
  • libxmp.dev
  • libxmp.man
  • openarena
  • quakespasm
  • retroarchFull
  • woof-doom
  • xmp

x86_64-darwin (sandbox = true)

❌ 1 package failed to build:
  • ut1999
✅ 6 packages built:
  • easyrpg-player
  • libxmp
  • libxmp.dev
  • libxmp.man
  • quakespasm
  • xmp

aarch64-darwin (sandbox = true)

✅ 6 packages built:
  • easyrpg-player
  • libxmp
  • libxmp.dev
  • libxmp.man
  • quakespasm
  • xmp

Copy link
Contributor

@marcin-serwin marcin-serwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff lgtm and builds on top of release-24.11.

Didn't expect to become a maintainer in 24.11 so late in the cycle :)

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jun 24, 2025
@pbsds pbsds merged commit 9fc29a5 into NixOS:release-24.11 Jun 24, 2025
26 of 28 checks passed
@mdaniels5757 mdaniels5757 deleted the backport-407247-to-release-24.11 branch June 24, 2025 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1.severity: security Issues which raise a security issue, or PRs that fix one 4.workflow: backport This targets a stable branch 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants