Skip to content

libxmp: modernize; adopt#402124

Merged
siraben merged 2 commits intoNixOS:masterfrom
marcin-serwin:push-uqrqnxzqymnz
Apr 27, 2025
Merged

libxmp: modernize; adopt#402124
siraben merged 2 commits intoNixOS:masterfrom
marcin-serwin:push-uqrqnxzqymnz

Conversation

@marcin-serwin
Copy link
Contributor

Related #402066

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Apr 26, 2025
@siraben
Copy link
Member

siraben commented Apr 27, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 402124


x86_64-linux

❌ 1 package failed to build:
  • qmmp
✅ 14 packages built:
  • easyrpg-player
  • ironwail
  • libretro.easyrpg
  • libxmp
  • libxmp.dev
  • libxmp.man
  • openarena
  • openomf
  • quakespasm
  • retroarch-free
  • retroarch-full
  • ut1999
  • woof-doom
  • xmp

@siraben siraben merged commit 4e397bd into NixOS:master Apr 27, 2025
23 of 27 checks passed
@LordGrimmauld
Copy link
Contributor

Thank you! It got late yesterday and i didn't get around to reviewing this, but nice to see this got adoption and much needed cleanup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants