vscode-extensions.detachhead.basedpyright: init at 1.29.2#413088
vscode-extensions.detachhead.basedpyright: init at 1.29.2#413088drupol merged 1 commit intoNixOS:masterfrom
Conversation
f3e1404 to
cfccf81
Compare
|
@drupol I'm happy to move it, just interested if this is the strategy for all new VSCode extension packages? At the top of
And in the README.md it says:
That sounded like I should put the extension in the |
|
I understand your point. At the moment, there's no clear consensus on this. However, while working on the VSCode extension updater (#389585), @emaryn had to implement additional logic to ensure extensions defined in There’s an open issue tracking this here: #381230. In my opinion, we should adopt the per-file approach. The VSCode ecosystem has an ever-growing number of extensions, and maintaining everything in a single file will eventually become unmanageable. Take a look at the most recent VSCode extension PRs and you'll see that nearly all of them use separate files. So yes, please do update the README. It’s a great idea, and it should reflect the current practice anyway. |
|
Okay, I've moved the extension to a separate directory :) |
cfccf81 to
8ad71c4
Compare
8ad71c4 to
3c64e50
Compare
basedpyright VSCode extension
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.