Skip to content

vscode-extensions.detachhead.basedpyright: init at 1.29.2#413088

Merged
drupol merged 1 commit intoNixOS:masterfrom
Hasnep:add-basedpyright-vscode-extension
Jun 18, 2025
Merged

vscode-extensions.detachhead.basedpyright: init at 1.29.2#413088
drupol merged 1 commit intoNixOS:masterfrom
Hasnep:add-basedpyright-vscode-extension

Conversation

@Hasnep
Copy link
Contributor

@Hasnep Hasnep commented Jun 2, 2025

basedpyright VSCode extension

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 24.11 and 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 24.11 and 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: vscode A free and versatile code editor that supports almost every major programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Jun 2, 2025
@Hasnep Hasnep force-pushed the add-basedpyright-vscode-extension branch 2 times, most recently from f3e1404 to cfccf81 Compare June 6, 2025 07:49
Copy link
Contributor

@drupol drupol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to move this extension in its own file, it's easier for the automatic updates. Get some inspiration at #407727

@Hasnep
Copy link
Contributor Author

Hasnep commented Jun 8, 2025

@drupol I'm happy to move it, just interested if this is the strategy for all new VSCode extension packages?

At the top of pkgs/applications/editors/vscode/extensions/default.nix it says:

Before adding a new extension, read ./README.md

And in the README.md it says:

  • Move extension to a discrete directory whenever the extension needs extra parameters/packages (at top of the file) or other files (such as patches, update script, components). Global index file parameters/packages should be utilities shared by many extensions. Extension specific parameters/packages should not be in the global index page.

That sounded like I should put the extension in the default.nix unless it had a reason not to. If putting all new packages in their own directory is the plan going forward, I can update the README to reflect that :)

@drupol
Copy link
Contributor

drupol commented Jun 8, 2025

I understand your point.

At the moment, there's no clear consensus on this. However, while working on the VSCode extension updater (#389585), @emaryn had to implement additional logic to ensure extensions defined in default.nix are updated correctly. In contrast, when extensions are defined in their own files, nix-update works out of the box without requiring extra parsing.

There’s an open issue tracking this here: #381230.

In my opinion, we should adopt the per-file approach. The VSCode ecosystem has an ever-growing number of extensions, and maintaining everything in a single file will eventually become unmanageable.

Take a look at the most recent VSCode extension PRs and you'll see that nearly all of them use separate files.

So yes, please do update the README. It’s a great idea, and it should reflect the current practice anyway.

@Hasnep Hasnep mentioned this pull request Jun 16, 2025
13 tasks
@Hasnep
Copy link
Contributor Author

Hasnep commented Jun 16, 2025

Okay, I've moved the extension to a separate directory :)

@Hasnep Hasnep force-pushed the add-basedpyright-vscode-extension branch from cfccf81 to 8ad71c4 Compare June 16, 2025 03:23
@Hasnep Hasnep force-pushed the add-basedpyright-vscode-extension branch from 8ad71c4 to 3c64e50 Compare June 16, 2025 13:02
@drupol drupol merged commit 9e4ef76 into NixOS:master Jun 18, 2025
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: vscode A free and versatile code editor that supports almost every major programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants