Skip to content

vscode-extensions.teros-technology.teroshdl: init at 7.0.3#407727

Merged
drupol merged 2 commits intoNixOS:masterfrom
lheintzmann1:add-teroshdl-extension
May 20, 2025
Merged

vscode-extensions.teros-technology.teroshdl: init at 7.0.3#407727
drupol merged 2 commits intoNixOS:masterfrom
lheintzmann1:add-teroshdl-extension

Conversation

@lheintzmann1
Copy link
Member

@lheintzmann1 lheintzmann1 commented May 16, 2025

vscode-extensions.teros-technology.teroshdl: init at 7.0.3
Release: https://github.com/TerosTechnology/vscode-terosHDL/tree/latest

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 24.11 and 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 24.11 and 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: vscode A free and versatile code editor that supports almost every major programming language. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels May 16, 2025
@NixOSInfra NixOSInfra added the 12.first-time contribution This PR is the author's first one; please be gentle! label May 16, 2025
@github-actions github-actions bot added the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label May 17, 2025
Copy link
Contributor

@drupol drupol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello !

Thank you for your first PR to this project.

Here's my feedback:

  • This PR must only contain 2 commits:
  • 1 for adding you in the maintainer list (This commit must be the first commit in the PR)
  • 1 for adding the extension
  • Each VSCode extension lives in their own file. Try to get some inspiration from this PR #406449
  • Rewriting the Git history implies using git push --force (or an equivalent command if you're using another Git frontend like jujutsu).
    • Don't recreate a new PR, do everything in this PR
    • It is recommended to set your PR in draft mode before doing the rebase operation to prevent mass-pinging maintainers in case of issue
  • If you're looking for some help on how to properly format your commits, have a look at the Contributing guide, or simply look at the existing merged PR in the project.

Let me know if you need some assistance,

Good luck!

@drupol drupol marked this pull request as draft May 20, 2025 08:00
@lheintzmann1
Copy link
Member Author

@drupol Hello, Thank you for your help !
I think it's good now. (I had to redo a force push a second time because there was a syntax error, I hope it won't be a problem)

@drupol drupol marked this pull request as ready for review May 20, 2025 11:59
Copy link
Contributor

@drupol drupol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 ! Thank you !

@drupol drupol merged commit e3a5e6a into NixOS:master May 20, 2025
26 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: vscode A free and versatile code editor that supports almost every major programming language. 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.first-time contribution This PR is the author's first one; please be gentle!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants