vscode-extensions.teros-technology.teroshdl: init at 7.0.3#407727
Merged
drupol merged 2 commits intoNixOS:masterfrom May 20, 2025
lheintzmann1:add-teroshdl-extension
Merged
vscode-extensions.teros-technology.teroshdl: init at 7.0.3#407727drupol merged 2 commits intoNixOS:masterfrom lheintzmann1:add-teroshdl-extension
drupol merged 2 commits intoNixOS:masterfrom
lheintzmann1:add-teroshdl-extension
Conversation
drupol
requested changes
May 19, 2025
Contributor
There was a problem hiding this comment.
Hello !
Thank you for your first PR to this project.
Here's my feedback:
- This PR must only contain 2 commits:
- 1 for adding you in the maintainer list (This commit must be the first commit in the PR)
- 1 for adding the extension
- Each VSCode extension lives in their own file. Try to get some inspiration from this PR #406449
- Rewriting the Git history implies using
git push --force(or an equivalent command if you're using another Git frontend likejujutsu).- Don't recreate a new PR, do everything in this PR
- It is recommended to set your PR in draft mode before doing the rebase operation to prevent mass-pinging maintainers in case of issue
- If you're looking for some help on how to properly format your commits, have a look at the Contributing guide, or simply look at the existing merged PR in the project.
Let me know if you need some assistance,
Good luck!
Member
Author
|
@drupol Hello, Thank you for your help ! |
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
vscode-extensions.teros-technology.teroshdl: init at 7.0.3
Release: https://github.com/TerosTechnology/vscode-terosHDL/tree/latest
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.