vscode-extensions-update: init

[ghost]

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[drupol]

Hello,

I'm glad to see this issue being worked on. I haven't yet carefully check your script but here are a few suggestions:

• Make sure that the updated extension is working with the current version of VSCode
• Use Python

You can find a script I use regularly to update the VSCode extension here.

[drupol]

I left a few minor comments.

I have more important questions now:

1. I see you're doing a lot of processing to manually update the hash with the updated one. There are tools that do that already. Wouldn't it be better to use those tools instead of reinventing them?
2. How do you handle extensions that have multiple hashes based on their system ? I have the feeling that this is not covered by the script.
3. How is the script meant to be used? I don't really understand how to run it.

Thanks!

[jraygauthier]

Haven't reviewed the update script itself but this is a really nice centralization of the update scripts, it removes a lot of complexity from packages. Good job.

[drupol]

Shouldn't we add the updater by default in this builder ?

[JohnRTitor]

Yep, with the option to override.

[drupol]

What do you mean?

[JohnRTitor]

Sorry, I meant that we should be able to override passthru.updateScript in extensions when we want.

nixpkgs/pkgs/applications/editors/vscode/extensions/vscode-utils.nix

Line 44 in 9c213ed

inherit vscodeExtPublisher vscodeExtName vscodeExtUniqueId;

I think we can add it here.

[drupol]

Fully possible since #390180

[drupol]

If I were to vote, I'd vote for updating them individually, without using any kind of json file.

[JohnRTitor]

To be honest, I am in favor of updating all of them in one go, periodically, while still allowing updates of individual extensions. vscode-extensions maintenance is the second worst on Nixpkgs, after kernel modules.

Provided we account for bugs like these of course. (#392786)

[drupol]

How about merging this today, are you all OK with that? I think the script is great and is going to help a lot until we perhaps have another solution that you mentionned.

[drupol]

Sadly I don't think this will be ever possible.

[JohnRTitor]

Let's merge this today, and maybe try to reimplement the extensions structure to use a versions.json later. @emaryn you okay with that?

[JohnRTitor]

nixpkgs-vet check needs a fix perhaps

[drupol]

I'm thinking about something, would it be a good idea to add this script to all the extensions that have their own file (namely, those that are not defined in default.nix) ?

[drupol]

All good

[drupol]

I'm trying to update the vscode extension, I added `meta.platforms set to:

platforms = [
  "x86_64-linux"
  "x86_64-darwin"
  "aarch64-linux"
  "aarch64-darwin"
];

The command I run is: vscode-extensions-update --platforms vscode-extensions.visualjj.visualjj

But it only update the x86_64-linux (my own local platform). Is there a way to update all the platforms available?

[drupol]

The command I run is: vscode-extensions-update --platforms vscode-extensions.visualjj.visualjj
But it only update the x86_64-linux (my own local platform). Is there a way to update all the platforms available?

Sorry, I wrote the wrong condition for the if statement. Also, to use this, nix needs to be able to build for other platforms.

There's no sorry needed here :) Do you plan to do an update PR?

If yes, WDYT about using the method execute_command in place of with subprocess.Popen(...) ?