nixos/chromadb: deprecate logPath option#442520
Merged
GaetanLepage merged 1 commit intoNixOS:masterfrom Sep 13, 2025
Merged
Conversation
The module and nixos test are currently broken because the logPath option is always set by default and it passes a parameter to the CLI that no longer exists. Lets just remove logPath all together as the parameter it relied on got removed.
Contributor
Author
|
From what I can tell this test was broken by #412528 as running the test right before the PR at the commit 0e9e520 has the test pass. Looking at the OfBorg run for the PR it actually fails but this was ignored during merge... Hydra also shows the test passing consistently before the PR was merged https://hydra.nixos.org/job/nixos/trunk-combined/nixos.tests.chromadb.x86_64-linux/all?page=4 |
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Things done
The module and nixos test are currently broken because the logPath option is always set by default and it passes a parameter to the CLI that no longer exists. Lets just remove logPath all together as the parameter it relied on got removed. In it's current state the module does not work and fails with this error looping.
It's been failing for a while https://hydra.nixos.org/job/nixos/trunk-combined/nixos.tests.chromadb.x86_64-linux
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.