Skip to content

nixos/chromadb: deprecate logPath option#442520

Merged
GaetanLepage merged 1 commit intoNixOS:masterfrom
haylinmoore:pr442520
Sep 13, 2025
Merged

nixos/chromadb: deprecate logPath option#442520
GaetanLepage merged 1 commit intoNixOS:masterfrom
haylinmoore:pr442520

Conversation

@haylinmoore
Copy link
Contributor

@haylinmoore haylinmoore commented Sep 13, 2025

Things done

The module and nixos test are currently broken because the logPath option is always set by default and it passes a parameter to the CLI that no longer exists. Lets just remove logPath all together as the parameter it relied on got removed. In it's current state the module does not work and fails with this error looping.

machine # [  193.939160] chroma[2148]: error: unexpected argument '--log-path' found
machine # [  193.940345] chroma[2148]:   tip: to pass '--log-path' as a value, use '-- --log-path'
machine # [  193.941772] chroma[2148]: Usage: chroma run <CONFIG_PATH|--path <PATH>|--host <HOST>|--port <PORT>>
machine # [  193.943135] chroma[2148]: For more information, try '--help'.

It's been failing for a while https://hydra.nixos.org/job/nixos/trunk-combined/nixos.tests.chromadb.x86_64-linux

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

The module and nixos test are currently broken because the logPath option is always set by default and it passes a parameter to the CLI that no longer exists. Lets just remove logPath all together as the parameter it relied on got removed.
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Sep 13, 2025
@haylinmoore
Copy link
Contributor Author

haylinmoore commented Sep 13, 2025

From what I can tell this test was broken by #412528 as running the test right before the PR at the commit 0e9e520 has the test pass.

Looking at the OfBorg run for the PR it actually fails but this was ignored during merge...

       > !!!   File "<string>", line 3, in <module>
       > !!!     machine.wait_for_open_port(8000)
       > !!! 
       > !!! RequestedAssertionFailed: action timed out after 900 tries with one-second pause in-between
       > cleanup
       > kill machine (pid 11)
       > qemu-system-x86_64: terminating on signal 15 from pid 8 (/nix/store/8w718rm43x7z73xhw9d6vh8s4snrq67h-python3-3.12.10/bin/python3.12)
       > kill vlan (pid 9)
       > (finished: cleanup, in 0.01 seconds)
       For full logs, run 'nix log /nix/store/3qrf0sx1i0lz6vigp3j25z93i91ahvsg-vm-test-run-chromadb.drv'.

Hydra also shows the test passing consistently before the PR was merged https://hydra.nixos.org/job/nixos/trunk-combined/nixos.tests.chromadb.x86_64-linux/all?page=4

@haylinmoore haylinmoore mentioned this pull request Sep 13, 2025
13 tasks
@nixpkgs-ci nixpkgs-ci bot added the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Sep 13, 2025
Copy link
Contributor

@sarahec sarahec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. and removed 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Sep 13, 2025
Copy link
Contributor

@GaetanLepage GaetanLepage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@GaetanLepage GaetanLepage added this pull request to the merge queue Sep 13, 2025
Merged via the queue into NixOS:master with commit 3cefce3 Sep 13, 2025
38 of 40 checks passed
@haylinmoore haylinmoore deleted the pr442520 branch September 13, 2025 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants