Skip to content

discourse: 3.4.3 -> 3.4.4#411757

Merged
leona-ya merged 1 commit intoNixOS:masterfrom
mweinelt:discourse-3.4.4
May 29, 2025
Merged

discourse: 3.4.3 -> 3.4.4#411757
leona-ya merged 1 commit intoNixOS:masterfrom
mweinelt:discourse-3.4.4

Conversation

@mweinelt
Copy link
Member

https://meta.discourse.org/t/3-4-4-bug-fix-and-ux-release/367301/1

Only plugin to update was discourse-solved, which still fails.
NixOS test currently fails to eval, but a fix is being prepared over in #401991

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 24.11 and 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 24.11 and 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels May 28, 2025
@nix-owners nix-owners bot requested a review from talyz May 28, 2025 15:01
@roberth
Copy link
Member

roberth commented May 28, 2025

Since #411634 this should still work:

@ofborg build nixosTests.discourse

@mweinelt
Copy link
Member Author

I might work since the rebase 30 minutes ago, it didn't when I opened the PR.

@mweinelt mweinelt requested a review from leona-ya May 28, 2025 20:53
@leona-ya leona-ya merged commit 59972d3 into NixOS:master May 29, 2025
17 of 21 checks passed
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented May 29, 2025

Successfully created backport PR for release-25.05:

@github-actions github-actions bot added the 8.has: port to stable This PR already has a backport to the stable release. label May 29, 2025
@mweinelt mweinelt deleted the discourse-3.4.4 branch May 29, 2025 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: port to stable This PR already has a backport to the stable release. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments