Skip to content

nixosTests: fix eval#411634

Merged
roberth merged 1 commit intoNixOS:masterfrom
Prince213:push-xvuwwlyvkpvq
May 28, 2025
Merged

nixosTests: fix eval#411634
roberth merged 1 commit intoNixOS:masterfrom
Prince213:push-xvuwwlyvkpvq

Conversation

@Prince213
Copy link
Member

Related: #410569 (comment)

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 24.11 and 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 24.11 and 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS label May 28, 2025
@Prince213 Prince213 added 8.has: clean-up This PR removes packages or removes other cruft 1.severity: channel blocker Blocks a channel labels May 28, 2025
@Prince213 Prince213 requested review from mweinelt and roberth and removed request for mweinelt May 28, 2025 04:46
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels May 28, 2025
@piotrkwiecinski
Copy link
Contributor

Eval for discourse still fails https://github.com/piotrkwiecinski/nixpkgs-review-gha/actions/runs/15294870323/job/43021474926


       … while evaluating the attribute 'tests'
         at /home/runner/.cache/nixpkgs-review/pr-411634/nixpkgs/pkgs/servers/web-apps/discourse/default.nix:436:7:
          435|       ruby = rubyEnv.wrappedRuby;
          436|       tests = import ../../../../nixos/tests/discourse.nix {
             |       ^
          437|         inherit (stdenv) system;

       … from call site
         at /home/runner/.cache/nixpkgs-review/pr-411634/nixpkgs/pkgs/servers/web-apps/discourse/default.nix:436:15:
          435|       ruby = rubyEnv.wrappedRuby;
          436|       tests = import ../../../../nixos/tests/discourse.nix {
             |               ^
          437|         inherit (stdenv) system;

       error: function 'anonymous lambda' called without required argument 'lib'
       at /home/runner/.cache/nixpkgs-review/pr-411634/nixpkgs/nixos/tests/discourse.nix:6:1:
            5|
            6| {
             | ^
            7|   package,

Copy link
Member

@roberth roberth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with ( set -ex; nix-instantiate nixos/release.nix -A tests.breitbandmessung.x86_64-linux; nix-instantiate nixos/release.nix -A tests.brscan5.x86_64-linux; nix-instantiate nixos/release.nix -A tests.consul.x86_64-linux; nix-instantiate nixos/release.nix -A tests.deconz.x86_64-linux; nix-instantiate nixos/release.nix -A tests.discourse.x86_64-linux; nix-instantiate nixos/release.nix -A tests.fanout.x86_64-linux; nix-instantiate nixos/release.nix -A tests.gnome-extensions.x86_64-linux; nix-instantiate nixos/release.nix -A tests.initrd-luks-empty-passphrase.x86_64-linux; nix-instantiate nixos/release.nix -A tests.minecraft-server.x86_64-linux; nix-instantiate nixos/release.nix -A tests.netbox-upgrade.x86_64-linux; nix-instantiate nixos/release.nix -A tests.odoo.x86_64-linux; nix-instantiate nixos/release.nix -A tests.odoo16.x86_64-linux; nix-instantiate nixos/release.nix -A tests.odoo17.x86_64-linux; nix-instantiate nixos/release.nix -A tests.openldap.x86_64-linux; nix-instantiate nixos/release.nix -A tests.outline.x86_64-linux; nix-instantiate nixos/release.nix -A tests.quake3.x86_64-linux; nix-instantiate nixos/release.nix -A tests.sabnzbd.x86_64-linux; nix-instantiate nixos/release.nix -A tests.squid.x86_64-linux; nix-instantiate nixos/release.nix -A tests.systemd-analyze.x86_64-linux; nix-instantiate nixos/release.nix -A tests.systemd-initrd-luks-empty-passphrase.x86_64-linux; nix-instantiate nixos/release.nix -A tests.systemd-initrd-shutdown.x86_64-linux; nix-instantiate nixos/release.nix -A tests.systemd-shutdown.x86_64-linux; nix-instantiate nixos/release.nix -A tests.without-nix.x86_64-linux; )

The discourse passthru test can be fixed forward, probably in #401991

@roberth roberth merged commit 99db54d into NixOS:master May 28, 2025
14 of 17 checks passed
@Prince213
Copy link
Member Author

Thanks!

@roberth roberth mentioned this pull request May 28, 2025
13 tasks
@Prince213 Prince213 deleted the push-xvuwwlyvkpvq branch June 27, 2025 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1.severity: channel blocker Blocks a channel 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: clean-up This PR removes packages or removes other cruft 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants