nixosTests.discourse: fix eval

[piotrkwiecinski]

Part of #386873

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[drupol]

This shouldn't be required, doesn't it?

[GaetanLepage]

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 401991 --package nixosTests.discourse

---

x86_64-linux

✅ 1 test built:

• nixosTests.discourse

---

aarch64-linux

✅ 1 test built:

• nixosTests.discourse

---

x86_64-darwin

✅ 1 test built:

• nixosTests.discourse

---

aarch64-darwin

✅ 1 test built:

• nixosTests.discourse

[piotrkwiecinski]

Marking as draft as it breaks discourse.passthru.tests:

nixpkgs/pkgs/servers/web-apps/discourse/default.nix

Lines 436 to 440 in 9d47e86

	tests = import ../../../../nixos/tests/discourse.nix {
	inherit (stdenv) system;
	inherit pkgs;
	package = pkgs.discourse.override args;
	};

[drupol]

Marking as draft as it breaks discourse.passthru.tests:

nixpkgs/pkgs/servers/web-apps/discourse/default.nix

Lines 436 to 440 in 9d47e86

	tests = import ../../../../nixos/tests/discourse.nix {
	inherit (stdenv) system;
	inherit pkgs;
	package = pkgs.discourse.override args;
	};

Yeah, this is why the inherit package; is needed back.

[piotrkwiecinski]

I'm not sure if this is correct approach.

[roberth]

This would be really annoying to get right without #299542

[piotrkwiecinski]

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 401991

Logs: https://github.com/piotrkwiecinski/nixpkgs-review-gha/actions/runs/15306585608

---

x86_64-linux

✅ 1 test built:

• nixosTests.discourse

✅ 1 package built:

• discourse.passthru.tests._module.args.package.content

---

aarch64-linux

✅ 1 test built:

• nixosTests.discourse

✅ 1 package built:

• discourse.passthru.tests._module.args.package.content

---

x86_64-darwin

⏩ 2 packages marked as broken and skipped:

• discourse.passthru.tests._module.args.package.content
• nixosTests.discourse

---

aarch64-darwin

⏩ 2 packages marked as broken and skipped:

• discourse.passthru.tests._module.args.package.content
• nixosTests.discourse

[piotrkwiecinski]

I'll wait for #299542 to attempt fixing darwin