Skip to content

joplin-desktop: revert deletion of --enable-wayland-ime#412126

Merged
pbsds merged 1 commit intoNixOS:masterfrom
HHR2020:joplin-desktop-fix
Jun 4, 2025
Merged

joplin-desktop: revert deletion of --enable-wayland-ime#412126
pbsds merged 1 commit intoNixOS:masterfrom
HHR2020:joplin-desktop-fix

Conversation

@HHR2020
Copy link
Contributor

@HHR2020 HHR2020 commented May 29, 2025

fix input method when NIXOS_OZONE_WL is set

reverts #411104

Changes made in upstream only accept --enable-wayland-ime instead of --enable-wayland-ime=true

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 24.11 and 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 24.11 and 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

fix input method when NIXOS_OZONE_WL is set

reverts NixOS#411104
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels May 29, 2025
@nix-owners nix-owners bot requested review from HugoReeves, qjoly and yajo May 29, 2025 16:52
@HHR2020
Copy link
Contributor Author

HHR2020 commented May 29, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 412126

Logs: https://github.com/HHR2020/nixpkgs-review-gha/actions/runs/15328949222


x86_64-linux (sandbox = true)

✅ 1 package built:
  • joplin-desktop

@pbsds pbsds merged commit e70ddfa into NixOS:master Jun 4, 2025
16 of 17 checks passed
@HHR2020 HHR2020 deleted the joplin-desktop-fix branch June 6, 2025 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants