Skip to content

[25.05] wrangler: 3.80.1 -> 4.17.0#410722

Merged
wolfgangwalther merged 5 commits intoNixOS:release-25.05from
ryand56:backport/409572-410185
Jun 1, 2025
Merged

[25.05] wrangler: 3.80.1 -> 4.17.0#410722
wolfgangwalther merged 5 commits intoNixOS:release-25.05from
ryand56:backport/409572-410185

Conversation

@ryand56
Copy link
Member

@ryand56 ryand56 commented May 25, 2025 •
edited
Loading

Backports #409572, #410185, #411785

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 24.11 and 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 24.11 and 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 4.workflow: backport This targets a stable branch label May 25, 2025
@ryand56 ryand56 marked this pull request as draft May 25, 2025 07:39
@ryand56 ryand56 force-pushed the backport/409572-410185 branch from 5c04697 to c1bc755 Compare May 25, 2025 07:43
@github-actions github-actions bot added 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. labels May 25, 2025
@ryand56 ryand56 marked this pull request as ready for review May 25, 2025 07:54
@nix-owners nix-owners bot requested review from dezren39 and seanrmurphy May 25, 2025 08:00
dezren39
dezren39 approved these changes May 25, 2025
View reviewed changes
Copy link
Contributor

@dezren39 dezren39 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ryand56 ryand56 added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels May 25, 2025
@ryand56 ryand56 changed the title [25.05] wrangler: 3.80.1 -> 4.16.1 [25.05] wrangler: 3.80.1 -> 4.17.0 May 31, 2025
ezrizhu and others added 5 commits May 31, 2025 17:16
@ezrizhu @ryand56
maintainers: add ezrizhu
720f777 
(cherry picked from commit de3f417)
@ezrizhu @ryand56
wrangler: 3.80.1 -> 4.16.0
9c64622 
Also resolved below two build issues

* Broken symlinks: nixpkgs build now checks for broken symlinks, this PR
  adds all the relevant directories back to the out dir so all symlinks
  are intact.
* Missing npm: wrangler specifies an older version of pnpm than the one
  in pnpm_9 as used in the build process, this PR patches the
  package.json to remove the pnpm version so pnpm_9 doesn't attempt to
  change it's version resulting in a pnpm binary not found error. (with
  help from @cameronraysmith in NixOS#377334)

(cherry picked from commit 515e5fe)
@ezrizhu @ryand56
wrangler: add ezrizhu to maintainers
2f17cde 
(cherry picked from commit c332cf3)
@r-ryantm @ryand56
wrangler: 4.16.0 -> 4.16.1
19eee6f 
(cherry picked from commit caa6d7f)
@Guelakais @ryand56
wrangler: 4.16.1 -> 4.17.0
39ea6e5 
(cherry picked from commit 19d93ae)
@ryand56 ryand56 force-pushed the backport/409572-410185 branch from 38ebd19 to 39ea6e5 Compare May 31, 2025 23:17
@marcusramberg
Copy link
Contributor

marcusramberg commented Jun 1, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 410722
Commit: 39ea6e5d028166ef1d5f93e9ca2be563d0a6d615

x86_64-linux

✅ 1 package built:
  • wrangler

@wolfgangwalther wolfgangwalther merged commit 841cc2e into NixOS:release-25.05 Jun 1, 2025
15 of 18 checks passed
@ryand56 ryand56 deleted the backport/409572-410185 branch June 1, 2025 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@seanrmurphy seanrmurphy Awaiting requested review from seanrmurphy

1 more reviewer

@dezren39 dezren39 dezren39 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

4.workflow: backport This targets a stable branch 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@ryand56 @marcusramberg @dezren39 @wolfgangwalther @ezrizhu @r-ryantm @Guelakais