wrangler: 3.80.1 -> 4.16.0#409572
Merged
Sigmanificient merged 2 commits intoNixOS:masterfrom May 21, 2025
Merged
Conversation
Also resolved below two build issues * Broken symlinks: nixpkgs build now checks for broken symlinks, this PR adds all the relevant directories back to the out dir so all symlinks are intact. * Missing npm: wrangler specifies an older version of pnpm than the one in pnpm_9 as used in the build process, this PR patches the package.json to remove the pnpm version so pnpm_9 doesn't attempt to change it's version resulting in a pnpm binary not found error. (with help from @cameronraysmith in NixOS#377334)
ryand56
approved these changes
May 21, 2025
Member
ryand56
left a comment
There was a problem hiding this comment.
All tested and works in my flake as well, LGTM
Thanks for all your work on this!
13 tasks
13 tasks
Contributor
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release-25.05
git worktree add -d .worktree/backport-409572-to-release-25.05 origin/release-25.05
cd .worktree/backport-409572-to-release-25.05
git switch --create backport-409572-to-release-25.05
git cherry-pick -x 515e5fe4cc7e102199988d4010de70ccbbb7b1bb c332cf3d2935fd8bedae280158e2ce742c8596d1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #409155
Fixes #381980
Fixes #376947
Relates to #352287 but I think we should have a closer look to address the comments in a future commit.
Closes #377334
Upstream Changelog: https://github.com/cloudflare/workers-sdk/releases/tag/wrangler%404.16.0
Besides the version update, I also resolved two issues that prevented us from updating wrangler (context in the update request issue).
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.