Skip to content

wrangler: 3.80.1 -> 4.16.0#409572

Merged
Sigmanificient merged 2 commits intoNixOS:masterfrom
ezrizhu:wrangler
May 21, 2025
Merged

wrangler: 3.80.1 -> 4.16.0#409572
Sigmanificient merged 2 commits intoNixOS:masterfrom
ezrizhu:wrangler

Conversation

@ezrizhu
Copy link
Member

@ezrizhu ezrizhu commented May 21, 2025

Fixes #409155
Fixes #381980
Fixes #376947

Relates to #352287 but I think we should have a closer look to address the comments in a future commit.

Closes #377334

Upstream Changelog: https://github.com/cloudflare/workers-sdk/releases/tag/wrangler%404.16.0

Besides the version update, I also resolved two issues that prevented us from updating wrangler (context in the update request issue).

  • Broken symlinks: nixpkgs build now checks for broken symlinks, this PR adds all the relevant directories back to the out dir so all symlinks are intact.
  • Missing npm: wrangler specifies an older version of pnpm than the one in pnpm_9 as used in the build process, this PR patches the package.json to remove the pnpm version so pnpm_9 doesn't attempt to change it's version resulting in a pnpm binary not found error. (with help from @cameronraysmith)

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 24.11 and 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 24.11 and 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

ezrizhu added 2 commits May 21, 2025 18:47
Also resolved below two build issues

* Broken symlinks: nixpkgs build now checks for broken symlinks, this PR
  adds all the relevant directories back to the out dir so all symlinks
  are intact.
* Missing npm: wrangler specifies an older version of pnpm than the one
  in pnpm_9 as used in the build process, this PR patches the
  package.json to remove the pnpm version so pnpm_9 doesn't attempt to
  change it's version resulting in a pnpm binary not found error. (with
  help from @cameronraysmith in NixOS#377334)
@ezrizhu ezrizhu requested a review from cameronraysmith May 21, 2025 22:57
@github-actions github-actions bot added 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels May 21, 2025
@nix-owners nix-owners bot requested review from dezren39, ryand56 and seanrmurphy May 21, 2025 23:02
Copy link
Member

@ryand56 ryand56 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All tested and works in my flake as well, LGTM
Thanks for all your work on this!

@ryand56 ryand56 added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels May 21, 2025
@Sigmanificient Sigmanificient merged commit 96a5ce7 into NixOS:master May 21, 2025
37 of 41 checks passed
@cameronraysmith cameronraysmith mentioned this pull request May 22, 2025
13 tasks
@ryand56 ryand56 mentioned this pull request May 25, 2025
13 tasks
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Jun 4, 2025

Backport failed for release-25.05, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-25.05
git worktree add -d .worktree/backport-409572-to-release-25.05 origin/release-25.05
cd .worktree/backport-409572-to-release-25.05
git switch --create backport-409572-to-release-25.05
git cherry-pick -x 515e5fe4cc7e102199988d4010de70ccbbb7b1bb c332cf3d2935fd8bedae280158e2ce742c8596d1

@mdaniels5757 mdaniels5757 added the 8.has: port to stable This PR already has a backport to the stable release. label Jun 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: port to stable This PR already has a backport to the stable release. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update Request: wrangler 3.80.1 → 4.16.0 Build failure: wrangler Update Request: wrangler 3.80.1 → 3.105.1

4 participants