Skip to content

wrangler: 4.16.1 -> 4.17.0#411785

Merged
donovanglover merged 1 commit intoNixOS:masterfrom
Guelakais:wrangler
May 31, 2025
Merged

wrangler: 4.16.1 -> 4.17.0#411785
donovanglover merged 1 commit intoNixOS:masterfrom
Guelakais:wrangler

Conversation

@Guelakais
Copy link
Contributor

@Guelakais Guelakais commented May 28, 2025 •
edited
Loading

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 24.11 and 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 24.11 and 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Guelakais Guelakais requested review from ezrizhu and lucasew May 28, 2025 16:09
@github-actions github-actions bot added 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels May 28, 2025
@nix-owners nix-owners bot requested review from dezren39, ryand56 and seanrmurphy May 28, 2025 16:14
@ezrizhu ezrizhu self-assigned this May 28, 2025
@ezrizhu
Copy link
Member

ezrizhu commented May 28, 2025

i started a gha check run- and pasting this here for posterity's sake. https://github.com/cloudflare/workers-sdk/releases/tag/wrangler%404.17.0

@ezrizhu
Copy link
Member

ezrizhu commented May 28, 2025

could you add Closes #411774 to the PR body?

@ezrizhu
Copy link
Member

ezrizhu commented May 28, 2025

github actions is a bit broken right now- but builds on my machine (x86_64 linux)

@ezrizhu ezrizhu added 12.approvals: 2 This PR was reviewed and approved by two persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. 8.has: package (update) This PR updates a package to a newer version labels May 28, 2025
@ryand56 ryand56 added 12.approvals: 3+ This PR was reviewed and approved by three or more persons. and removed 12.approvals: 2 This PR was reviewed and approved by two persons. labels May 28, 2025
@ryand56
Copy link
Member

ryand56 commented May 28, 2025

Can you edit your PR title and commit to be wrangler: 4.16.1 -> 4.17.0? So OfBorg will build it correctly.

@Guelakais Guelakais changed the title cloudflare-wrangler: 4.16.1 -> 4.17.0 wrangler: 4.16.1 -> 4.17.0 May 29, 2025
@ezrizhu
Copy link
Member

ezrizhu commented May 29, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 411785

Logs: https://github.com/ezrizhu/nixpkgs-review-gha/actions/runs/15329182462

x86_64-linux (sandbox = true)

✅ 1 package built:
  • wrangler

aarch64-linux (sandbox = true)

✅ 1 package built:
  • wrangler

x86_64-darwin (sandbox = true)

✅ 1 package built:
  • wrangler

aarch64-darwin (sandbox = true)

✅ 1 package built:
  • wrangler

@donovanglover donovanglover merged commit 6fd36d4 into NixOS:master May 31, 2025
17 of 18 checks passed
@ryand56 ryand56 mentioned this pull request May 31, 2025
Merged
13 tasks
@Guelakais Guelakais deleted the wrangler branch July 15, 2025 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lucasew lucasew Awaiting requested review from lucasew

@seanrmurphy seanrmurphy Awaiting requested review from seanrmurphy

3 more reviewers

@dezren39 dezren39 dezren39 approved these changes

@ryand56 ryand56 ryand56 approved these changes

@ezrizhu ezrizhu ezrizhu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ezrizhu ezrizhu

Labels

8.has: package (update) This PR updates a package to a newer version 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 3+ This PR was reviewed and approved by three or more persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Guelakais @ezrizhu @ryand56 @dezren39 @donovanglover