Skip to content

turnon: 2.6.3 -> 2.7.4 #412512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 3, 2025
Merged

turnon: 2.6.3 -> 2.7.4 #412512

merged 1 commit into from
Sep 3, 2025

Conversation

@mksafavi
Copy link
Member

@mksafavi mksafavi commented May 30, 2025 •
edited
Loading

  • changed license to eupl12
  • updated to 2.7.4

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 24.11 and 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 24.11 and 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. labels May 30, 2025
@mksafavi mksafavi changed the title turnon: 2.6.3 -> 2.7.0 turnon: 2.6.3 -> 2.7.1 Jun 9, 2025
Aleksanaa
Aleksanaa reviewed Jun 9, 2025
View reviewed changes
Aleksanaa
Aleksanaa reviewed Jun 9, 2025
View reviewed changes
@Aleksanaa Aleksanaa marked this pull request as draft June 9, 2025 17:26
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Jul 28, 2025
@mksafavi mksafavi changed the title turnon: 2.6.3 -> 2.7.1 turnon: 2.6.3 -> 2.7.4 Aug 30, 2025
@mksafavi mksafavi marked this pull request as ready for review August 30, 2025 08:05
@mksafavi mksafavi requested a review from Aleksanaa August 30, 2025 08:07
@nixpkgs-ci nixpkgs-ci bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Aug 30, 2025
@mksafavi
Copy link
Member Author

mksafavi commented Sep 3, 2025

Hi.
Is there anything needed to merge this?

pbsds
pbsds reviewed Sep 3, 2025
View reviewed changes
pkgs/by-name/tu/turnon/package.nix Outdated
substituteInPlace justfile \
--replace-fail "version := \`git describe\`" "version := \"${version}\"" \
--replace-fail "DESTPREFIX := '/app'" "DESTPREFIX := '$out'" \
--replace-fail "just --list" "just compile"
Copy link
Member

@pbsds pbsds Sep 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please document what this final replacement does and why it is needed

@pbsbot
Copy link

pbsbot commented Sep 3, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 412512
Commit: b2883552a7dc8e99d13462a44a21f5cb4785a9d9

x86_64-linux

✅ 1 package built:
  • turnon

@pbsds pbsds merged commit 390b502 into NixOS:master Sep 3, 2025
28 of 31 checks passed
@mksafavi mksafavi deleted the update/turnon branch September 15, 2025 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pbsds pbsds pbsds left review comments

@Aleksanaa Aleksanaa Awaiting requested review from Aleksanaa

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mksafavi @pbsbot @pbsds @Aleksanaa @wegank