ci/compare: nix stats comparison#404731
Merged
hsjobeki merged 1 commit intoNixOS:masterfrom May 6, 2025
Merged
Conversation
Displays stats table in the step-summary if there are no added/removed packages
github-actions
bot
added
6.topic: continuous integration
nix-owners
bot
requested review from
LeSuisse,
infinisil,
mweinelt,
philiptaron,
risicle and
wolfgangwalther
github-actions
bot
added
10.rebuild-darwin: 0
Contributor
|
Successfully created backport PR for |
nixpkgs-ci
bot
added
the
8.has: port to stable
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reopen of #395113
I think the problem was that we where to eager with merging the comparison script and the pull request target didn't have a /stats directory. This might be cause because either the pull request target or the pull request base didn't include #399720 yet.
To allow for smoth transition and debugging possibilities i added gracefull handling of missing stats.
The change itself was already reviewed in #395113
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.