Skip to content

Revert "ci/compare: Bring back nix stats comparison"#403448

Merged
infinisil merged 1 commit intomasterfrom
revert-395113-ci/compare-stats
May 1, 2025
Merged

Revert "ci/compare: Bring back nix stats comparison"#403448
infinisil merged 1 commit intomasterfrom
revert-395113-ci/compare-stats

Conversation

@hsjobeki
Copy link
Contributor

@hsjobeki hsjobeki commented May 1, 2025

Reverts #395113

@github-actions github-actions bot added the 6.topic: continuous integration Affects continuous integration (CI) in Nixpkgs, including Ofborg and GitHub Actions label May 1, 2025
@infinisil
Copy link
Member

@infinisil infinisil merged commit 87d5e58 into master May 1, 2025
15 of 16 checks passed
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented May 1, 2025

Backport failed for release-24.11, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-24.11
git worktree add -d .worktree/backport-403448-to-release-24.11 origin/release-24.11
cd .worktree/backport-403448-to-release-24.11
git switch --create backport-403448-to-release-24.11
git cherry-pick -x a3520e957782c879440560180cd25c967d54364f

@JohnRTitor JohnRTitor deleted the revert-395113-ci/compare-stats branch May 5, 2025 15:39
@asymmetric
Copy link
Contributor

https://github.com/NixOS/nixpkgs/actions/runs/14783264902/job/41507002379?pr=391544

Is that the reason the commit got reverted? Or is there some context somewhere? Just for future reference/curiosity :)

@hsjobeki
Copy link
Contributor Author

Is that the reason the commit got reverted? Or is there some context somewhere? Just for future reference/curiosity :)

Yeah there was some problem. It was merged later with this PR.
#404731

Some Problems:

  • A directoy was a link and need to be resolved by realpath, for some reason python pathlib couldn't resolve it
  • In some edge cases during the transition phase one of the compared sources could not have the required stats, handled this gracefully, where it was a hard error before and made the CI fail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: continuous integration Affects continuous integration (CI) in Nixpkgs, including Ofborg and GitHub Actions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants