ci/eval: output per chunk stats#399720
Merged
infinisil merged 1 commit intoNixOS:masterfrom May 1, 2025
Merged
Conversation
github-actions
bot
added
6.topic: continuous integration
nix-owners
bot
requested review from
LeSuisse,
mweinelt,
philiptaron,
risicle and
wolfgangwalther
github-actions
bot
added
10.rebuild-darwin: 0
hsjobeki
force-pushed
the
ci-output-chunkstats
branch
from
1e0d55b to
882541e
Compare
hsjobeki
force-pushed
the
ci-output-chunkstats
branch
from
882541e to
cd1a8c5
Compare
hsjobeki
changed the title
infinisil
force-pushed
the
ci-output-chunkstats
branch
from
cd1a8c5 to
912878c
Compare
infinisil
force-pushed
the
ci-output-chunkstats
branch
from
912878c to
fa69ce0
Compare
Contributor
|
Successfully created backport PR for |
1 task
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As described in #395113
it would good to have stats for each individual eval chunk such that we collect some data already.
Before we going to implement the analysis on top of it.
I think it is fine to add the collection of data to all PRs already, we did the same for
stats.json, that way we have some actual data for tuning #395113Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.