hyperblobs: init at 2.8.0#404422
Conversation
Perhaps it would be more appropriate to package this as a node package then, since it's a node library. |
|
@emaryn, @eljamm thanks for the feedback! I chose |
I checked the documentation, again, and apparently:
So I guess adding this to
I wanted to see if there was any better place for this, but I think the best place is indeed |
This package is part of the Hypercore protocol and was previously packaged for the Hypermachines NLnet project. Now, it's being migrated from the NGIpkgs repo to Nixpkgs with the goal of using it to package
From what I've read, node_modules can still be useful by themselves, so we can technically use this when composing Also, from what I've seen, having libraries packaged by themselves isn't that new or odd of a pattern in nixpkgs: That said, if it turns out that we don't really need this in the future, it wouldn't be a big deal to remove it as this likely won't break any user workflow, but for the meantime this package (as well as the other |
eljamm
left a comment
There was a problem hiding this comment.
nixpkgs-review result
Generated using nixpkgs-review-gha
Command: nixpkgs-review pr 404422
Logs: https://github.com/eljamm/nixpkgs-review-gha/actions/runs/14924206142
x86_64-linux
✅ 1 package built:
- hyperblobs
aarch64-linux
✅ 1 package built:
- hyperblobs
x86_64-darwin
✅ 1 package built:
- hyperblobs
aarch64-darwin
✅ 1 package built:
- hyperblobs
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.