Skip to content

hyperblobs: init at 2.8.0#404422

Merged
fricklerhandwerk merged 1 commit intoNixOS:masterfrom
Axler1:migrate-hyperblobs
May 12, 2025
Merged

hyperblobs: init at 2.8.0#404422
fricklerhandwerk merged 1 commit intoNixOS:masterfrom
Axler1:migrate-hyperblobs

Conversation

@Axler1
Copy link

@Axler1 Axler1 commented May 5, 2025

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels May 5, 2025
@eljamm
Copy link
Contributor

eljamm commented May 7, 2025

How will users use it? If it's only accessible through API calls, it shouldn't be packaged.

Perhaps it would be more appropriate to package this as a node package then, since it's a node library.

@Axler1
Copy link
Author

Axler1 commented May 7, 2025

@emaryn, @eljamm thanks for the feedback! I chose pkgs/by-name/h/hyperblobs following the current nixpkgs packaging conventions, which recommend placing new packages under pkgs/by-name/, including Node.js libraries. Happy to adjust if there's consensus otherwise!

@eljamm
Copy link
Contributor

eljamm commented May 7, 2025

How will users use it? If it's only accessible through API calls, it shouldn't be packaged.

Perhaps it would be more appropriate to package this as a node package then, since it's a node library.

I checked the documentation, again, and apparently:

As a rule of thumb, the package set should only provide end user software packages, such as command-line utilities. Libraries should only be added to the package set if there is a non-npm package that requires it.

So I guess adding this to nodePackages isn't really viable.

I chose pkgs/by-name/h/hyperblobs following the current nixpkgs packaging conventions, which recommend placing new packages under pkgs/by-name/, including Node.js libraries

I wanted to see if there was any better place for this, but I think the best place is indeed pkgs/by-name

@eljamm
Copy link
Contributor

eljamm commented May 8, 2025

I still don't know why it was packaged?

This package is part of the Hypercore protocol and was previously packaged for the Hypermachines NLnet project. Now, it's being migrated from the NGIpkgs repo to Nixpkgs with the goal of using it to package Hypermachines in the future.

My opinion is that this is neither a package that can be used independently nor is it better than installing it with npm

From what I've read, node_modules can still be useful by themselves, so we can technically use this when composing Hypermachines.

Also, from what I've seen, having libraries packaged by themselves isn't that new or odd of a pattern in nixpkgs:

That said, if it turns out that we don't really need this in the future, it wouldn't be a big deal to remove it as this likely won't break any user workflow, but for the meantime this package (as well as the other Hypermachines components) will be maintained and hopefully composed into a better shape.

Copy link
Contributor

@eljamm eljamm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 404422

Logs: https://github.com/eljamm/nixpkgs-review-gha/actions/runs/14924206142


x86_64-linux

✅ 1 package built:
  • hyperblobs

aarch64-linux

✅ 1 package built:
  • hyperblobs

x86_64-darwin

✅ 1 package built:
  • hyperblobs

aarch64-darwin

✅ 1 package built:
  • hyperblobs

@eljamm eljamm added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels May 9, 2025
@FliegendeWurst FliegendeWurst added the 8.has: package (new) This PR adds a new package label May 11, 2025
@fricklerhandwerk fricklerhandwerk merged commit fe34046 into NixOS:master May 12, 2025
30 checks passed
@eljamm eljamm mentioned this pull request Sep 26, 2025
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

hyperblobs: NGIpkgs -> Nixpkgs

4 participants