Skip to content

hypercore: init at 11.7.0#403381

Merged
Aleksanaa merged 2 commits intoNixOS:masterfrom
goodylove:hypercore-init-at-11.6.2
May 16, 2025
Merged

hypercore: init at 11.7.0#403381
Aleksanaa merged 2 commits intoNixOS:masterfrom
goodylove:hypercore-init-at-11.6.2

Conversation

@goodylove
Copy link
Contributor

@goodylove goodylove commented May 1, 2025

  • Add and test updateScript for hypercore
  • Add goodylove to maintainers
  • Add The Nix@NGI team as a co-maintainer
  • Successfully built hypercore using nix-build -A hypercore

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@themadbit

This comment was marked as outdated.

Sign in to view
@goodylove goodylove force-pushed the hypercore-init-at-11.6.2 branch from 661e6cf to 32400c9 Compare May 1, 2025 19:18
@github-actions github-actions bot added 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels May 1, 2025
@goodylove goodylove mentioned this pull request May 1, 2025
Closed
eljamm
eljamm reviewed May 2, 2025
View reviewed changes
@goodylove goodylove requested a review from eljamm May 2, 2025 12:06
Aleksanaa
Aleksanaa reviewed May 4, 2025
View reviewed changes
@goodylove goodylove force-pushed the hypercore-init-at-11.6.2 branch 3 times, most recently from 7c117dd to 4c7a903 Compare May 5, 2025 10:11
@goodylove goodylove requested a review from Aleksanaa May 5, 2025 10:13
@goodylove goodylove force-pushed the hypercore-init-at-11.6.2 branch from 4c7a903 to dcb4efd Compare May 5, 2025 10:17
@ofborg ofborg bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label May 5, 2025
@goodylove goodylove force-pushed the hypercore-init-at-11.6.2 branch from dcb4efd to 98d9448 Compare May 5, 2025 10:29
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label May 5, 2025
eljamm
eljamm reviewed May 9, 2025
View reviewed changes
@goodylove goodylove force-pushed the hypercore-init-at-11.6.2 branch from 98d9448 to a48b849 Compare May 9, 2025 15:01
@goodylove goodylove requested a review from eljamm May 9, 2025 15:12
eljamm
eljamm approved these changes May 12, 2025
View reviewed changes
Copy link
Contributor

@eljamm eljamm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 403381

Logs: https://github.com/eljamm/nixpkgs-review-gha/actions/runs/14976399401

x86_64-linux

✅ 1 package built:
  • hypercore

aarch64-linux

✅ 1 package built:
  • hypercore

x86_64-darwin

✅ 1 package built:
  • hypercore

aarch64-darwin

✅ 1 package built:
  • hypercore

@eljamm eljamm added 8.has: package (new) This PR adds a new package 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels May 12, 2025
eljamm
eljamm suggested changes May 12, 2025
View reviewed changes
@eljamm eljamm removed the 12.approvals: 1 This PR was reviewed and approved by one person. label May 12, 2025
@goodylove goodylove force-pushed the hypercore-init-at-11.6.2 branch from a48b849 to 3123c90 Compare May 12, 2025 16:25
@eljamm eljamm mentioned this pull request May 12, 2025
Closed
24 tasks
@goodylove goodylove force-pushed the hypercore-init-at-11.6.2 branch from 3123c90 to a4c97b8 Compare May 12, 2025 16:44
@goodylove goodylove requested a review from eljamm May 12, 2025 16:53
0xda157
0xda157 reviewed May 13, 2025
View reviewed changes
@goodylove goodylove force-pushed the hypercore-init-at-11.6.2 branch from a4c97b8 to 3c4cbc1 Compare May 14, 2025 19:10
0xda157
0xda157 reviewed May 14, 2025
View reviewed changes
@goodylove goodylove force-pushed the hypercore-init-at-11.6.2 branch from 3c4cbc1 to a580c9b Compare May 15, 2025 13:24
@goodylove goodylove changed the title hypercore: init at 11.6.2 hypercore: init at 11.7.0 May 15, 2025
@goodylove goodylove requested a review from 0xda157 May 15, 2025 13:28
@0xda157
Copy link
Contributor

0xda157 commented May 15, 2025

$out only contains /lib, aren't js libraries not usually packaged in nixpkgs?

@eljamm
Copy link
Contributor

eljamm commented May 15, 2025

$out only contains /lib, aren't js libraries not usually packaged in nixpkgs?

They can still be used AFAIK, and we need it for an NGI project (more details).

@eljamm
Copy link
Contributor

eljamm commented May 15, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 403381

Logs: https://github.com/eljamm/nixpkgs-review-gha/actions/runs/15049160615

x86_64-linux

✅ 1 package built:
  • hypercore

aarch64-linux

✅ 1 package built:
  • hypercore

x86_64-darwin

✅ 1 package built:
  • hypercore

aarch64-darwin

✅ 1 package built:
  • hypercore

@eljamm eljamm added the 12.approvals: 2 This PR was reviewed and approved by two persons. label May 15, 2025
@Aleksanaa Aleksanaa merged commit 030e058 into NixOS:master May 16, 2025
27 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Aleksanaa Aleksanaa Awaiting requested review from Aleksanaa

2 more reviewers

@eljamm eljamm eljamm approved these changes

@0xda157 0xda157 0xda157 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@goodylove @themadbit @0xda157 @eljamm @Aleksanaa